Skip to content

fix: Improve performance of WorkspaceSvg.getNestedTrees() - #10236

Merged
gonfunko merged 1 commit into
mainfrom
nested-trees
Aug 7, 2026
Merged

gonfunko merged 1 commit into
mainfrom
nested-trees

Conversation

@gonfunko

@gonfunko gonfunko commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes part of #9162

Proposed Changes

This PR updates getNestedTrees() to loop through workspaces and check if they are children, rather than looping through all blocks, looking for mutator icons, and checking if they have a visible bubble. This is less fragile, more readable, and more performant, especially for large workspaces.

Test Coverage

I added some tests for this method as there were none previously.

@gonfunko
gonfunko requested a review from a team as a code owner August 6, 2026 15:40
@gonfunko
gonfunko requested a review from lizschwab August 6, 2026 15:40
@github-actions github-actions Bot added the PR: fix Fixes a bug label Aug 6, 2026
@gonfunko
gonfunko merged commit 2763f38 into main Aug 7, 2026
18 of 27 checks passed
@gonfunko
gonfunko deleted the nested-trees branch August 7, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants