Skip to content

feat(field-bitmap): Relax access restrictions on some FieldBitmap methods - #10525

Merged
gonfunko merged 1 commit into
mainfrom
bitmap-access
Sep 24, 2026
Merged

gonfunko merged 1 commit into
mainfrom
bitmap-access

Conversation

@gonfunko

Copy link
Copy Markdown
Contributor

The basics

The details

Proposed Changes

This PR moves dropdown creation/disposal and event firing methods in FieldBitmap from private to protected. Customizing the contents of the dropdown (and cleaning that up) is a reasonable thing for subclasses to do. Allowing access to event firing is also needed for Scratch, which needs to emit events with a stringified value rather than a 2D array.

@gonfunko
gonfunko requested a review from a team as a code owner September 24, 2026 17:23
@gonfunko
gonfunko requested a review from lizschwab September 24, 2026 17:23
@github-actions github-actions Bot added the PR: feature Adds a feature label Sep 24, 2026
@gonfunko
gonfunko merged commit 3e64190 into main Sep 24, 2026
15 of 19 checks passed
@gonfunko
gonfunko deleted the bitmap-access branch October 13, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: feature Adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants