Repository navigation
fix: Horizontal flyout bug fixes - #10581
Merged
Merged
Conversation
Contributor
|
Nice! This should fix #2309 |
lizschwab
approved these changes
Oct 19, 2026
lizschwab
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the detailed description with screenshots. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
This fixes a few flyout bugs that were discovered while working on
toolbox-searchimprovements. These are mostly noticeable with horizontal toolboxes and several are RTL-specific.The basics
Fixes #2309
Proposed Changes
Before


After
Before:


After:
Before:


After:
Before:


After:
4a. Buttons and labels were also misplaced, because their origin is their left edge rather than their right.


Before:
After:
toolbox-searchupdates feat!: update toolbox search UI #10551)Fixes 4-5 also work together to prevent having something like a statically-positioned search field overlap the blocks following the separator, which is relevant for
toolbox-searchupdates #10551).Before:


After:
Test Coverage
Tests for each fix were added.
Additional Information
Number 4-5 are needed to make the
toolbox-searchimprovements viable in RTL horizontal workspaces.