Skip to content

fix: Horizontal flyout bug fixes - #10581

Merged
mikeharv merged 1 commit into
RaspberryPiFoundation:mainfrom
mikeharv:flyout-rtl
Oct 19, 2026
Merged

mikeharv merged 1 commit into
RaspberryPiFoundation:mainfrom
mikeharv:flyout-rtl

Conversation

@mikeharv

@mikeharv mikeharv commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

The basics

The details

This fixes a few flyout bugs that were discovered while working on toolbox-search improvements. These are mostly noticeable with horizontal toolboxes and several are RTL-specific.

The basics

Fixes #2309

Proposed Changes

  1. Focusing a block in a flyout now scrolls it and its children into view. This impacts vertical flyouts too, e.g. a block stack with next-connected blocks. Previously, those child blocks could not be made visible via keyboard.

Before
focus-scroll-before
After
focus-scroll-after

  1. When horizontal flyout contents don't fill the available space in RTL, right-align everything.

Before:
rtl-right-align-before
After:
rtl-right-align-after

  1. Trailing separator removed from flyout contents. This was creating a pocket of extra space at the end of RTL flyouts.

Before:
image
After:
image

  1. In RTL horizontal toolboxes, after opening more than one category, blocks are pushed one flyout-width too far to the right, so scrolling left shows an empty area. Now blocks are always laid out consistently. New RTL blocks start at the flyout's width, which is 0 the first time the flyout opens (which is why it looks okay) and the full width after that (which is why we were getting the gap).

Before:
image
After:
image

4a. Buttons and labels were also misplaced, because their origin is their left edge rather than their right.
Before:
image
After:
rtl-button-spacing-after

  1. Leading separator is factored into content metrics. This makes it so we calculate the content area accordingly which enables you to scroll all the way to the bottom. (Relevant for toolbox-search updates feat!: update toolbox search UI #10551)
Before After
image image

Fixes 4-5 also work together to prevent having something like a statically-positioned search field overlap the blocks following the separator, which is relevant for toolbox-search updates #10551).

Before:
image
After:
image

Test Coverage

Tests for each fix were added.

Additional Information

Number 4-5 are needed to make the toolbox-search improvements viable in RTL horizontal workspaces.

@mikeharv
mikeharv requested a review from a team as a code owner October 16, 2026 21:29
@mikeharv
mikeharv requested a review from lizschwab October 16, 2026 21:29
@mikeharv
mikeharv marked this pull request as draft October 16, 2026 21:29
@github-actions github-actions Bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Oct 16, 2026
@gonfunko

Copy link
Copy Markdown
Contributor

Nice! This should fix #2309

@github-actions github-actions Bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Oct 19, 2026
@mikeharv
mikeharv marked this pull request as ready for review October 19, 2026 16:15
@mikeharv mikeharv mentioned this pull request Oct 19, 2026
1 task done

@lizschwab lizschwab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed description with screenshots. LGTM!

@mikeharv
mikeharv merged commit 03c915d into RaspberryPiFoundation:main Oct 19, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Horizontal RTL Flyouts are Left Aligned

3 participants