Skip to content

SQSCANGHA-184 Bump undici from 6.28.1 to 6.29.1 - #289

Merged
zglicz merged 2 commits into
masterfrom
dependabot/npm_and_yarn/undici-6.29.1
Oct 30, 2026
Merged

zglicz merged 2 commits into
masterfrom
dependabot/npm_and_yarn/undici-6.29.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 26, 2026

Copy link
Copy Markdown
Contributor

Bumps undici from 6.28.1 to 6.29.1.

Release notes

Sourced from undici's releases.

v6.29.1

Security fixes

High severity

Denial of service via TLS 1.2 certificate-changing renegotiation

CVE-2026-87018 · GHSA-qrxm-fqhp-jwvm

A malicious or compromised HTTPS server could crash the Node.js process by initiating TLS 1.2 renegotiation and presenting a different, CA-trusted certificate whose hostname did not match the requested host. The resulting socket error reached an assertion in undici's HTTP/1.1 and HTTP/2 connection handling. This release handles post-connect certificate errors without terminating the process.

TLS certificate validation bypass through dropped Agent options

CVE-2026-109383 · GHSA-2m5v-pch6-74hx

Agent used a JSON-based clone for constructor options, which silently removed function-valued TLS options such as checkServerIdentity. Applications relying on custom certificate or public-key verification could therefore accept a certificate that the callback was intended to reject. This release preserves TLS options when creating per-origin dispatchers.

Denial of service through excessive Content-Encoding values

CVE-2026-109869 · GHSA-xjj6-f33q-929c

A malicious HTTP server could crash the Node.js process by returning more than five content codings and closing the connection before sending the body. Although fetch() rejected the response, an error from an orphaned internal stream could remain unhandled. This release validates the content-encoding chain before creating the body stream and aborts oversized chains safely.

Medium severity

Denial of service through unbounded EventSource parser state

CVE-2026-109924 · GHSA-4qv8-2p9j-2685

A malicious Server-Sent Events endpoint could exhaust process memory by sending many tiny data: fields without completing an event, or by splitting an unfinished line across many chunks. This release bounds retained EventSource parser state, including field counts, buffered chunks, unfinished-line length, and retained field data.

Denial of service through unbounded automatic WebSocket PONG buffering

CVE-2026-109932 · GHSA-9fm3-97px-rjf6

A malicious WebSocket server could exhaust process memory by flooding the client with PING frames while not reading the automatic PONG responses. undici previously ignored socket backpressure and allowed the outbound queue to grow without bound. This release pauses frame parsing when PONG writes encounter backpressure and resumes after the socket drains.

What's Changed

Full Changelog: nodejs/undici@v6.29.0...v6.29.1

v6.29.0

What's Changed

... (truncated)

Commits
  • 8c57f6c [Release] v6.29.1 (#6023)
  • 39f93e1 fix(websocket): bound automatic PONG writes under backpressure
  • c43b23f fix(eventsource): bound retained SSE parser state
  • 1325a87 fix(fetch): abort excessive content encoding responses
  • 8c59f6b fix: preserve Agent connection options
  • b40fbfc fix: handle post-connect TLS certificate errors
  • 407630a [v6.x] fix(fetch): fix aborting Streams (#3754) (#6000)
  • e1d0501 Bumped v6.29.0 (#5888)
  • 57ac4de test: synchronize the issue-3356 body timeout (#5834)
  • 6d44174 Backport upgrade diagnostics lifecycle fixes to v6.x (#5833)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [undici](https://github.com/nodejs/undici) from 6.28.1 to 6.29.1.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v6.28.1...v6.29.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-version: 6.29.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from a team as a code owner October 26, 2026 08:48
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 26, 2026
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Bump undici from 6.28.1 to 6.29.1 SQSCANGHA-184 Bump undici from 6.28.1 to 6.29.1 Oct 26, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

SQSCANGHA-184

@datadog-sonarsource

This comment has been minimized.

Comment thread package-lock.json Resolved
@sonarqubecloud

Copy link
Copy Markdown

@gitar-bot

gitar-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 closed / 1 findings

🔴 High risk · The bundled undici upgrade changes TLS certificate handling and response limits; regressions could accept invalid certificates or let hostile servers crash the action.

Bumps undici from 6.28.1 to 6.29.1, picking up security fixes for TLS renegotiation crashes, dropped Agent TLS options, content-encoding abuse, and unbounded EventSource and WebSocket PONG buffering. The previously missing dist/ rebuild, which left the shipped action bundling 6.28.1, is now addressed in the rebuild commit. No open issues found.

✅ 1 closed
✅ Bug: dist/ not rebuilt, so the shipped action still bundles undici 6.28.1

📄 package-lock.json:1023-1025
This PR only changes package-lock.json. The action actually runs from the committed Rollup bundle in dist/, and that bundle includes undici's code inline (dist/core-zHKCwe9Y.js mentions undici 161 times). Until someone runs npm run build and commits the result, users of the action keep running undici 6.28.1, so whatever fix motivated the bump never reaches them. The Check dist/ is up-to-date step in .github/workflows/unit-tests.yml:31-37 rebuilds the bundle and runs git diff --exit-code dist/, so it should also fail on this PR once the new undici code is bundled. Fix: run npm ci && npm run build on this branch and commit the regenerated dist/ files.

Verification Rules 1/1 met PRs 2 inspected

Functional validation No results

Rules 1 passed 2 not applicable

✅ Repository license compliance

Broader impact PRs 2 inspected
Cross-PR 2 PRs inspected 0 open impacts

PR 286: SQSCANGHA-182: Honor SONAR_REGION in install-build-wrapper Inspected
PR 287: SQSCANGHA-181 Update certificate trust dependencies for eMudhra mitigation Inspected

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@zglicz
zglicz merged commit afe7ea1 into master Oct 30, 2026
78 checks passed
@zglicz
zglicz deleted the dependabot/npm_and_yarn/undici-6.29.1 branch October 30, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant