Bump toml from 0.8 to 0.9 - #1346
Merged
Merged
Conversation
toml 0.9 has been stable on crates.io since 2025-08-29. The single call site in this crate (src/config.rs:68) uses toml::from_str, which is stable across 0.8 and 0.9. No source changes required. toml 0.9's MSRV is 1.66, well under tokei's rust-version = "1.71". Verified: cargo build cargo test (22 passed, 0 failed) cargo fmt --all --check Note: cargo clippy on master currently fails with 7 pre-existing errors (unrelated to this change; reproduce with git stash && cargo clippy --all-targets -- -D warnings). CI does not run clippy, so this change does not affect CI results.
Contributor
Author
|
Hi - this PR has been sitting since 2026-04-19 with green CI across every target and no review comments. The change is narrow (toml 0.8 to 0.9). Is there anything blocking it, or anything I can help with? Context: Debian currently carries a relax-deps patch to widen tokei's toml upper bound so it keeps building against the toml transition in progress (salsa.debian.org/rust-team/debcargo-conf/-/issues/147). Landing this upstream would let that patch be dropped. |
Owner
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
Owner
Thank you, the project just isn't much of a focus for me at the moment. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
tomlfrom0.8.19to0.9(stable since 2025-08-29).The single call site is
src/config.rs:68, which usestoml::from_str(&s).ok(). That API is stable across 0.8 and 0.9, so no source changes are required.MSRV
toml 0.9.0's MSRV is1.66, well under tokei's currentrust-version = "1.71". No MSRV impact.Verification
cargo build: cleancargo test: 22 passed, 0 failedcargo fmt --all --check: cleanNote:
cargo clippy --all-targets -- -D warningscurrently fails with 7 pre-existing errors on master (reproducible on vanilla master before this change). CI does not run clippy, so this bump does not affect CI results.Lockfile
cargo update --package toml --precise 0.9.11produced the 90-line lockfile diff. Most of the churn is addingtoml_writer 1.1.1and splittingwinnow(the toml 0.9 stack depends onwinnow 0.7in some places andwinnow 1.0in others). This matches what every consumer of toml 0.9 will see.Context
The bump is part of the Debian Rust team's
toml 0.9transition (tracked at debcargo-conf#147). tokei is one of the reverse-dependencies currently on 0.8; merging this removes it from the transition list.