Feature request: add GOBIN to PATH even if a version isn't installed

Request: setup-go should always add GOBIN to PATH, even if it uses the default Go installed in the environment. This would mirror how it always sets up Go matchers.

Per thread here: #39 (comment)

Thanks!

@ydnar

@ydnar I tried now with new version (setup-go@v2), and apparently it's adding GOBIN to PATH, working well at my repository.

@ydnar

@ydnar I tried now with new version (setup-go@v2), and apparently it's adding GOBIN to PATH, working well at my repository.

Did you specify go-version?

I had the same issue, after running go mod download the packages bins are not in path, using version v2

Edit: looks like go mod download does not put binaries in GOBIN

Seems like using this one-liner - uses: actions/setup-go@v2 just for setting the env won't work out

@subins2000

@subins2000 adding that one liner (setup-go@v2) does add gobin to the path.

Just tried. Look at the path step in this run.

The second entry of the path in this example has /home/runner/go/bin added

@bryanmacfarlane

@bryanmacfarlane It didn't work for me on a Windows host and bash, so had to do :

echo "::set-env name=GOPATH::$(go env GOPATH)"
echo "::add-path::$(go env GOPATH)/bin"

The above is deprecated in the latest images. Using this now :

echo $(go env GOPATH)/bin >> $GITHUB_PATH

I'll try it out on windows.

The code is adding it to the path (it actually does your second line of add-path - even on windows). Note it does not set GOPATH as that's a < go 1.12 and pre go modules concept. If that's your use case, you can set.

It also doesn't set GOBIN (but go/bin is added to path). do we think it should?

In my builds this yml is not resulting in GOBIN being in the PATH. If I go get tools they install fine but aren't available on the PATH.

This is a snippet from my workflow:

name: build
on: [push, pull_request]
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/setup-go@v2
    - uses: actions/setup-ruby@v1
    - run: go get github.com/mattn/goreman
    - run: goreman ...

This is what I see if I echo PATH:

/opt/hostedtoolcache/Ruby/2.7.2/x64/bin:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

@bryanmacfarlane

@bryanmacfarlane I'm not sure how it works for you, because in your output there is the line Added go to the path, and the only place that line is printed is below and is wrapped in a if (versionSpec):

setup-go/src/main.ts

Lines 23 to 31 in d0c5def

    
           if (versionSpec) { 
        
             let token = core.getInput('token'); 
        
             let auth = !token || isGhes() ? undefined : `token ${token}`; 
        
             const installDir = await installer.getGo(versionSpec, stable, auth); 
        
             core.exportVariable('GOROOT', installDir); 
        
             core.addPath(path.join(installDir, 'bin')); 
        
             core.info('Added go to the path');

I've opened a PR #89 that adds GOBIN to PATH regardless of whether a version is specified. I tested it on my own repo and it worked in both cases.

wip: testing a fix for actions/setup-go#49

set go-version explicitly to add GOBIN to PATH

@ydnar

Hi @ydnar ! Sorry for the late response!
Could you please clarify if the issue is still actual for you?
Thanks!

@ydnar

Hi @ydnar ! Sorry for the late response!
Could you please clarify if the issue is still actual for you?
Thanks!

Honestly, I haven’t checked. All of our uses of actions/setup-go specify version: ^1 now:

      - name: Set up Go
        uses: actions/setup-go@v2
        with:
          go-version: ^1

@Sergey-Murtazin

@Sergey-Murtazin PR with a fix is open at #89.

Seems it didn't

Hello everyone. We added this logic in new major action version. For now I'm going to close the issue. If you have any concerns feel free to ping us.

Navigation Menu

Repository navigation

Feature request: add GOBIN to PATH even if a version isn't installed #49

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (versionSpec) {
	let token = core.getInput('token');
	let auth = !token \|\| isGhes() ? undefined : `token ${token}`;

	const installDir = await installer.getGo(versionSpec, stable, auth);

	core.exportVariable('GOROOT', installDir);
	core.addPath(path.join(installDir, 'bin'));
	core.info('Added go to the path');

Feature request: add GOBIN to PATH even if a version isn't installed #49

Description

Activity

fsilva3 commented on May 11, 2020

ydnar commented on May 11, 2020

remorses commented on Jun 6, 2020

subins2000 commented on Nov 8, 2020

bryanmacfarlane commented on Nov 9, 2020

subins2000 commented on Nov 9, 2020

bryanmacfarlane commented on Nov 9, 2020

leighmcculloch commented on Dec 3, 2020

leighmcculloch commented on Dec 3, 2020

leighmcculloch commented on Dec 4, 2020

Sergey-Murtazin commented on Oct 19, 2021

ydnar commented on Oct 19, 2021

leighmcculloch commented on Nov 7, 2021

dmitry-shibanov commented on Mar 16, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions