Skip to content

feat(dsh): collect natural Skill follow-up feedback - #276

Merged
zpzjzj merged 8 commits into
mainfrom
feat/dsh-natural-feedback
Sep 28, 2026
Merged

zpzjzj merged 8 commits into
mainfrom
feat/dsh-natural-feedback

Conversation

@zpzjzj

@zpzjzj zpzjzj commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Document the English code-stats invocation, feedback, improvement, and regression example for the DeepSeek Harness plugin.
  • Link a user's next turn to the preceding single-Skill observation in the same DSH session, within one hour. Store it as an unclassified follow-up candidate, with redaction and replay-safe deduplication.
  • Add paginated collect_skill_feedback so an agent can review the full observation history for a Skill, cite source IDs, and suggest a change. The observer does not edit Skills or schedule reviews.
  • Fix the packaged README demo link to point to the repository page.

Validation

  • npm test in plugins/dsh-skill-up: 35 passed.
  • make verify: passed (0 lint issues).
  • make test: passed, including Codex plugin tests and Go race tests.
  • Resumed a real DSH ACP session: code-stats counted a dependency file, the next natural user message was linked to the original observation, and a later review summarized that issue with its observation ID.

Scope and limits

  • Next-turn text is a candidate for review, not classified as feedback automatically. Ambiguous multi-Skill turns and cross-session messages are not linked.
  • The worked example has one observed issue and one baseline/post-change evaluation; it does not establish a recurring pattern or reliability rate.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T02:22:24.816892Z 17cd413 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17cd413d56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/dsh-skill-up/lib/observer.js

@JHWang-1997 JHWang-1997 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zpzjzj
zpzjzj added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit b85649b Sep 28, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants