Repository navigation
fix(judge): preserve tool argument structure when matching - #304
Merged
zpzjzj merged 1 commit intoOct 9, 2026
Merged
Conversation
mavericksea-ai
requested review from
JHWang-1997,
hittyt and
zpzjzj
as code owners
October 8, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tool-argument rules currently compare formatted text, so
paths: ["sales 2025.csv"]matchespaths: ["sales", "2025.csv"]. A wrong file request passes the rule and can make CI succeed. In an offline benchmark, this reports 100% versus 100% and zero lift; structural comparison correctly reports 0% versus 100%, −1.00 lift, and exit code 1.Related issues
Closes #303.
Changes
tool_calledandtool_called_in_turn, plus structured collisions and compatibility cases; update the changelog.Test plan
make testpasses (race-enabled Go tests and 22 plugin tests)make verifypasses (fmt + vet + lint), using Go 1.25.13 with the repository's pinned toolsmake fmtrunNotes for reviewers
The current Go 1.27 compiler produces export data unsupported by the pinned lint tool;
make verifypasses with the supported Go 1.25.13 toolchain. No module files or lint rules were changed. E2E-tag tests are not required for this change because no runner or e2e files changed; the separate reproduction runs the CLI end to end.