Repository navigation
feat(server_openvr): ✨ Defer TrackedDevices initialization - #2754
Merged
Merged
Conversation
zmerp
force-pushed
the
deferred-steamvr-init
branch
from
March 14, 2025 02:56
c581a03 to
45477fb
Compare
zmerp
force-pushed
the
deferred-steamvr-init
branch
from
March 14, 2025 03:25
45477fb to
e06ab43
Compare
zmerp
force-pushed
the
deferred-steamvr-init
branch
from
March 14, 2025 04:01
bd3855a to
511a005
Compare
| this->device_class, | ||
| (vr::ITrackedDeviceServerDriver*)this | ||
| )) { | ||
| Error("Failed to register device"); |
Collaborator
There was a problem hiding this comment.
This could maybe use some additional information like the serial number, to aid in debugging
The-personified-devil
previously approved these changes
Mar 17, 2025
The-personified-devil
left a comment
The-personified-devil
left a comment
Collaborator
There was a problem hiding this comment.
Idk if you wanna action on that logging thing, but apart from that LGTM
Member
Author
|
Sorry, I made the commit but I didn't push |
The-personified-devil
approved these changes
Mar 17, 2025
SingleInfiniteLoop
added a commit
to SingleInfiniteLoop/ALVR
that referenced
this pull request
May 2, 2025
…lvr-org#2754)" This reverts commit dfaa137.
SingleInfiniteLoop
added a commit
to SingleInfiniteLoop/ALVR
that referenced
this pull request
May 2, 2025
…lvr-org#2754)" This reverts commit dfaa137.
zmerp
added a commit
that referenced
this pull request
Jun 27, 2025
* feat(server_openvr): ✨ Defer TrackedDevices initialization * Use a condition_variable to wait for TrackedDevice activation * Address comment
Merged
zmerp
added a commit
that referenced
this pull request
Jun 30, 2025
* feat(server_openvr): ✨ Defer TrackedDevices initialization * Use a condition_variable to wait for TrackedDevice activation * Address comment
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I make the following changes:
DriverProvider::Init()toInitializeStreaming()TrackedDevice::registrer_device()now waits for theITrackedDeviceServerDriver::Activate()call.g_driver_provideruntil they are successfully activated. This requires changing the signature ofSetOpenvrProps()andRegisterButtons()to reference the devices by pointer instead of ID. Allow controllers and trackers to fail registration (we are already handling the absence of any of these devices)Notably, In this PR i'm not implementing the skip of the first SteamVR restart when the client first connects, this will be done in the next PRs.