Repository navigation
fix(dashboard): Fix issues starting ALVR on Windows - #2766
Conversation
curoviyxru
changed the title
|
|
||
| alvr_server_io::driver_registration(&[alvr_driver_dir], true).ok(); | ||
|
|
||
| data_sources::get_local_session_source().session_mut(); |
There was a problem hiding this comment.
This feels like a hack. But i think the original code was racey anyway. I have plans to pass the settings to the c++ side without going through the session.json file, but this will do for now
There was a problem hiding this comment.
session_mut() is called only when something is changed so it should be created somewhere anyway. maybe it should be triggered by making default server_version not equal to current version.
There was a problem hiding this comment.
I'm reading now your message on Discord, you probably should move the session initialization back to the driver, in place of the path backup mechanism
| pub fn new(root: &Path) -> Option<Self> { | ||
| let root = root.canonicalize().ok()?; | ||
|
|
There was a problem hiding this comment.
Given that now Layout::new() is now infallible, the Option<> should be removed from the return type. Check the changes of the faulty commit to see all the places that should be reverted
a092ff5 to
18f3c5c
Compare
* fix: Fix file paths on Windows * fix: Save session file before starting SteamVR * chore: Format code * refactor: Remove Option from Layout::new * refactor: Move session saving to environment init * chore: Add comment for session saving
* fix: Fix file paths on Windows * fix: Save session file before starting SteamVR * chore: Format code * refactor: Remove Option from Layout::new * refactor: Move session saving to environment init * chore: Add comment for session saving
No description provided.