Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

textarea: long textarea causes scroll jumping issues #3070

Open

Description

@asans

Place a textarea inside a content pane (ie. md-content or md-dialog-content). As one starts to create a very long message that span many rows and causes overflow to occur and scrollbars to show, one will notice that when you type anything, the scrollbar will jump to the top of the overflow content pane. If one tries to type text, the screen will jump down to the text (which is what the browser does automatically) but then the screen is immediately jumped back up to the top of the scrolling content.

The result is that you cannot see what you're typing once you get to a very long text message. Additionally, the scroll jumping causes headaches. Somewhere along the line, I think someone is doing some sort of scroll reset or setting the scrollTop.

You can duplicate this using the Demo on ngmaterial website.

https://material.angularjs.org/latest/#/demo/material.components.input

Simply keep creating new rows and making the overflown content type expand until it begins to jump.

Activity

  1. mckenzielong commented on Jun 2, 2015

    @mckenzielong
    Contributor

    This is happening because of this line in growTextarea():

    node.style.height = "auto";

    This handles the shrinking (and also expanding, but as far as I can see it is really here for shrinking) of the textarea by setting the height back to auto.

    I took a stab at a fix for this today as it was interfering with a part of my project, and perhaps this will work for anyone looking for a temp fix... I have only tested this on webkit. In src/components/input/input.js:

    Add the variable minTextAreaHeight to setupTextarea(), we will use this for saving the initial height to limit shrinking.

    function setupTextarea() {
      var node = element[0];
      var onChangeTextarea = $mdUtil.debounce(growTextarea, 1);
      var minTextareaHeight;
    ...

    Adjust the scroll event listener to call the same textarea change function. Remove onScroll as it will no longer be needed.

    element.on('scroll', onChangeTextarea);

    growTextarea becomes:

      function growTextarea() {
        node.scrollTop = 0;
        var height = getHeight();
        if (height) node.style.height = height + 'px';
        }

    getHeight becomes:

    function getHeight() {
      var line = node.scrollHeight - node.offsetHeight;
      var height = Number(window.getComputedStyle(node)["height"].replace("px", ""));
      var lineHeight = Number(window.getComputedStyle(node)["line-height"].replace("px", ""));
      var newHeight = height + (line >= 0 ? line : lineHeight*-1);
    
      //cache the initial height that can be adjusted using 'rows'
      if (!minTextareaHeight) {
        minTextareaHeight = height
      }
    
      if (newHeight <= minTextareaHeight) {
          return minTextareaHeight;
      } else {
          return newHeight;
      }
    }

    As I mentioned, I am sure this is a better way of doing this.

  2. mckenzielong commented on Jun 4, 2015

    @mckenzielong
    Contributor

    Also, this is a dupe of #3024

  3. orange-buffalo commented on Jun 6, 2015

    @orange-buffalo

    @mckenzielong, I applied the fix you proposed for my application and textarea behaves fine now. Thank you!

  4. WhiteAbeLincoln commented on Jun 8, 2015

    @WhiteAbeLincoln

    This also happens when the textarea is in a tab container. When you don't have md-dynamic-height on, the jumping starts much sooner. When you do have md-dynamic-height applied to the tabs, then the scrollbar doesn't jump until it reaches the bottom of the mdcontent area.

    I havent tried @mckenzielong's fix yet, but I'll update if it works for me.

    plunker

  5. WhiteAbeLincoln commented on Jun 8, 2015

    @WhiteAbeLincoln

    @mckenzielong Your fixed worked for me, even in a tab container. There is still a slight jump when a newline is added (press enter key), but as soon as you start typing, the textarea focuses on the correct line, without jumps. I think that is reasonable, and isn't that annoying.

    Another thing is if you select the content of the textarea and press the backspace, the content is deleted, including the newlines, but the textarea stays the same size. When you start typing again the content area shrinks everytime you hit a key, but there wasn't actually anything in the content area... This didn't happen with the old text area, but I don't find it to be too much of an issue.

    here is a screenrecording of the issue

    This isn't too much of an issue, and the textarea is a ton better after this fix, so I think this fix outweighs the minor new issues.

    If this works in all of the use cases you can think of, and hasn't broken anything else, then I suggest you submit a pull request. I'm sure the developers would appreciate it, since they have 700+ open issues right now.

  6. kamarouski commented on Jun 13, 2015

    @kamarouski

    👍 have the same issue in my project as well. Looking forward to the official fix.

  7. DevinHolland commented on Jun 14, 2015

    @DevinHolland

    Same problem here. @mckenzielong This fix worked, thank you! Hope this fix makes it into the repo soon.

  8. mckenzielong commented on Jun 16, 2015

    @mckenzielong
    Contributor

    Here is a different (better?) fix based on how iron-autogrow-textarea works. This gets rid of the case when the textarea doesn't collapse based on a large delete (as @WhiteAbeLincoln demonstrated above.) Again, I have only tested this on webkit.

    First add the following css:

    md-input-container .md-textarea-container {
        display: inline-block;
        position: relative;
        padding:0;
        border-bottom: none;
    }
    
    md-input-container .md-textarea-container textarea {
        height: 100%;
        position: absolute;
        width: 100%;
        padding:0;
    }
    
    md-input-container .md-textarea-container .md-textarea-mirror {
        padding-top: 2px;
        padding-left: 2px;
        padding-right: 2px;
        width: 100%;
        min-height: 56px;
        visibility: hidden;
        word-wrap: break-word;
    }

    Next, in input.js, make the following changes:
    Change the scroll listener and remove onScroll

    element.on('scroll', onChangeTextarea);

    Adjust setupTextarea()

    function setupTextarea() {
      var mirror = angular.element('<div class="md-textarea-mirror"></div>');
      var onChangeTextarea = $mdUtil.debounce(growTextarea, 1);
      var minTextareaHeight;
    
      element.wrap('<div class="md-textarea-container md-input"></div>');
      element.after(mirror);
      ...

    Adjust growTextarea()

    function growTextarea() {
      var rows = element.prop('rows');
      //see https://github.com/PolymerElements/iron-autogrow-textarea/blob/master/iron-autogrow-textarea.html
      var tokens = element.val().replace(/&/gm, '&amp;').replace(/"/gm, '&quot;')
        .replace(/'/gm, '&#39;').replace(/</gm, '&lt;').replace(/>/gm, '&gt;').split('\n');
      while (rows > tokens.length) {
        tokens.push('');
      }
    
      mirror.html(tokens.join('<br>') + '&nbsp;');
    }
  9. modified the milestone: 0.11.0 on Jun 16, 2015
  10. asans commented on Jul 4, 2015

    @asans
    Author

    This issue didn't get closed, but I assume this should be addressed and fixed by commit:

    5fdcf90

    Whether new bugs appear is likely a separate story.

  11. mckenzielong commented on Jul 4, 2015

    @mckenzielong
    Contributor

    Please reopen. The issue still present in demo, same root cause:

    node.style.height = "auto";
  12. reopened this on Jul 4, 2015
  13. 97 remaining items

  14. saurabhsingh1003 commented on Sep 9, 2020

    @saurabhsingh1003
  15. Splaktar commented on Sep 20, 2020

    @Splaktar
  16. self-assigned this
    on Sep 20, 2020
  17. added
    P3: importantImportant issues that really should be fixed when possible.
    on Sep 20, 2020
  18. modified the milestones: - Backlog, 1.2.2 on Sep 20, 2020
  19. removed
    P4: minorMinor issues. May not be fixed without community contributions.
    on Sep 20, 2020
  20. Splaktar commented on Sep 20, 2020

    @Splaktar
    Contributor

    I just tried to reproduce this on iOS (iPad OS 14.0) using Safari 14, but I was not able to do so on https://material.angularjs.org/1.2.0/demo/input#basic-usage.

    If anyone can provide a reproduction demo and steps for iOS, please let me know.

    I'll try to take a look on Windows soon.

  21. Splaktar commented on Sep 20, 2020

    @Splaktar
    Contributor

    Here the codepen, http://codepen.io/kiro64/pen/gPOmxp
    on my codepen safari is work fine, but still have an issue on firefox

    I tried to reproduce this on macOS using Firefox 80.0.1 with an updated CodePen but I was not able to reproduce it. I had to fix up the CodePen a bit to get it to render properly since the way that md-input-container was being used wasn't correct. But auto growing was working fine w/o any jumping on Firefox and Chrome.

  22. modified the milestones: 1.2.2, - Backlog on Oct 20, 2020
  23. justusromijn commented on Dec 1, 2021

    @justusromijn

    Just want to chip in here, not related to angular material, but a native solution to this scrolling issue with auto-height trigger to do a calculation. What I've done, is before setting the height to auto for the textarea, have another element next to it take over the current height, and when the new height is calculated, apply this also to that other element. This way, the space stays reserved and the page won't notice a height-drop when setting the textarea to auto. You could see this as some sort of memoization pattern for the height :)

    Pseudo code below:

    <textarea id="my-textarea" />
    <div id="my-textarea-stub" />
    calculateTextareaHeight() {
    const textarea = document.querySelector('#my-textarea');
    const textareaStub = document.querySelector('#my-textarea-stub');
    // store the reserved height in our stub element before setting "auto"
    textareaStub.style.height = textarea.style.height;
    textarea.style.height = 'auto';
    
    // some real calculations here...
    let someCalculatedHeight = 2000;
    
    // reset the textarea height, and after that, reset the stub height
    textarea.style.height = `${someCalculatedHeight}px`;
    textareaStub.style.height = textarea.style.height;
  24. codeunifier commented on Feb 25, 2022

    @codeunifier

    Seeing this issue as well in Catalina / Safari 14 using an angular directive to manually change the textarea height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions