Skip to content

Fix nested values in MapMessage - #2672

Merged
cshannon merged 3 commits into
apache:mainfrom
cshannon:2669-map-message-fix
Oct 15, 2026
Merged

cshannon merged 3 commits into
apache:mainfrom
cshannon:2669-map-message-fix

Conversation

@cshannon

@cshannon cshannon commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

This fixes the string encoding for MapMessages so that nested strings are properly returned as String values again instead of UTF8Buffers

This PR also adds a bunch of missing tests for MarshallingSupport and to ActiveMQMapMesage to verify the nested types

This is a fix for a regression introduced in #2080

This closes #2669

This fixes the string encoding for MapMessages so that nested strings
are properly returned as String values again instead of UTF8Buffers

This is a fix for a regression introduced in apache#2080

This closes apache#2669
tabish121
tabish121 previously approved these changes Oct 15, 2026

@tabish121 tabish121 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can recall of the decoding mechanism for the Map contents this seems like it should handle the nested versions correctly now

mattrpav
mattrpav previously approved these changes Oct 15, 2026
@cshannon
cshannon dismissed stale reviews from mattrpav and tabish121 via d32ae53 October 15, 2026 18:58
@cshannon
cshannon merged commit 92d5249 into apache:main Oct 15, 2026
9 checks passed
@cshannon
cshannon deleted the 2669-map-message-fix branch October 15, 2026 19:02
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Apache ActiveMQ v6.4.0 Oct 15, 2026
cshannon added a commit that referenced this pull request Oct 15, 2026
* Fix nested values in MapMessage

This fixes the string encoding for MapMessages so that nested strings
are properly returned as String values again instead of UTF8Buffers

This is a fix for a regression introduced in #2080

This closes #2669

(cherry picked from commit 92d5249)
cshannon added a commit that referenced this pull request Oct 15, 2026
* Fix nested values in MapMessage

This fixes the string encoding for MapMessages so that nested strings
are properly returned as String values again instead of UTF8Buffers

This is a fix for a regression introduced in #2080

This closes #2669

(cherry picked from commit 92d5249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

MapMessage nested List/Map values return String elements as UTF8Buffer instead of java.lang.String (6.3.2 regression)

3 participants