Repository navigation
JavadocLinkGenerator.createLink(String) must consider module names - #1039
Merged
kwin merged 1 commit intoDec 23, 2025
Merged
Conversation
Member
Author
|
Module specific internal javadoc tracked separately in #1040. This requires some more effort and is right now pretty much an edge case. |
kwin
force-pushed
the
bugfix/javadoc-url-for-package-and-classname-with-modules
branch
from
December 16, 2025 08:03
ea37e1c to
ee26944
Compare
kwin
marked this pull request as ready for review
December 16, 2025 08:03
slawekjaranowski
approved these changes
Dec 19, 2025
When link towards external javadoc with modules generated include the module name in the URL path This closes #1038
kwin
force-pushed
the
bugfix/javadoc-url-for-package-and-classname-with-modules
branch
from
December 23, 2025 10:48
ee26944 to
4541bd0
Compare
michael-o
removed their request for review
December 23, 2025 10:52
kwin
deleted the
bugfix/javadoc-url-for-package-and-classname-with-modules
branch
December 23, 2025 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When link towards external javadoc with modules generated include the module name in the URL path
This closes #1038
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.