Skip to content

[MSHADE-420] create IT: 2 runs with different TZ give different jars - #179

Merged
hboutemy merged 2 commits into
masterfrom
MSHADE-420
Jan 31, 2024
Merged

hboutemy merged 2 commits into
masterfrom
MSHADE-420

Conversation

@hboutemy

@hboutemy hboutemy commented Mar 4, 2023

Copy link
Copy Markdown
Member

Comment thread src/it/projects/MSHADE-420/invoker.properties Outdated
@elharo
elharo requested a review from slawekjaranowski March 21, 2023 11:34
@hboutemy
hboutemy force-pushed the MSHADE-420 branch 2 times, most recently from b8d3c30 to c789e81 Compare January 21, 2024 15:42
@hboutemy

Copy link
Copy Markdown
Member Author

@michael-o @slawekjaranowski based on latest enhancement in the IT, it seems there is an inconsistency in ZipEntry:

  • if it's basic xdos time, the time is calculated against current TZ
  • but if it's mtime from extra fields, the time is not calculated against TZ
    given setTime always expects a time against current TZ, this is what gives the current difference

the problem is that i don't see how to workaround...
any idea?

@hboutemy

Copy link
Copy Markdown
Member Author

finally, I found a workaround in 079560e (that still needs to be enhanced, but at least, it proves the concept)
review appreciated

Comment thread src/it/projects/MSHADE-420/invoker.properties Outdated
Comment thread src/it/projects/MSHADE-420/verify.groovy Outdated
Comment thread src/it/projects/MSHADE-420/verify.groovy Outdated
Comment thread src/it/projects/MSHADE-420/verify.groovy Outdated
Comment thread src/it/projects/MSHADE-420/zipdetails.txt Outdated
@hboutemy
hboutemy requested a review from michael-o January 23, 2024 05:50
@hboutemy
hboutemy force-pushed the MSHADE-420 branch 2 times, most recently from eee3cb0 to 9e53c7e Compare January 30, 2024 07:08
@hboutemy
hboutemy merged commit bd982e7 into master Jan 31, 2024
@hboutemy
hboutemy deleted the MSHADE-420 branch January 31, 2024 17:57
@jira-importer

Copy link
Copy Markdown

Resolve #435

1 similar comment
@jira-importer

Copy link
Copy Markdown

Resolve #435

@olamy olamy added this to the 3.6.1 milestone Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants