Repository navigation
Feat: Ability to disable site lifecycle - #11970
Merged
cstamas merged 2 commits intoApr 21, 2026
Merged
Conversation
Ability to suppress site lifecycle from Maven "default lifecycles". Note: this does not remove "site" Lifecycle component, but Maven will not consider site lifecycle, if disabled. Fixes apache#11759
cstamas
marked this pull request as ready for review
April 20, 2026 22:35
cstamas
changed the title
Comment on lines
+55
to
+56
| private static final boolean SITE_ENABLED = | ||
| Boolean.parseBoolean(System.getProperty("maven.site.lifecycle.enabled", "true")); |
Member
There was a problem hiding this comment.
can we also use a user properties for it?
or repos session config props?
Member
Author
There was a problem hiding this comment.
That is too late. This component is constructed as part of object graph before any session is being created... Will look more around tomorrow
Member
Author
There was a problem hiding this comment.
Looked around, and in many places session is not present/passed over. While we could alter these classes, that would lead to many potential breakages.
I consider this use case "special" or "very edge", so IMO Java System property is good to cover it.
michael-o
reviewed
Apr 21, 2026
| private static final List<String> BUILT_IN_LIFECYCLES = | ||
| Arrays.asList(CleanLifecycleProvider.NAME, DefaultLifecycleProvider.NAME, SiteLifecycleProvider.NAME); | ||
| private static final boolean SITE_ENABLED = | ||
| Boolean.parseBoolean(System.getProperty("maven.site.lifecycle.enabled", "true")); |
Member
There was a problem hiding this comment.
Why not Boolean.getBoolean()?
Member
Author
There was a problem hiding this comment.
How to default it to true?
Member
There was a problem hiding this comment.
Indeed, you can't, but maybe we should invert the logic anyway? Site lifecycle is always enabled unless you explicitly disable this, e.g., -DskipTests=true and other skippers. -Dmaven.site.lifecycle.skip?
Member
Author
There was a problem hiding this comment.
Well, I could agree. But this is not skipping it, it is like "pretending is not there" (filter it out, remove it from default ones).
Member
Author
There was a problem hiding this comment.
Maybe just maven.site.lifecycle.disabled ?
Member
There was a problem hiding this comment.
Well, I could agree. But this is not skipping it, it is like "pretending is not there" (filter it out, remove it from default ones).
Yes, skipping is wrong. I noticed that after reflection.
Member
There was a problem hiding this comment.
Maybe just
maven.site.lifecycle.disabled?
maven.lifecycle.site.disabled if we talk about a properties tree.
Member
Author
There was a problem hiding this comment.
Unsure what tree you mean, but I am more to group properties by feature.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 16, 2026
…o opt out of the site lifecycle When set to true, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to maven-4.0.x.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 16, 2026
…o opt out of the site lifecycle When set to true, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to master.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 17, 2026
…o opt out of the site lifecycle When set to true, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to master.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 17, 2026
…o opt out of the site lifecycle When set to true, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to master.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 19, 2026
…o opt out of the site lifecycle When set to true, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to master.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 19, 2026
…o opt out of the site lifecycle When -Dmaven.site.lifecycle.disabled=true is set, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to maven-4.0.x. Fixes apache#11759
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 19, 2026
…o opt out of the site lifecycle When set to true, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to master.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 19, 2026
…o opt out of the site lifecycle When -Dmaven.site.lifecycle.disabled=true is set, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to maven-4.0.x. Fixes apache#11759
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 19, 2026
…o opt out of the site lifecycle When set to true, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of apache#11970 (merged on maven-3.10.x) to master.
gnodet
added a commit
that referenced
this pull request
Oct 20, 2026
…out of the site lifecycle (#13546) When set to true, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of #11970 (merged on maven-3.10.x) to master.
gnodet
added a commit
that referenced
this pull request
Oct 20, 2026
… to opt out of the site lifecycle (#13547) * Fix #11759: add maven.site.lifecycle.disabled system property to opt out of the site lifecycle When -Dmaven.site.lifecycle.disabled=true is set, the site lifecycle is excluded from the DefaultLifecycleRegistry stream, so Maven will not resolve or bind the maven-site-plugin unless it is explicitly configured in the POM. This is an opt-in system property (-Dmaven.site.lifecycle.disabled=true) that preserves full backward compatibility. Port of #11970 (merged on maven-3.10.x) to maven-4.0.x. Fixes #11759 * fix: adapt IT to maven-4.0.x AbstractMavenIntegrationTestCase API The test was using the master-branch API (Path-returning extractResources(), no-arg constructor, Path-taking newVerifier()) which does not exist on the maven-4.0.x branch. Adapt to use: - File extractResources(String) (as in 4.0.x base class) - Constructor super("[4.0.0-rc-3,)") (required by 4.0.x base class) - newVerifier(String) instead of newVerifier(Path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to suppress site lifecycle from Maven "default lifecycles". This PR does not remove "site" lifecycle component, but Maven will not consider site lifecycle among "defaults", if disabled.
Note: hence, with this option enabled, the IT suite will never (and cannot) pass, as IT suite contains ITs running/expecting site lifecycle.
Fixes #11759