Skip to content

Update Maven deps diagram for maven-jline - #12068

Merged
gnodet merged 1 commit into
apache:maven-3.10.xfrom
Will-thom:codex/update-maven-deps-diagram-3.10
May 19, 2026
Merged

gnodet merged 1 commit into
apache:maven-3.10.xfrom
Will-thom:codex/update-maven-deps-diagram-3.10

Conversation

@Will-thom

Copy link
Copy Markdown
Contributor

Thanks for the clarification.

I retargeted the change to maven-3.10.x and updated the diagram to reflect the current structure:

  • removed maven-shared-utils from the diagram
  • added the maven-jline module
  • represented JLine as the external dependency used through maven-jline
  • updated the .odg source and synchronized maven-deps.svg

Please let me know if this matches the expected layout.

@olamy

olamy commented May 18, 2026

Copy link
Copy Markdown
Member

we should probably stop pushing binaries files.
with the coming support of mermaid of mermaid this could help?

@slawekjaranowski slawekjaranowski linked an issue May 18, 2026 that may be closed by this pull request
@slawekjaranowski

slawekjaranowski commented May 18, 2026 •

Copy link
Copy Markdown
Member

It is difficult to verify content of binary file ....

@gnodet

gnodet commented May 19, 2026

Copy link
Copy Markdown
Contributor

we should probably stop pushing binaries files. with the coming support of mermaid of mermaid this could help?

The one for Maven 4 is auto-generated.

@olamy

olamy commented May 19, 2026

Copy link
Copy Markdown
Member

we should probably stop pushing binaries files. with the coming support of mermaid of mermaid this could help?

The one for Maven 4 is auto-generated.

the .odg?

I would even if generated we could avoid store binary files. and .svg or mermaid are rendering well

@gnodet

gnodet commented May 19, 2026

Copy link
Copy Markdown
Contributor

I extracted and inspected the ODG file (it's a ZIP of XML files). It looks clean:

  • no embedded scripts or macros (the <office:scripts> element is empty)
  • all hyperlinks point to expected project sites (apache.org, eclipse.org, github.com, jline.org, slf4j.org) and relative file:///maven-* module references
  • text labels match the expected Maven module names, including the new maven-jline and jline
  • no embedded binaries besides the standard Thumbnails/thumbnail.png preview

That said, Maven 4 already generates this diagram at build time, so the binary source issue is solved there. And since the Maven 3 dependency structure is unlikely to change often at this point, it's probably not worth converting to a different format just for this branch.

Claude Code on behalf of Guillaume Nodet

@gnodet

gnodet commented May 19, 2026 •

Copy link
Copy Markdown
Contributor

we should probably stop pushing binaries files. with the coming support of mermaid of mermaid this could help?

The one for Maven 4 is auto-generated.

the .odg?

I would even if generated we could avoid store binary files. and .svg or mermaid are rendering well

The diagram is generated at build time in Maven 4, so there's no ODG anymore.

@gnodet
gnodet merged commit ad0cb70 into apache:maven-3.10.x May 19, 2026
18 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@gnodet Please assign appropriate label to PR according to the type of change.

@github-actions github-actions Bot added this to the 3.10.0 milestone May 19, 2026
@Will-thom

Copy link
Copy Markdown
Contributor Author

we should probably stop pushing binaries files. with the coming support of mermaid of mermaid this could help?

The one for Maven 4 is auto-generated.

the .odg?
I would even if generated we could avoid store binary files. and .svg or mermaid are rendering well

The diagram is generated at build time in Maven 4, so there's no ODG anymore.

Hi guys, I´m thinking...

...rather than discussing whether ODG, SVG or Mermaid should be stored, perhaps the more important question is what should be the canonical source of the dependency graph. If the graph can be derived from the Maven reactor structure, a textual source (Mermaid/DOT) or fully generated artifact would avoid drift, simplify reviews and eliminate binary artifacts entirely.

@gnodet

gnodet commented May 19, 2026

Copy link
Copy Markdown
Contributor

we should probably stop pushing binaries files. with the coming support of mermaid of mermaid this could help?

The one for Maven 4 is auto-generated.

the .odg?
I would even if generated we could avoid store binary files. and .svg or mermaid are rendering well

The diagram is generated at build time in Maven 4, so there's no ODG anymore.

Hi guys, I´m thinking...

...rather than discussing whether ODG, SVG or Mermaid should be stored, perhaps the more important question is what should be the canonical source of the dependency graph. If the graph can be derived from the Maven reactor structure, a textual source (Mermaid/DOT) or fully generated artifact would avoid drift, simplify reviews and eliminate binary artifacts entirely.

Yes, that's what is done in Maven 4, maybe I wasn't clear enough.
See https://github.com/apache/maven/blob/master/src/graph/ReactorGraph.java and https://github.com/apache/maven/blob/master/pom.xml#L970-L992

@slawekjaranowski slawekjaranowski added the documentation Improvements or additions to documentation label May 19, 2026
@slawekjaranowski slawekjaranowski linked an issue May 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update maven-deps.svg, maven-deps.odg

4 participants