Repository navigation
Update Maven deps diagram for maven-jline - #12068
Conversation
|
we should probably stop pushing binaries files. |
|
It is difficult to verify content of binary file .... |
The one for Maven 4 is auto-generated. |
the I would even if generated we could avoid store binary files. and |
|
I extracted and inspected the ODG file (it's a ZIP of XML files). It looks clean:
That said, Maven 4 already generates this diagram at build time, so the binary source issue is solved there. And since the Maven 3 dependency structure is unlikely to change often at this point, it's probably not worth converting to a different format just for this branch. Claude Code on behalf of Guillaume Nodet |
The diagram is generated at build time in Maven 4, so there's no ODG anymore. |
|
@gnodet Please assign appropriate label to PR according to the type of change. |
Hi guys, I´m thinking... ...rather than discussing whether ODG, SVG or Mermaid should be stored, perhaps the more important question is what should be the canonical source of the dependency graph. If the graph can be derived from the Maven reactor structure, a textual source (Mermaid/DOT) or fully generated artifact would avoid drift, simplify reviews and eliminate binary artifacts entirely. |
Yes, that's what is done in Maven 4, maybe I wasn't clear enough. |
Thanks for the clarification.
I retargeted the change to maven-3.10.x and updated the diagram to reflect the current structure:
Please let me know if this matches the expected layout.