Repository navigation
[GH-2031] Geopandas.GeoSeries: Implement isna, notna and aliases (isnull, notnull) - #2032
Merged
Merged
Conversation
petern48
marked this pull request as ready for review
July 3, 2025 22:27
Member
|
Please merge the master and rerun the tests. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements missing-value detection methods (isna, notna and their aliases isnull, notnull) for GeoSeries and adds parameterized unit tests to validate their behavior.
- Implemented
isna,isnull,notna, andnotnullinsedona.geopandas.geoseries.GeoSeries, replacing stubs. - Added
pytest.mark.parametrizetests for these methods in both matching and core GeoSeries test files. - Introduced
import pytestin test modules for decorator support.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/tests/geopandas/test_match_geopandas_series.py | Replaced stub tests with parameterized isna/isnull and notna/notnull tests; missing import pytest at the top. |
| python/tests/geopandas/test_geoseries.py | Added pytest.mark.parametrize tests for isna/isnull and notna/notnull; inserted import pytest. |
| python/sedona/geopandas/geoseries.py | Implemented the four NA detection methods; notna lacks a boolean cast; duplicate stub definitions of these methods remain. |
Comments suppressed due to low confidence (3)
python/tests/geopandas/test_match_geopandas_series.py:1
- The file uses
@pytest.mark.parametrizebut does not importpytest; addimport pytestat the top to enable decorator support.
# Licensed to the Apache Software Foundation (ASF) under one
python/tests/geopandas/test_match_geopandas_series.py:303
- The second part of
test_notnaonly exercisesnotnaand not thenotnullalias; consider parametrizing or adding an explicit check forfun='notnull'in this block.
data = [Point(0, 0), None]
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jiayuasu
reviewed
Jul 6, 2025
jiayuasu
approved these changes
Jul 6, 2025
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Jan 21, 2026
…s (isnull, notnull) (apache#2032) * Refactor process_geometry_column to create a more flexible query_geometry_column() * Implement length() * Implement isna and isnull * Implement notna * Fix doc strings to use sedona instead of geoseries * Update python/sedona/geopandas/geoseries.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update python/sedona/geopandas/geoseries.py --------- Co-authored-by: Jia Yu <jiayu@wherobots.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes Geopandas.GeoSeries: Implement isna, notna and aliases (isnull, notnull) #2031What changes were proposed in this PR?
Implement isna, notna and aliases (isnull, notnull)
How was this patch tested?
Added tests
Did this PR include necessary documentation updates?