Repository navigation
[GH-2166] More pathing fixes for Python package refactor - #2167
Merged
Merged
Conversation
jiayuasu
reviewed
Jul 26, 2025
jiayuasu
reviewed
Jul 26, 2025
jiayuasu
reviewed
Jul 26, 2025
mostly these are just adding "redirects" to the new location. the geoarrow I moved out of the util folder. unless we had never released this at the time, this seemed to just be a mistake that failed to maintain backwards compatability. I skipped some things because I thought maybe theyre not supported APIS: * everything in core * sedona.register outside of what is available from the init file I'm sure I missed some things here but hopefull this makes things a lot better for existing users of sedona.
james-willis
force-pushed
the
more-pathing-fixes
branch
from
July 28, 2025 19:00
16351b9 to
4e170ea
Compare
jiayuasu
reviewed
Jul 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses path compatibility issues following breaking changes from PR #1930 by reorganizing module imports and providing backward compatibility through wrapper modules and deprecation warnings.
Key changes include:
- Addition of backward compatibility wrapper modules for
sedona.utils,sedona.maps, andsedona.rasterpackages - Implementation of direct imports from
sedona.sqlto maintain API compatibility - Expansion of test coverage to verify all new import paths work correctly
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
python/tests/test_path_compatibility_all.py |
Adds comprehensive test cases for all new import paths including raster, maps, utils, and geoarrow modules |
python/tests/test_path_compatibility.py |
Expands existing compatibility tests and adds imports for all deprecated modules being tested |
python/sedona/utils/__init__.py |
Creates backward compatibility wrapper for utils package with deprecation warning |
python/sedona/sql/__init__.py |
Enables direct imports from sedona.sql by re-exporting all spark.sql symbols |
python/sedona/register/__init__.py |
Updates register module to import SedonaRegistrator with updated deprecation message |
python/sedona/raster_utils/ |
Creates new raster_utils compatibility module structure |
python/sedona/raster/ |
Creates complete raster compatibility module structure with individual wrapper files |
python/sedona/maps/ |
Creates maps compatibility module structure with wrapper files for SedonaKepler and SedonaPyDeck |
python/sedona/geoarrow/__init__.py |
Updates geoarrow module to use proper all exports from spark.geoarrow |
Comments suppressed due to low confidence (2)
python/tests/test_path_compatibility_all.py:96
- This test method is duplicated - there's already a test_geoarrow_import method at line 87. Consider consolidating these tests or renaming them to reflect different aspects being tested.
def test_geoarrow_imports(self):
python/tests/test_path_compatibility.py:144
- This test method is duplicated - there's already a test_geoarrow_import method at line 128. Consider consolidating these tests or renaming them to reflect different aspects being tested.
def test_geoarrow_imports(self):
Kontinuation
added a commit
to Kontinuation/sedona
that referenced
this pull request
Jan 21, 2026
…e#2167) (apache#468) cherry pick from sedona Co-authored-by: Kristin Cowalcijk <bo@wherobots.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes Fix Breaking Changes from #1930 #2166What changes were proposed in this PR?
I'm fixing the breaking changes from #1930
How was this patch tested?
unit tests
Did this PR include necessary documentation updates?