Skip to content

Revert "Improved lib detection: check for matching name in library.properties (#1276)" - #1290

Merged
silvanocerza merged 1 commit into
masterfrom
scerza/revert-library-resolution-fix
May 14, 2021
Merged

silvanocerza merged 1 commit into
masterfrom
scerza/revert-library-resolution-fix

Conversation

@silvanocerza

@silvanocerza silvanocerza commented May 14, 2021 •

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Reverts a fix that is causing unforeseen consequences.

  • What is the current behavior?

Sketch compilation is broken for ESP32 boards when using a library that is installed both in the Sketchbook folder and the core folder.

The reverted commit changed the way libraries are resolved so that the name set in the library.properties is checked to understand which library to included; the libraries included in the ESP32 core have a different name in library.properties because of legacy reasons from the Java IDE.

Compiling a Sketch that includes OneWire.h with both OneWire and OneWireng libraries installed compiles correctly.

  • What is the new behavior?

Sketch compilation is not broken anymore for ESP32 boards when using a library that is installed both in the Sketchbook folder and the core folder.

Compiling a Sketch that includes OneWire.h with both OneWire and OneWireng libraries installed doesn't compile anymore.

No.

  • Other information:

This reverts commit 15e81eddb96abfe99fe094db9a433965ea3c7ad7 from PR #1276.


See how to contribute

@silvanocerza
silvanocerza requested a review from cmaglie May 14, 2021 10:59
@silvanocerza silvanocerza self-assigned this May 14, 2021
@d-a-v

d-a-v commented May 14, 2021

Copy link
Copy Markdown
Contributor

FWIW, I could see the same issue with esp8266 (current master) and SD library. The wrong one was selected.

@silvanocerza

Copy link
Copy Markdown
Contributor Author

FWIW, I could see the same issue with esp8266 (current master) and SD library. The wrong one was selected.

Yes, I confirm.

@silvanocerza
silvanocerza merged commit 382ebf1 into master May 14, 2021
@silvanocerza
silvanocerza deleted the scerza/revert-library-resolution-fix branch May 14, 2021 12:35
silvanocerza added a commit that referenced this pull request May 14, 2021
cmaglie added a commit to arduino/arduino-builder that referenced this pull request May 14, 2021
@silvanocerza

Copy link
Copy Markdown
Contributor Author

Release containing this fix is out. 🎉

https://github.com/arduino/arduino-cli/releases/tag/0.18.3

@per1234

per1234 commented May 14, 2021

Copy link
Copy Markdown
Contributor

For details, see: #1292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants