Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Move IRazorViewEngineFileProviderAccessor and ExpressionRewriter to the public namespace #4938

Closed

Description

@DavidEmanuelsen

An application we're building has ended up needing to implement a modified version of DefaultRoslynCompilationService to avoid caching of the list of compilation references. In the modified version we still depend (as far as I can see) on IRazorViewEngineFileProviderAccessor and ExpressionRewriter which are both in the .Internal-namespace.

Is there any chance this can be moved to the public namespace to minimize risks of breaking changes in the future?

See #4497 for history

Activity

  1. Eilon commented on Dec 20, 2016

    @Eilon
    Contributor

    @NTaylorMullen @pranavkm @rynowak thoughts on this? Would it make sense to move these types to a public namespace?

  2. davidfowl commented on Dec 21, 2016

    @davidfowl
    Member

    No, if you ended up rewriting the default service then we have a gap somewhere in our extensibility.

  3. rynowak commented on Dec 21, 2016

    @rynowak
    Contributor

    @davidfowl - we did identify a gap here... remember when we designed compilation factory and reference manager?

    We should make an abstraction for https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Razor/Internal/RazorReferenceManager.cs and make it public, that's the part you're asking for right @DavidEmanuelsen ?

  4. added this to the 2.0.0-preview2 milestone on May 13, 2017
  5. Eilon commented on May 13, 2017

    @Eilon
    Contributor

    @rynowak I'm parking this on your plate. If you think we can get this in, let's do it, but if not, I think we should close it.

  6. rynowak commented on May 26, 2017

    @rynowak
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions