You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Move IRazorViewEngineFileProviderAccessor and ExpressionRewriter to the public namespace #4938
An application we're building has ended up needing to implement a modified version of DefaultRoslynCompilationService to avoid caching of the list of compilation references. In the modified version we still depend (as far as I can see) on IRazorViewEngineFileProviderAccessor and ExpressionRewriter which are both in the .Internal-namespace.
Is there any chance this can be moved to the public namespace to minimize risks of breaking changes in the future?
Activity
Eilon commentedon Dec 20, 2016
@NTaylorMullen @pranavkm @rynowak thoughts on this? Would it make sense to move these types to a public namespace?
davidfowl commentedon Dec 21, 2016
No, if you ended up rewriting the default service then we have a gap somewhere in our extensibility.
rynowak commentedon Dec 21, 2016
@davidfowl - we did identify a gap here... remember when we designed compilation factory and reference manager?
We should make an abstraction for https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Razor/Internal/RazorReferenceManager.cs and make it public, that's the part you're asking for right @DavidEmanuelsen ?
Eilon commentedon May 13, 2017
@rynowak I'm parking this on your plate. If you think we can get this in, let's do it, but if not, I think we should close it.
Make RazorReferenceManage public
Make RazorReferenceManage public
rynowak commentedon May 26, 2017
c3f7613