Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Exceptions thrown from Views when run from a net461 application do not contain line numbers or file info #6356

Closed

Description

@NTaylorMullen

The reason why this occurs is because our CSharpCompiler.EmitOptions unconditionally sets the debugInformationFormat to the pdb format (can't be understood by .net framework). We should consider auto-detecting the current framework and set the PDB format accordingly.

Note that this blocks the RuntimeErrorAreListedByErrorPageMiddleware test from passing on net461.

This issue can be closed as a duplicate of dotnet/extensions#235 if we complete that one first. Leaving this issue here in-case we decide to go for a non-portable-pdb approach; the sdk will be moving to non-portable pdbs for desktop applications anyways so this may be more consistent with the rest of the system.

Activity

  1. NTaylorMullen commented on Jun 2, 2017

    @NTaylorMullen
    Author

    /cc @anurse @DamianEdwards FYI if you don't see line numbers in your views when app building net461.

  2. analogrelay commented on Jun 5, 2017

    @analogrelay
    Contributor

    I had actually noticed this, thanks for the heads-up :)

  3. added this to the 2.0.0 milestone on Jun 6, 2017
  4. pranavkm commented on Jun 26, 2017

    @pranavkm
    Contributor

    Fixed in e5da44a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions