You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Port fix to 2.0.1: Zero Content-Length for static file 304 #6875 #6887
We are looking for feedback on this patch. We'd like to know if you have any issues with this patch by updating your apps and libraries to the latest packages and seeing if it fixes the issues you've had, or if it introduces any new issues. If you have any issues or questions, please reply on this issue to let us know as soon as possible.
I just tried the new 2.0.3-* version. The content-length issue does indeed seem to be fixed.
The Microsoft.AspNetCore.All package included all of the packages in the published output. As I remember, it should only have included the ones that were actually used. Is this a side-effect of the pre release package system itself?
@shravan2x actually when publishing an app, by default none of the packages references by Microsoft.AspNetCore.All should be in the published output. Only a few ASP.NET/EF Core-related packages might be there, and of course various 3rd party packages might be there.
Can you show what command you ran and what's in the publish output folder?
@Eilon I've seen that in ASP.NET Core 2.0 this is indeed the case. The number of packages is far lower than 1.0. However, when I ran the new 2.0.3-* package, I remember seeing all packages, just as in 1.x. I used the default "Publish to Folder" option in VS2017 (the latest version, 15.4 I think).
Maybe I did something incorrectly; I will test again in the next few days and report back with more info.
@shravan2x if you publish the app as a self-contained (also known as "standalone") app, it will contain all of ASP.NET Core and even all of .NET Core. I believe there's an option in the publish dialog to enable this, but it isn't the default setting.
If you can show what files are in the output folder that would help figure this out.
Activity
Port fix for #6875: Only set Content-Length when serving body (#6888)
Eilon commentedon Oct 23, 2017
Hi, we have a public test feed that you can use to try out the ASP.NET/EF Core 2.0.3 patch!
To try out the pre-release patch, please refer to the following guide:
We are looking for feedback on this patch. We'd like to know if you have any issues with this patch by updating your apps and libraries to the latest packages and seeing if it fixes the issues you've had, or if it introduces any new issues. If you have any issues or questions, please reply on this issue to let us know as soon as possible.
Thanks,
Eilon
shravan2x commentedon Oct 28, 2017
I just tried the new
2.0.3-*version. The content-length issue does indeed seem to be fixed.The
Microsoft.AspNetCore.Allpackage included all of the packages in the published output. As I remember, it should only have included the ones that were actually used. Is this a side-effect of the pre release package system itself?Eilon commentedon Oct 30, 2017
@shravan2x actually when publishing an app, by default none of the packages references by
Microsoft.AspNetCore.Allshould be in the published output. Only a few ASP.NET/EF Core-related packages might be there, and of course various 3rd party packages might be there.Can you show what command you ran and what's in the publish output folder?
shravan2x commentedon Oct 30, 2017
@Eilon I've seen that in ASP.NET Core 2.0 this is indeed the case. The number of packages is far lower than 1.0. However, when I ran the new
2.0.3-*package, I remember seeing all packages, just as in1.x. I used the default "Publish to Folder" option in VS2017 (the latest version, 15.4 I think).Maybe I did something incorrectly; I will test again in the next few days and report back with more info.
Eilon commentedon Oct 30, 2017
@shravan2x if you publish the app as a self-contained (also known as "standalone") app, it will contain all of ASP.NET Core and even all of .NET Core. I believe there's an option in the publish dialog to enable this, but it isn't the default setting.
If you can show what files are in the output folder that would help figure this out.
shravan2x commentedon Nov 3, 2017
Sorry I haven't found time to check yet. I will definitely do it this weekend.
shravan2x commentedon Nov 6, 2017
@Eilon I just tried publishing on
2.0.3-0again, it worked as expected. I was likely mistaken earlier.Looking forward to seeing this in release!
Eilon commentedon Nov 6, 2017
@shravan2x thanks for confirming!