This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Repository navigation
Check for empty location in ViewsFeatureProvider - #5685
Merged
Merged
Conversation
Contributor
Author
|
cc @Eilon |
Contributor
|
Your code seems pretty straightforward, but I'm wondering under what conditions Assembly.Location would be empty? |
Contributor
|
Looks like you're test's failing though. |
pranavkm
force-pushed
the
prkrishn/5675
branch
from
January 13, 2017 22:30
1efc7b5 to
884daee
Compare
pranavkm
force-pushed
the
prkrishn/5675
branch
from
January 13, 2017 22:31
884daee to
4d969ea
Compare
Contributor
Author
|
🆙 📅 According to the bug, the location is null when an assembly is loaded from a stream. |
Eilon
approved these changes
Jan 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5675