Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Check for empty location in ViewsFeatureProvider - #5685

Merged
pranavkm merged 1 commit into
devfrom
prkrishn/5675
Jan 17, 2017
Merged

pranavkm merged 1 commit into
devfrom
prkrishn/5675

Conversation

@pranavkm

Copy link
Copy Markdown
Contributor

Fixes #5675

@pranavkm

Copy link
Copy Markdown
Contributor Author

cc @Eilon

@ryanbrandenburg

Copy link
Copy Markdown
Contributor

Your code seems pretty straightforward, but I'm wondering under what conditions Assembly.Location would be empty?

@ryanbrandenburg

Copy link
Copy Markdown
Contributor

Looks like you're test's failing though.

@pranavkm

Copy link
Copy Markdown
Contributor Author

🆙 📅 According to the bug, the location is null when an assembly is loaded from a stream.

@pranavkm
pranavkm merged commit e749a80 into dev Jan 17, 2017
@pranavkm
pranavkm deleted the prkrishn/5675 branch January 17, 2017 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants