Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Move classes out of .Internal - #5687

Merged
ryanbrandenburg merged 1 commit into
devfrom
rybrande/AttributesOutOfInternal
Jan 19, 2017
Merged

ryanbrandenburg merged 1 commit into
devfrom
rybrande/AttributesOutOfInternal

Conversation

@ryanbrandenburg

Copy link
Copy Markdown
Contributor

Fixes #5652.

@ryanbrandenburg

Copy link
Copy Markdown
Contributor Author

@dougbu I've moved the classes that the bug calls for, but I wonder if some of the other classes in this area don't need the same treatment (ValidationAttributeAdapterOfTAttribute for example). Do you think any of the others warrent moving too or should we leave it at those two?

@dougbu

dougbu commented Jan 17, 2017

Copy link
Copy Markdown
Contributor

Do you think any of the others warrant moving too or should we leave it at those two?

If ValidationAttributeAdapter<TAttribute> were internal for realz, the compiler would complain if you tried to make AttributeAdapterBase<TAttribute> public. So, yes, that class should also move.

What else were you thinking about?

@dougbu dougbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move ``ValidationAttributeAdapter` too.

Also please confirm remaining usings in the files you're changing are all needed.

@ryanbrandenburg
ryanbrandenburg force-pushed the rybrande/AttributesOutOfInternal branch from 6eaec3a to 53e2e61 Compare January 17, 2017 22:59
@ryanbrandenburg

Copy link
Copy Markdown
Contributor Author

Moved other class and double checked using's, 🆙📅

@dougbu dougbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: after you've done a reaction PR for the Entropy sample(s) using at least one of these classes.

@ryanbrandenburg
ryanbrandenburg force-pushed the rybrande/AttributesOutOfInternal branch from 53e2e61 to 305748a Compare January 19, 2017 19:11
@ryanbrandenburg
ryanbrandenburg merged commit 305748a into dev Jan 19, 2017
@ryanbrandenburg
ryanbrandenburg deleted the rybrande/AttributesOutOfInternal branch February 15, 2017 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants