Skip to content

fix: preserve cache error class names in save-cache bundle - #1093

Merged
eifinger merged 1 commit into
astral-sh:mainfrom
dannyward630:codex/issue-1028-reserve-cache-error-names
Oct 15, 2026
Merged

eifinger merged 1 commit into
astral-sh:mainfrom
dannyward630:codex/issue-1028-reserve-cache-error-names

Conversation

@dannyward630

Copy link
Copy Markdown
Contributor

Summary

  • Preserve class names in the save-cache bundle so @actions/cache error-name comparisons distinguish validation errors, benign cache-reservation races, and finalization errors correctly.
  • Add regression coverage that exercises the bundled ValidationError, ReserveCacheError, and FinalizeCacheError constructors.

Fixes #1028

Verification

  • npm run all passed on Ubuntu 24.04 with Node 24.19.0: build, Biome, packaging, and all 159 tests across 15 suites.
  • git diff --check passed.

The save-cache bundle increases by about 77 KB raw (14 KB gzip) to preserve the required names.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T01:46:41.936663Z 26ec083 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@eifinger

Copy link
Copy Markdown
Collaborator

This will approximately add 5-8ms of startup time.
I think this is a valid workaround until this is fixed in actions/toolkit#2421 or somewhere else

@eifinger
eifinger merged commit c97f06e into astral-sh:main Oct 15, 2026
91 checks passed
@eifinger

Copy link
Copy Markdown
Collaborator

Thank you @dannyward630

Doridian pushed a commit to FoxDenHome/core that referenced this pull request Oct 22, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [https://github.com/astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | patch | `v10.3.0` → `v10.3.1` |

---

### Release Notes

<details>
<summary>astral-sh/setup-uv (https://github.com/astral-sh/setup-uv)</summary>

### [`v10.3.1`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.1): 🌈 preserve cache error class names in save-cache bundle

[Compare Source](astral-sh/setup-uv@v10.3.0...v10.3.1)

#### Changes

This release includes a fix so that multiple concurrent workflows trying to upload the same cache no longer warn

`##[warning]Failed to save: Unable to reserve cache with key ..., another job may be creating this cache.`

#### 🐛 Bug fixes

- fix: preserve cache error class names in save-cache bundle [@&#8203;dannyward630](https://github.com/dannyward630) ([#&#8203;1093](astral-sh/setup-uv#1093))

#### 🧰 Maintenance

- chore: update known checksums for 0.13.4 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1099](astral-sh/setup-uv#1099))
- chore: update known checksums for 0.13.2/0.13.3 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1098](astral-sh/setup-uv#1098))
- chore: update known checksums for 0.13.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1094](astral-sh/setup-uv#1094))
- Verify npm dependency signatures before builds [@&#8203;zaniebot](https://github.com/zaniebot) ([#&#8203;1027](astral-sh/setup-uv#1027))

#### 📚 Documentation

- docs: cache-dependency-glob matches relative to the working directory [@&#8203;flange-ipb](https://github.com/flange-ipb) ([#&#8203;1092](astral-sh/setup-uv#1092))
- docs: update version references to v10.3.0 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1090](astral-sh/setup-uv#1090))

#### ⬆️ Dependency updates

- chore(deps): roll up Dependabot updates [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;1101](astral-sh/setup-uv#1101))

</details>

---

### Configuration

📅 **Schedule**: (in timezone America/Los_Angeles)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNzUuNSIsInVwZGF0ZWRJblZlciI6IjQ0LjE3NS41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.foxden.network/FoxDen/core/pulls/233
luketainton pushed a commit to luketainton/luke_rsu that referenced this pull request Oct 22, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | patch | `v10.3.0` → `v10.3.2` |

---

### Release Notes

<details>
<summary>astral-sh/setup-uv</summary>

### [`v10.3.2`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.2): 🌈 update known checksums for 0.13.5

[Compare Source](astral-sh/setup-uv@v10.3.1...v10.3.2)

#### Changes

#### 🧰 Maintenance

- chore: update known checksums for 0.13.5 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1103](astral-sh/setup-uv#1103))

#### 📚 Documentation

- docs: update version references to v10.3.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1102](astral-sh/setup-uv#1102))

### [`v10.3.1`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.1): 🌈 preserve cache error class names in save-cache bundle

[Compare Source](astral-sh/setup-uv@v10.3.0...v10.3.1)

#### Changes

This release includes a fix so that multiple concurrent workflows trying to upload the same cache no longer warn

`##[warning]Failed to save: Unable to reserve cache with key ..., another job may be creating this cache.`

#### 🐛 Bug fixes

- fix: preserve cache error class names in save-cache bundle [@&#8203;dannyward630](https://github.com/dannyward630) ([#&#8203;1093](astral-sh/setup-uv#1093))

#### 🧰 Maintenance

- chore: update known checksums for 0.13.4 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1099](astral-sh/setup-uv#1099))
- chore: update known checksums for 0.13.2/0.13.3 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1098](astral-sh/setup-uv#1098))
- chore: update known checksums for 0.13.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1094](astral-sh/setup-uv#1094))
- Verify npm dependency signatures before builds [@&#8203;zaniebot](https://github.com/zaniebot) ([#&#8203;1027](astral-sh/setup-uv#1027))

#### 📚 Documentation

- docs: cache-dependency-glob matches relative to the working directory [@&#8203;flange-ipb](https://github.com/flange-ipb) ([#&#8203;1092](astral-sh/setup-uv#1092))
- docs: update version references to v10.3.0 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1090](astral-sh/setup-uv#1090))

#### ⬆️ Dependency updates

- chore(deps): roll up Dependabot updates [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;1101](astral-sh/setup-uv#1101))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNjAuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjE2MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/rsu/pulls/60
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton pushed a commit to luketainton/repos_labmcp that referenced this pull request Oct 24, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | patch | `v10.3.0` → `v10.3.2` |

---

### Release Notes

<details>
<summary>astral-sh/setup-uv</summary>

### [`v10.3.2`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.2): 🌈 update known checksums for 0.13.5

[Compare Source](astral-sh/setup-uv@v10.3.1...v10.3.2)

#### Changes

#### 🧰 Maintenance

- chore: update known checksums for 0.13.5 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1103](astral-sh/setup-uv#1103))

#### 📚 Documentation

- docs: update version references to v10.3.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1102](astral-sh/setup-uv#1102))

### [`v10.3.1`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.1): 🌈 preserve cache error class names in save-cache bundle

[Compare Source](astral-sh/setup-uv@v10.3.0...v10.3.1)

#### Changes

This release includes a fix so that multiple concurrent workflows trying to upload the same cache no longer warn

`##[warning]Failed to save: Unable to reserve cache with key ..., another job may be creating this cache.`

#### 🐛 Bug fixes

- fix: preserve cache error class names in save-cache bundle [@&#8203;dannyward630](https://github.com/dannyward630) ([#&#8203;1093](astral-sh/setup-uv#1093))

#### 🧰 Maintenance

- chore: update known checksums for 0.13.4 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1099](astral-sh/setup-uv#1099))
- chore: update known checksums for 0.13.2/0.13.3 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1098](astral-sh/setup-uv#1098))
- chore: update known checksums for 0.13.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1094](astral-sh/setup-uv#1094))
- Verify npm dependency signatures before builds [@&#8203;zaniebot](https://github.com/zaniebot) ([#&#8203;1027](astral-sh/setup-uv#1027))

#### 📚 Documentation

- docs: cache-dependency-glob matches relative to the working directory [@&#8203;flange-ipb](https://github.com/flange-ipb) ([#&#8203;1092](astral-sh/setup-uv#1092))
- docs: update version references to v10.3.0 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1090](astral-sh/setup-uv#1090))

#### ⬆️ Dependency updates

- chore(deps): roll up Dependabot updates [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;1101](astral-sh/setup-uv#1101))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNjAuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjE2MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/labmcp/pulls/80
Reviewed-by: Luke Tainton <luke@tainton.uk>
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
fbidu added a commit to fbidu/cookie-py that referenced this pull request Oct 26, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) |  | patch | `v10.3.0` → `v10.3.2` |
| [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | patch | `v10.3.0` → `v10.3.2` |

---

### Release Notes

<details>
<summary>astral-sh/setup-uv</summary>

### [`v10.3.2`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.2): 🌈 update known checksums for 0.13.5

[Compare Source](astral-sh/setup-uv@v10.3.1...v10.3.2)

##### Changes

##### 🧰 Maintenance

- chore: update known checksums for 0.13.5 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1103](astral-sh/setup-uv#1103))

##### 📚 Documentation

- docs: update version references to v10.3.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1102](astral-sh/setup-uv#1102))

### [`v10.3.1`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.1): 🌈 preserve cache error class names in save-cache bundle

[Compare Source](astral-sh/setup-uv@v10.3.0...v10.3.1)

##### Changes

This release includes a fix so that multiple concurrent workflows trying to upload the same cache no longer warn

`##[warning]Failed to save: Unable to reserve cache with key ..., another job may be creating this cache.`

##### 🐛 Bug fixes

- fix: preserve cache error class names in save-cache bundle [@&#8203;dannyward630](https://github.com/dannyward630) ([#&#8203;1093](astral-sh/setup-uv#1093))

##### 🧰 Maintenance

- chore: update known checksums for 0.13.4 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1099](astral-sh/setup-uv#1099))
- chore: update known checksums for 0.13.2/0.13.3 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1098](astral-sh/setup-uv#1098))
- chore: update known checksums for 0.13.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1094](astral-sh/setup-uv#1094))
- Verify npm dependency signatures before builds [@&#8203;zaniebot](https://github.com/zaniebot) ([#&#8203;1027](astral-sh/setup-uv#1027))

##### 📚 Documentation

- docs: cache-dependency-glob matches relative to the working directory [@&#8203;flange-ipb](https://github.com/flange-ipb) ([#&#8203;1092](astral-sh/setup-uv#1092))
- docs: update version references to v10.3.0 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1090](astral-sh/setup-uv#1090))

##### ⬆️ Dependency updates

- chore(deps): roll up Dependabot updates [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;1101](astral-sh/setup-uv#1101))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xODEuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjE4MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJ0ZW1wbGF0ZSJdfQ==-->

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) |  | patch | `v10.3.0` → `v10.3.2` |
| [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | patch | `v10.3.0` → `v10.3.2` |

---

### Release Notes

<details>
<summary>astral-sh/setup-uv</summary>

### [`v10.3.2`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.2): 🌈 update known checksums for 0.13.5

[Compare Source](astral-sh/setup-uv@v10.3.1...v10.3.2)

##### Changes

##### 🧰 Maintenance

- chore: update known checksums for 0.13.5 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1103](astral-sh/setup-uv#1103))

##### 📚 Documentation

- docs: update version references to v10.3.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1102](astral-sh/setup-uv#1102))

### [`v10.3.1`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.1): 🌈 preserve cache error class names in save-cache bundle

[Compare Source](astral-sh/setup-uv@v10.3.0...v10.3.1)

##### Changes

This release includes a fix so that multiple concurrent workflows trying to upload the same cache no longer warn

`##[warning]Failed to save: Unable to reserve cache with key ..., another job may be creating this cache.`

##### 🐛 Bug fixes

- fix: preserve cache error class names in save-cache bundle [@&#8203;dannyward630](https://github.com/dannyward630) ([#&#8203;1093](astral-sh/setup-uv#1093))

##### 🧰 Maintenance

- chore: update known checksums for 0.13.4 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1099](astral-sh/setup-uv#1099))
- chore: update known checksums for 0.13.2/0.13.3 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1098](astral-sh/setup-uv#1098))
- chore: update known checksums for 0.13.1 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1094](astral-sh/setup-uv#1094))
- Verify npm dependency signatures before builds [@&#8203;zaniebot](https://github.com/zaniebot) ([#&#8203;1027](astral-sh/setup-uv#1027))

##### 📚 Documentation

- docs: cache-dependency-glob matches relative to the working directory [@&#8203;flange-ipb](https://github.com/flange-ipb) ([#&#8203;1092](astral-sh/setup-uv#1092))
- docs: update version references to v10.3.0 @&#8203;[github-actions\[bot\]](https://github.com/apps/github-actions) ([#&#8203;1090](astral-sh/setup-uv#1090))

##### ⬆️ Dependency updates

- chore(deps): roll up Dependabot updates [@&#8203;eifinger](https://github.com/eifinger) ([#&#8203;1101](astral-sh/setup-uv#1101))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xODEuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjE4MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJ0ZW1wbGF0ZSJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning annotation on benign concurrent cache saves: bundled ReserveCacheError class renamed, breaking the error.name check

2 participants