Repository navigation
Conversation
|
A maintainer will take a look as soon as they can. In the meantime, please make sure that:
|
🦋 Changeset detectedLatest commit: bce98b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will not alter performance
Comparing Footnotes
|
dyc3
left a comment
There was a problem hiding this comment.
Does it change this behavior universally? Because we still want to simplify it in Boolean contexts (if, while statement conditions)
…`x && true` in boolean contexts
d9ab61b to
bce98b9
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe Suggested reviewers: Priority: ➖ Normal Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The rule change preserves operand values outside boolean contexts and adds regression coverage for the intended cases. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.14` -> `2.5.15`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.14/2.5.15) | --- ### Release Notes <details> <summary>biomejs/biome (@​biomejs/biome)</summary> ### [`v2.5.15`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2515) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.14...@biomejs/biome@2.5.15) ##### Patch Changes - [#​10634](biomejs/biome#10634) [`b436ba0`](biomejs/biome@b436ba0) Thanks [@​subaru-hello](https://github.com/subaru-hello)! - Added the new nursery rule [`noReactObjectTypeAsDefaultProp`](https://biomejs.dev/linter/rules/no-react-object-type-as-default-prop/), which disallows array, object, and function values as default props in React components. For example, the following snippet triggers the rule. ```jsx function Component({ items = [] }) { return items; } ``` - [#​11956](biomejs/biome#11956) [`faa8b37`](biomejs/biome@faa8b37) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noSvelteExportLet`](https://biomejs.dev/linter/rules/no-svelte-export-let/), which disallows declaring Svelte component props with the legacy `export let` syntax. Use the `$props()` rune instead. ```svelte <script> export let name; </script> ``` - [#​10816](biomejs/biome#10816) [`1b9479e`](biomejs/biome@1b9479e) Thanks [@​Th3S4mur41](https://github.com/Th3S4mur41)! - Added a new nursery rule [`useLogicalProperties`](https://biomejs.dev/linter/rules/use-logical-properties) that enforces the use of logical properties in CSS, promoting better internationalization and accessibility practices. The rule supports a `direction` option with `"ltr"` as the default and `"rtl"` as the alternative. This is a first rule covering parts of [#​9034](biomejs/biome#9034) ```json { "linter": { "rules": { "nursery": { "useLogicalProperties": { "level": "warn", "options": { "direction": "rtl" } } } } } } ``` - [#​11960](biomejs/biome#11960) [`1fdb5c2`](biomejs/biome@1fdb5c2) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`useSvelteKitRuneImports`](https://biomejs.dev/linter/rules/use-svelte-kit-rune-imports/), which reports imports from the deprecated `$app/stores` module and suggests `$app/state` instead. ```js import { page } from "$app/stores"; ``` - [#​11723](biomejs/biome#11723) [`3b429d1`](biomejs/biome@3b429d1) Thanks [@​m1handr](https://github.com/m1handr)! - Fixed [#​11656](biomejs/biome#11656): [`noAstroSetHtmlDirective`](https://biomejs.dev/linter/rules/no-astro-set-html-directive/) now correctly reports `set:html` directives inside Astro template expressions. - [#​12023](biomejs/biome#12023) [`874d5ae`](biomejs/biome@874d5ae) Thanks [@​codspeed](https://github.com/apps/codspeed)! - Improved the performance of the HTML formatter up to 4x. - [#​11761](biomejs/biome#11761) [`a3462fe`](biomejs/biome@a3462fe) Thanks [@​saberoueslati](https://github.com/saberoueslati)! - Fixed [#​11351](biomejs/biome#11351): [`useSimplifiedLogicExpression`](https://biomejs.dev/linter/rules/use-simplified-logic-expression/) no longer reports boolean literals on the right side of `||` and `&&` outside boolean contexts, because removing them can change the result of the expression. For example, `y = x || false` is no longer reported, while `if (x || false)` still is. - [#​11732](biomejs/biome#11732) [`ff4c4dd`](biomejs/biome@ff4c4dd) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noMeaninglessVoidOperator`](https://biomejs.dev/linter/rules/no-meaningless-void-operator/), which reports unnecessary uses of `void`, such as `void log()` when `log` returns `void`. The rule allows discarded call results, thenables, `void 0`, and calls returning `never`. - [#​11975](biomejs/biome#11975) [`40dd3fb`](biomejs/biome@40dd3fb) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed the indentation of multiline Astro expressions, in templates and attribute values, when running `biome check --write`. Biome now formats Astro expressions with `biome format` too, and places them at the column of the surrounding markup. ```diff <div> {items.map((item) => ( - <span>{item}</span> -))} + <span>{item}</span> + ))} </div> ``` - [#​12016](biomejs/biome#12016) [`09d4000`](biomejs/biome@09d4000) Thanks [@​codspeed](https://github.com/apps/codspeed)! - Improved the performance of indexing and analysis of big files up to 2x. The improvements are mostly visible in projects that make use of project and types lint rules. - [#​11750](biomejs/biome#11750) [`089bde0`](biomejs/biome@089bde0) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`useStrictBooleanExpressions`](https://biomejs.dev/linter/rules/use-strict-boolean-expressions/), which reports ambiguous truthiness checks such as `if (value)` when `value` has type `number | undefined`. Non-nullable strings and numbers and nullable objects are allowed; the rule has no options. - [#​11494](biomejs/biome#11494) [`ad5b362`](biomejs/biome@ad5b362) Thanks [@​jp-knj](https://github.com/jp-knj)! - Added the nursery rule [`noAstroConflictingSetDirectives`](https://biomejs.dev/linter/rules/no-astro-conflicting-set-directives/), which reports Astro elements with multiple content sources, such as `set:html`, `set:text`, and child content. For example, `<div set:html={html}>content</div>` triggers the rule. - [#​11878](biomejs/biome#11878) [`84d1b3b`](biomejs/biome@84d1b3b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11748](biomejs/biome#11748): [`useExhaustiveSwitchCases`](https://biomejs.dev/linter/rules/use-exhaustive-switch-cases/) now reports missing cases for values created with the mapping overload of `Array.from`, including arrays imported from another module. - [#​11802](biomejs/biome#11802) [`7d1f37e`](biomejs/biome@7d1f37e) Thanks [@​dyc3](https://github.com/dyc3)! - Tailwind classes will now be detected in Svelte, Vue, and Astro class attribute expressions that don't use a class merging function. - [#​11910](biomejs/biome#11910) [`9e50ea2`](biomejs/biome@9e50ea2) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​11504](biomejs/biome#11504), a regression where Biome would silently ignore errors in the configuration file. Now errors are correctly retained and checked before executing any command. - [#​11921](biomejs/biome#11921) [`d568632`](biomejs/biome@d568632) Thanks [@​hirehamir](https://github.com/hirehamir)! - Fixed [#​10846](biomejs/biome#10846): when plugins fail to load, Biome now prints each failing plugin's path on its own line, instead of concatenating bare messages like `Cannot read file.Cannot read file.`. - [#​11930](biomejs/biome#11930) [`82ea5a6`](biomejs/biome@82ea5a6) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11927](biomejs/biome#11927): The HTML formatter no longer duplicates comments around Svelte blocks. This affected a comment after a block such as `{#if}` or `{#each}` at the end of an element, and a comment on the same line as the last element inside a block, before `{:else}`, `{/if}`, or a similar tag. - [#​11931](biomejs/biome#11931) [`0cc46d8`](biomejs/biome@0cc46d8) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed the indentation of comments at the end of a Svelte block's contents. A comment before `{:else}`, `{:then}`, `{/if}`, or a similar tag is now indented with the block's contents instead of with the tag. ```diff {#if condition} <span>Text</span> -<!-- comment --> + <!-- comment --> {/if} ``` - [#​12031](biomejs/biome#12031) [`ef0edd4`](biomejs/biome@ef0edd4) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12027](biomejs/biome#12027): Biome's test rules no longer mistake regular method calls named `test`, `it`, or `describe` for tests. For example, [`useValidTestTitle`](https://biomejs.dev/linter/rules/use-valid-test-title/) used to report the following regular expression check as a test with an invalid title: ```js const isComment = /^\s*#/.test(line); ``` - [#​11959](biomejs/biome#11959) [`8477e61`](biomejs/biome@8477e61) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11950](biomejs/biome#11950): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) now reports arrow functions with expression bodies that only reference themselves, such as `let h = () => h();`. - [#​11915](biomejs/biome#11915) [`3260602`](biomejs/biome@3260602) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​11841](biomejs/biome#11841), where suppression comments had no effect on some parts of HTML-ish files and on snippets embedded in JavaScript files. Now the following suppression works as expected: ```vue <!-- biome-ignore lint/correctness/noUndeclaredVariables: intentionally external --> <div :title="missingValue"></div> ``` - [#​11952](biomejs/biome#11952) [`b51040e`](biomejs/biome@b51040e) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11951](biomejs/biome#11951): the GritQL formatter no longer inserts a space after a `within` pattern without an `until` clause. ```diff -$arg <: within `bar($_)` , +$arg <: within `bar($_)`, ``` - [#​11794](biomejs/biome#11794) [`429cf95`](biomejs/biome@429cf95) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noTailwindRawColors`](https://biomejs.dev/linter/rules/no-tailwind-raw-colors/) for JavaScript and HTML. It disallows Tailwind palette colors such as `bg-pink-500` and `text-white`, encouraging design system color utilities such as `bg-primary`. - [#​11837](biomejs/biome#11837) [`f5e249b`](biomejs/biome@f5e249b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11836](biomejs/biome#11836): `biome check --write` no longer adds invalid parentheses around Svelte `{@const}` declarations when experimental HTML support and formatting are enabled. - [#​11978](biomejs/biome#11978) [`8be0b9e`](biomejs/biome@8be0b9e) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11817](biomejs/biome#11817): Biome no longer crashes when its output is piped to a program that exits early, such as `head`. Output to the closed pipe is now discarded and Biome exits normally. - [#​11868](biomejs/biome#11868) [`3841c26`](biomejs/biome@3841c26) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​8986](biomejs/biome#8986): Biome's language server now scopes all watched-file patterns to each workspace folder, falling back to the deprecated `rootUri` when no workspace folders are provided. Clients without relative-pattern support receive compatible absolute glob patterns. - [#​11928](biomejs/biome#11928) [`0015681`](biomejs/biome@0015681) Thanks [@​dyc3](https://github.com/dyc3)! - Restricted access to the Unix daemon socket to the user running Biome. The socket now lives in a `biome-daemon` directory inside Biome's cache directory that only this user can access, and the socket itself has mode `0600`. - [#​11835](biomejs/biome#11835) [`589ca1a`](biomejs/biome@589ca1a) Thanks [@​dyc3](https://github.com/dyc3)! - Updated [`useReactCompiler`](https://biomejs.dev/linter/rules/use-react-compiler/): Biome now reports React Compiler diagnostics regardless of the React version declared in `package.json`. - [#​11907](biomejs/biome#11907) [`b7d9037`](biomejs/biome@b7d9037) Thanks [@​posido](https://github.com/posido)! - Fixed [withastro/compiler-rs#194](withastro/compiler-rs#194): the HTML parser no longer treats a regex literal that starts with `>` as the end of a self-closing tag. Astro frontmatter such as `const escaped = s.replace(/>/g, ">");` no longer swallows the closing `---` fence, and the same regex inside a template expression no longer runs past its closing `}`. A regex literal after a keyword such as `return`, as in `return />'/.test(s)`, is now recognized too. - [#​12021](biomejs/biome#12021) [`59cc595`](biomejs/biome@59cc595) Thanks [@​dyc3](https://github.com/dyc3)! - Type inference performance has been significantly improved. Some popular libraries like Zod, Valibot, Arktype, Effect, Kysely, and Drizzle have gained a \~2-240x speedup in our benchmarks. This improvement affects all rules that use type information. - [#​12044](biomejs/biome#12044) [`c73fb91`](biomejs/biome@c73fb91) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12042](biomejs/biome#12042): the HTML formatter no longer removes the space between text and an inline element on the next line when it joins the lines. ```diff - <p>a <em>b</em> c<u>d</u></p> + <p>a <em>b</em> c <u>d</u></p> ``` - [#​11965](biomejs/biome#11965) [`f90bf38`](biomejs/biome@f90bf38) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed module resolution in long-running workspaces so imports reflect package manifest and TypeScript path-mapping changes without requiring the importing file to be edited. - [#​11860](biomejs/biome#11860) [`0884e29`](biomejs/biome@0884e29) Thanks [@​dyc3](https://github.com/dyc3)! - Removed the `attributes` and `functions` options from the nursery rule [`noTailwindArbitraryValue`](https://biomejs.dev/linter/rules/no-tailwind-arbitrary-value/). The rule now uses the same Tailwind detection as [`useTailwindShorthandClasses`](https://biomejs.dev/linter/rules/use-tailwind-shorthand-classes/). - [#​11969](biomejs/biome#11969) [`865cd30`](biomejs/biome@865cd30) Thanks [@​AlbinoGeek](https://github.com/AlbinoGeek)! - Fixed [#​11962](biomejs/biome#11962): [`noUnknownTypeSelector`](https://biomejs.dev/linter/rules/no-unknown-type-selector/) no longer reports view transition names inside view transition pseudo-elements, such as `page` in `::view-transition-group(page)`. - [#​11914](biomejs/biome#11914) [`06ff47b`](biomejs/biome@06ff47b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11897](biomejs/biome#11897): the safe fix for [`noUselessStringConcat`](https://biomejs.dev/linter/rules/no-useless-string-concat/) now escapes embedded double quotes when combining literals, preserving valid JavaScript and existing escape sequences. - [#​11997](biomejs/biome#11997) [`af7825f`](biomejs/biome@af7825f) Thanks [@​github-actions](https://github.com/apps/github-actions)! - The [noRestrictedDependencies](https://biomejs.dev/linter/rules/no-restricted-dependencies/) rule has been updated with new module replacement data, it should now detect for more relevant replacements. - [#​11827](biomejs/biome#11827) [`31bb662`](biomejs/biome@31bb662) Thanks [@​dfedoryshchev](https://github.com/dfedoryshchev)! - Fixed [#​11566](biomejs/biome#11566): [`useNamingConvention`](https://biomejs.dev/linter/rules/use-naming-convention/) no longer reports a `namespace` declared inside `declare global` or inside an external module declaration. Both positions are documented as always ignored, and the rule offered a safe fix, so `biome check --write` renamed the declaration: ```ts export {} declare global { // no longer renamed to `Jsx` namespace JSX {} } ``` - [#​11814](biomejs/biome#11814) [`23ba25f`](biomejs/biome@23ba25f) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed type inference through generic type aliases that instantiate another generic type with a nested generic argument, such as `type Nested<T> = Box<Wrapper<T>>`. Type-aware rules now resolve members of such types: ```ts declare const nested: Nested<number>; // noUnnecessaryConditions now reports that `??` is unnecessary. const inner = nested.value.inner ?? 1; ``` - [#​11908](biomejs/biome#11908) [`dd5a5ce`](biomejs/biome@dd5a5ce) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed [#​11880](biomejs/biome#11880): Biome no longer misparses a `<<` expression followed by a later `>>>` as TypeScript type arguments. For example, `const mask = 1 << bits` followed by `const m = mask >>> 0` on the next line now parses correctly. - [#​11882](biomejs/biome#11882) [`28c817d`](biomejs/biome@28c817d) Thanks [@​mikehasa](https://github.com/mikehasa)! - Fixed a bug in [`noOctalEscape`](https://biomejs.dev/linter/rules/no-octal-escape/) where the safe fix could silently change a string's value. A legacy octal escape is at most two digits when the leading digit is `4`-`7`, so `"\751"` is `"\75"` + `"1"` (i.e. `"=1"`) but was rewritten to the single character `ǩ`; it is now rewritten to `"\x3d1"`. - [#​11861](biomejs/biome#11861) [`81b0adb`](biomejs/biome@81b0adb) Thanks [@​Netail](https://github.com/Netail)! - Added the new nursery rule [`noSelfImport`](https://biomejs.dev/linter/rules/no-self-import/), which forbids a module from importing itself. ```js // foo.js import foo from "./foo.js"; ``` - [#​12041](biomejs/biome#12041) [`5e14509`](biomejs/biome@5e14509) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed a stack overflow in type-aware lint rules, such as [`noMisusedPromises`](https://biomejs.dev/linter/rules/no-misused-promises/) and [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/), when generic types in files that import each other reference one another in their type parameters. ```ts // entity.ts import type { Repository } from "./repository"; export interface Entity<R extends Repository<any> = Repository<any>> {} // repository.ts import type { Entity } from "./entity"; export interface Repository<E extends Entity<any> = Entity<any>> {} ``` - [#​11838](biomejs/biome#11838) [`9bbff0c`](biomejs/biome@9bbff0c) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`usePromiseRejectErrors`](https://biomejs.dev/linter/rules/use-promise-reject-errors/), which requires Error objects as Promise rejection reasons. ```js Promise.reject("Request failed"); new Promise((resolve, reject) => reject(42)); ``` - [#​11917](biomejs/biome#11917) [`717db8c`](biomejs/biome@717db8c) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noMisplacedListElements`](https://biomejs.dev/linter/rules/no-misplaced-list-elements/) for HTML and JSX, which requires `<li>` elements with an HTML element parent to be children of `<ul>`, `<ol>`, or `<menu>`. For example, `<div><li>Item</li></div>` is invalid. - [#​11919](biomejs/biome#11919) [`8d0b990`](biomejs/biome@8d0b990) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11899](biomejs/biome#11899): disabling a domain no longer disables rules that also belong to another enabled domain. For example, with `"domains": { "react": "all", "next": "none" }`, [`useExhaustiveDependencies`](https://biomejs.dev/linter/rules/use-exhaustive-dependencies/) and [`useHookAtTopLevel`](https://biomejs.dev/linter/rules/use-hook-at-top-level/) are now enabled. Rules enabled explicitly in the configuration also stay enabled when one of their domains is set to `"none"`. - [#​11814](biomejs/biome#11814) [`23ba25f`](biomejs/biome@23ba25f) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed [#​11810](biomejs/biome#11810) and [#​11813](biomejs/biome#11813): type-aware rules such as [`noUnnecessaryConditions`](https://biomejs.dev/linter/rules/no-unnecessary-conditions/) and [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer take several seconds when a member is accessed on a recursive generic type alias, such as react-hook-form's `FieldPathValue` or zustand's `Mutate`. - [#​11983](biomejs/biome#11983) [`cc39794`](biomejs/biome@cc39794) Thanks [@​AlbinoGeek](https://github.com/AlbinoGeek)! - Fixed [#​11939](biomejs/biome#11939): the fix of [`useRegexLiterals`](https://biomejs.dev/linter/rules/use-regex-literals/) no longer escapes a slash that is already escaped. `new RegExp("\\/")` is now fixed to `/\//` instead of the invalid `/\\//`. - [#​11869](biomejs/biome#11869) [`3a21c80`](biomejs/biome@3a21c80) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [`#9105`](biomejs/biome#9105): `vcs.useIgnoreFile` now evaluates parent directory patterns when matching child paths, preserving re-included directories such as `!/src` while ignoring their excluded siblings. - [#​11875](biomejs/biome#11875) [`2cdd220`](biomejs/biome@2cdd220) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11867](biomejs/biome#11867): [`noUndeclaredVariables`](https://biomejs.dev/linter/rules/no-undeclared-variables/) incorrectly reported Vue slot props declared with `v-slot` or its `#` shorthand, including destructured props. - [#​12021](biomejs/biome#12021) [`59cc595`](biomejs/biome@59cc595) Thanks [@​dyc3](https://github.com/dyc3)! - Type inference accuracy has been improved significantly. More global types, like `Array`, `Map`, `Set`, etc., are now fully defined. This should decrease false positives on all typed rules, since less types will be unknown. - [#​11929](biomejs/biome#11929) [`aef690d`](biomejs/biome@aef690d) Thanks [@​Th3S4mur41](https://github.com/Th3S4mur41)! - Fixed [`noUnknownProperty`](https://biomejs.dev/linter/rules/no-unknown-property/) to recognize the `frame-sizing` CSS property. - [#​12022](biomejs/biome#12022) [`6233eb2`](biomejs/biome@6233eb2) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12020](biomejs/biome#12020): the HTML parser now reports an error for a mismatched closing tag like the `</span>` in `<p>two</span></p>`. Previously, it accepted `</span>` as the end of `<p>` because `span` contains the letter `p`, and the formatter deleted everything after it. HTML tag names are matched case-insensitively, so `<DIV></div>` is no longer reported as mismatched. A closing tag with no opening tag at the top level of a file, like the second `</p>` in `<p>a</p></p><p>b</p>`, is now also reported as an error, instead of the formatter deleting it and everything after it. - [#​12037](biomejs/biome#12037) [`48cdbb8`](biomejs/biome@48cdbb8) Thanks [@​ff1451](https://github.com/ff1451)! - Fixed [#​11898](biomejs/biome#11898): [`noUselessReturn`](https://biomejs.dev/linter/rules/no-useless-return/) no longer offers a safe fix for a `return;` that is the body of an unbraced `if`, `else`, or label, because removing it produced invalid code. The safe fix now also keeps comments placed before or after the removed `return;`. ```js function foo() { // Still reported, but the return is no longer removed if (aborted) return; } ``` - [#​12030](biomejs/biome#12030) [`4ff83dd`](biomejs/biome@4ff83dd) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​9155](biomejs/biome#9155): Biome no longer reports a parse error for typed slot props in Vue files, such as `v-slot="{ value }: { value: ValueType }"`. Types used in slot props annotations are now correctly detected as used by [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/). - [#​11955](biomejs/biome#11955) [`088164f`](biomejs/biome@088164f) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11946](biomejs/biome#11946): [`noUnreachable`](https://biomejs.dev/linter/rules/no-unreachable/) and [`useGetterReturn`](https://biomejs.dev/linter/rules/use-getter-return/) now recognize `while` and `do...while` loops with truthy literal conditions as infinite unless control flow exits the loop. - [#​11958](biomejs/biome#11958) [`6964bfc`](biomejs/biome@6964bfc) Thanks [@​erenbati](https://github.com/erenbati)! - Fixed [#​11924](biomejs/biome#11924): [`noFocusedTests`](https://biomejs.dev/linter/rules/no-focused-tests/) no longer reports chained method calls such as `builder.image(url).fit("max")` as focused tests. - [#​11908](biomejs/biome#11908) [`dd5a5ce`](biomejs/biome@dd5a5ce) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed parsing of left shifts between TypeScript instantiation expressions. Biome now parses `f<T> << f<T>` as a left shift of two instantiation expressions, matching TypeScript, instead of reporting a parse error. - [#​11877](biomejs/biome#11877) [`5a53b2c`](biomejs/biome@5a53b2c) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11278](biomejs/biome#11278): [`noUnnecessaryConditions`](https://biomejs.dev/linter/rules/no-unnecessary-conditions/) no longer incorrectly reports optional chaining on `RegExp.exec()` results, including patterns created with `new RegExp()`. Biome now infers the nullable `RegExpExecArray | null` return type, preserving necessary checks such as `new RegExp(pattern).exec(input)?.[1]`. - [#​11906](biomejs/biome#11906) [`b87822d`](biomejs/biome@b87822d) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11900](biomejs/biome#11900): [`useForOf`](https://biomejs.dev/linter/rules/use-for-of/) no longer reports loops that update their index inside the body, including `i += 1` and `argv[++i]`. - [#​11834](biomejs/biome#11834) [`f89dd4f`](biomejs/biome@f89dd4f) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed incorrect type inference when generic parameters are reused across inherited types or swapped in recursive types. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzQuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzNC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/51
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.14` -> `2.5.15`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.14/2.5.15) | --- ### Release Notes <details> <summary>biomejs/biome (@​biomejs/biome)</summary> ### [`v2.5.15`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2515) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.14...@biomejs/biome@2.5.15) ##### Patch Changes - [#​10634](biomejs/biome#10634) [`b436ba0`](biomejs/biome@b436ba0) Thanks [@​subaru-hello](https://github.com/subaru-hello)! - Added the new nursery rule [`noReactObjectTypeAsDefaultProp`](https://biomejs.dev/linter/rules/no-react-object-type-as-default-prop/), which disallows array, object, and function values as default props in React components. For example, the following snippet triggers the rule. ```jsx function Component({ items = [] }) { return items; } ``` - [#​11956](biomejs/biome#11956) [`faa8b37`](biomejs/biome@faa8b37) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noSvelteExportLet`](https://biomejs.dev/linter/rules/no-svelte-export-let/), which disallows declaring Svelte component props with the legacy `export let` syntax. Use the `$props()` rune instead. ```svelte <script> export let name; </script> ``` - [#​10816](biomejs/biome#10816) [`1b9479e`](biomejs/biome@1b9479e) Thanks [@​Th3S4mur41](https://github.com/Th3S4mur41)! - Added a new nursery rule [`useLogicalProperties`](https://biomejs.dev/linter/rules/use-logical-properties) that enforces the use of logical properties in CSS, promoting better internationalization and accessibility practices. The rule supports a `direction` option with `"ltr"` as the default and `"rtl"` as the alternative. This is a first rule covering parts of [#​9034](biomejs/biome#9034) ```json { "linter": { "rules": { "nursery": { "useLogicalProperties": { "level": "warn", "options": { "direction": "rtl" } } } } } } ``` - [#​11960](biomejs/biome#11960) [`1fdb5c2`](biomejs/biome@1fdb5c2) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`useSvelteKitRuneImports`](https://biomejs.dev/linter/rules/use-svelte-kit-rune-imports/), which reports imports from the deprecated `$app/stores` module and suggests `$app/state` instead. ```js import { page } from "$app/stores"; ``` - [#​11723](biomejs/biome#11723) [`3b429d1`](biomejs/biome@3b429d1) Thanks [@​m1handr](https://github.com/m1handr)! - Fixed [#​11656](biomejs/biome#11656): [`noAstroSetHtmlDirective`](https://biomejs.dev/linter/rules/no-astro-set-html-directive/) now correctly reports `set:html` directives inside Astro template expressions. - [#​12023](biomejs/biome#12023) [`874d5ae`](biomejs/biome@874d5ae) Thanks [@​codspeed](https://github.com/apps/codspeed)! - Improved the performance of the HTML formatter up to 4x. - [#​11761](biomejs/biome#11761) [`a3462fe`](biomejs/biome@a3462fe) Thanks [@​saberoueslati](https://github.com/saberoueslati)! - Fixed [#​11351](biomejs/biome#11351): [`useSimplifiedLogicExpression`](https://biomejs.dev/linter/rules/use-simplified-logic-expression/) no longer reports boolean literals on the right side of `||` and `&&` outside boolean contexts, because removing them can change the result of the expression. For example, `y = x || false` is no longer reported, while `if (x || false)` still is. - [#​11732](biomejs/biome#11732) [`ff4c4dd`](biomejs/biome@ff4c4dd) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noMeaninglessVoidOperator`](https://biomejs.dev/linter/rules/no-meaningless-void-operator/), which reports unnecessary uses of `void`, such as `void log()` when `log` returns `void`. The rule allows discarded call results, thenables, `void 0`, and calls returning `never`. - [#​11975](biomejs/biome#11975) [`40dd3fb`](biomejs/biome@40dd3fb) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed the indentation of multiline Astro expressions, in templates and attribute values, when running `biome check --write`. Biome now formats Astro expressions with `biome format` too, and places them at the column of the surrounding markup. ```diff <div> {items.map((item) => ( - <span>{item}</span> -))} + <span>{item}</span> + ))} </div> ``` - [#​12016](biomejs/biome#12016) [`09d4000`](biomejs/biome@09d4000) Thanks [@​codspeed](https://github.com/apps/codspeed)! - Improved the performance of indexing and analysis of big files up to 2x. The improvements are mostly visible in projects that make use of project and types lint rules. - [#​11750](biomejs/biome#11750) [`089bde0`](biomejs/biome@089bde0) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`useStrictBooleanExpressions`](https://biomejs.dev/linter/rules/use-strict-boolean-expressions/), which reports ambiguous truthiness checks such as `if (value)` when `value` has type `number | undefined`. Non-nullable strings and numbers and nullable objects are allowed; the rule has no options. - [#​11494](biomejs/biome#11494) [`ad5b362`](biomejs/biome@ad5b362) Thanks [@​jp-knj](https://github.com/jp-knj)! - Added the nursery rule [`noAstroConflictingSetDirectives`](https://biomejs.dev/linter/rules/no-astro-conflicting-set-directives/), which reports Astro elements with multiple content sources, such as `set:html`, `set:text`, and child content. For example, `<div set:html={html}>content</div>` triggers the rule. - [#​11878](biomejs/biome#11878) [`84d1b3b`](biomejs/biome@84d1b3b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11748](biomejs/biome#11748): [`useExhaustiveSwitchCases`](https://biomejs.dev/linter/rules/use-exhaustive-switch-cases/) now reports missing cases for values created with the mapping overload of `Array.from`, including arrays imported from another module. - [#​11802](biomejs/biome#11802) [`7d1f37e`](biomejs/biome@7d1f37e) Thanks [@​dyc3](https://github.com/dyc3)! - Tailwind classes will now be detected in Svelte, Vue, and Astro class attribute expressions that don't use a class merging function. - [#​11910](biomejs/biome#11910) [`9e50ea2`](biomejs/biome@9e50ea2) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​11504](biomejs/biome#11504), a regression where Biome would silently ignore errors in the configuration file. Now errors are correctly retained and checked before executing any command. - [#​11921](biomejs/biome#11921) [`d568632`](biomejs/biome@d568632) Thanks [@​hirehamir](https://github.com/hirehamir)! - Fixed [#​10846](biomejs/biome#10846): when plugins fail to load, Biome now prints each failing plugin's path on its own line, instead of concatenating bare messages like `Cannot read file.Cannot read file.`. - [#​11930](biomejs/biome#11930) [`82ea5a6`](biomejs/biome@82ea5a6) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11927](biomejs/biome#11927): The HTML formatter no longer duplicates comments around Svelte blocks. This affected a comment after a block such as `{#if}` or `{#each}` at the end of an element, and a comment on the same line as the last element inside a block, before `{:else}`, `{/if}`, or a similar tag. - [#​11931](biomejs/biome#11931) [`0cc46d8`](biomejs/biome@0cc46d8) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed the indentation of comments at the end of a Svelte block's contents. A comment before `{:else}`, `{:then}`, `{/if}`, or a similar tag is now indented with the block's contents instead of with the tag. ```diff {#if condition} <span>Text</span> -<!-- comment --> + <!-- comment --> {/if} ``` - [#​12031](biomejs/biome#12031) [`ef0edd4`](biomejs/biome@ef0edd4) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12027](biomejs/biome#12027): Biome's test rules no longer mistake regular method calls named `test`, `it`, or `describe` for tests. For example, [`useValidTestTitle`](https://biomejs.dev/linter/rules/use-valid-test-title/) used to report the following regular expression check as a test with an invalid title: ```js const isComment = /^\s*#/.test(line); ``` - [#​11959](biomejs/biome#11959) [`8477e61`](biomejs/biome@8477e61) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11950](biomejs/biome#11950): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) now reports arrow functions with expression bodies that only reference themselves, such as `let h = () => h();`. - [#​11915](biomejs/biome#11915) [`3260602`](biomejs/biome@3260602) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​11841](biomejs/biome#11841), where suppression comments had no effect on some parts of HTML-ish files and on snippets embedded in JavaScript files. Now the following suppression works as expected: ```vue <!-- biome-ignore lint/correctness/noUndeclaredVariables: intentionally external --> <div :title="missingValue"></div> ``` - [#​11952](biomejs/biome#11952) [`b51040e`](biomejs/biome@b51040e) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11951](biomejs/biome#11951): the GritQL formatter no longer inserts a space after a `within` pattern without an `until` clause. ```diff -$arg <: within `bar($_)` , +$arg <: within `bar($_)`, ``` - [#​11794](biomejs/biome#11794) [`429cf95`](biomejs/biome@429cf95) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noTailwindRawColors`](https://biomejs.dev/linter/rules/no-tailwind-raw-colors/) for JavaScript and HTML. It disallows Tailwind palette colors such as `bg-pink-500` and `text-white`, encouraging design system color utilities such as `bg-primary`. - [#​11837](biomejs/biome#11837) [`f5e249b`](biomejs/biome@f5e249b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11836](biomejs/biome#11836): `biome check --write` no longer adds invalid parentheses around Svelte `{@const}` declarations when experimental HTML support and formatting are enabled. - [#​11978](biomejs/biome#11978) [`8be0b9e`](biomejs/biome@8be0b9e) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11817](biomejs/biome#11817): Biome no longer crashes when its output is piped to a program that exits early, such as `head`. Output to the closed pipe is now discarded and Biome exits normally. - [#​11868](biomejs/biome#11868) [`3841c26`](biomejs/biome@3841c26) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​8986](biomejs/biome#8986): Biome's language server now scopes all watched-file patterns to each workspace folder, falling back to the deprecated `rootUri` when no workspace folders are provided. Clients without relative-pattern support receive compatible absolute glob patterns. - [#​11928](biomejs/biome#11928) [`0015681`](biomejs/biome@0015681) Thanks [@​dyc3](https://github.com/dyc3)! - Restricted access to the Unix daemon socket to the user running Biome. The socket now lives in a `biome-daemon` directory inside Biome's cache directory that only this user can access, and the socket itself has mode `0600`. - [#​11835](biomejs/biome#11835) [`589ca1a`](biomejs/biome@589ca1a) Thanks [@​dyc3](https://github.com/dyc3)! - Updated [`useReactCompiler`](https://biomejs.dev/linter/rules/use-react-compiler/): Biome now reports React Compiler diagnostics regardless of the React version declared in `package.json`. - [#​11907](biomejs/biome#11907) [`b7d9037`](biomejs/biome@b7d9037) Thanks [@​posido](https://github.com/posido)! - Fixed [withastro/compiler-rs#194](withastro/compiler-rs#194): the HTML parser no longer treats a regex literal that starts with `>` as the end of a self-closing tag. Astro frontmatter such as `const escaped = s.replace(/>/g, ">");` no longer swallows the closing `---` fence, and the same regex inside a template expression no longer runs past its closing `}`. A regex literal after a keyword such as `return`, as in `return />'/.test(s)`, is now recognized too. - [#​12021](biomejs/biome#12021) [`59cc595`](biomejs/biome@59cc595) Thanks [@​dyc3](https://github.com/dyc3)! - Type inference performance has been significantly improved. Some popular libraries like Zod, Valibot, Arktype, Effect, Kysely, and Drizzle have gained a \~2-240x speedup in our benchmarks. This improvement affects all rules that use type information. - [#​12044](biomejs/biome#12044) [`c73fb91`](biomejs/biome@c73fb91) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12042](biomejs/biome#12042): the HTML formatter no longer removes the space between text and an inline element on the next line when it joins the lines. ```diff - <p>a <em>b</em> c<u>d</u></p> + <p>a <em>b</em> c <u>d</u></p> ``` - [#​11965](biomejs/biome#11965) [`f90bf38`](biomejs/biome@f90bf38) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed module resolution in long-running workspaces so imports reflect package manifest and TypeScript path-mapping changes without requiring the importing file to be edited. - [#​11860](biomejs/biome#11860) [`0884e29`](biomejs/biome@0884e29) Thanks [@​dyc3](https://github.com/dyc3)! - Removed the `attributes` and `functions` options from the nursery rule [`noTailwindArbitraryValue`](https://biomejs.dev/linter/rules/no-tailwind-arbitrary-value/). The rule now uses the same Tailwind detection as [`useTailwindShorthandClasses`](https://biomejs.dev/linter/rules/use-tailwind-shorthand-classes/). - [#​11969](biomejs/biome#11969) [`865cd30`](biomejs/biome@865cd30) Thanks [@​AlbinoGeek](https://github.com/AlbinoGeek)! - Fixed [#​11962](biomejs/biome#11962): [`noUnknownTypeSelector`](https://biomejs.dev/linter/rules/no-unknown-type-selector/) no longer reports view transition names inside view transition pseudo-elements, such as `page` in `::view-transition-group(page)`. - [#​11914](biomejs/biome#11914) [`06ff47b`](biomejs/biome@06ff47b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11897](biomejs/biome#11897): the safe fix for [`noUselessStringConcat`](https://biomejs.dev/linter/rules/no-useless-string-concat/) now escapes embedded double quotes when combining literals, preserving valid JavaScript and existing escape sequences. - [#​11997](biomejs/biome#11997) [`af7825f`](biomejs/biome@af7825f) Thanks [@​github-actions](https://github.com/apps/github-actions)! - The [noRestrictedDependencies](https://biomejs.dev/linter/rules/no-restricted-dependencies/) rule has been updated with new module replacement data, it should now detect for more relevant replacements. - [#​11827](biomejs/biome#11827) [`31bb662`](biomejs/biome@31bb662) Thanks [@​dfedoryshchev](https://github.com/dfedoryshchev)! - Fixed [#​11566](biomejs/biome#11566): [`useNamingConvention`](https://biomejs.dev/linter/rules/use-naming-convention/) no longer reports a `namespace` declared inside `declare global` or inside an external module declaration. Both positions are documented as always ignored, and the rule offered a safe fix, so `biome check --write` renamed the declaration: ```ts export {} declare global { // no longer renamed to `Jsx` namespace JSX {} } ``` - [#​11814](biomejs/biome#11814) [`23ba25f`](biomejs/biome@23ba25f) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed type inference through generic type aliases that instantiate another generic type with a nested generic argument, such as `type Nested<T> = Box<Wrapper<T>>`. Type-aware rules now resolve members of such types: ```ts declare const nested: Nested<number>; // noUnnecessaryConditions now reports that `??` is unnecessary. const inner = nested.value.inner ?? 1; ``` - [#​11908](biomejs/biome#11908) [`dd5a5ce`](biomejs/biome@dd5a5ce) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed [#​11880](biomejs/biome#11880): Biome no longer misparses a `<<` expression followed by a later `>>>` as TypeScript type arguments. For example, `const mask = 1 << bits` followed by `const m = mask >>> 0` on the next line now parses correctly. - [#​11882](biomejs/biome#11882) [`28c817d`](biomejs/biome@28c817d) Thanks [@​mikehasa](https://github.com/mikehasa)! - Fixed a bug in [`noOctalEscape`](https://biomejs.dev/linter/rules/no-octal-escape/) where the safe fix could silently change a string's value. A legacy octal escape is at most two digits when the leading digit is `4`-`7`, so `"\751"` is `"\75"` + `"1"` (i.e. `"=1"`) but was rewritten to the single character `ǩ`; it is now rewritten to `"\x3d1"`. - [#​11861](biomejs/biome#11861) [`81b0adb`](biomejs/biome@81b0adb) Thanks [@​Netail](https://github.com/Netail)! - Added the new nursery rule [`noSelfImport`](https://biomejs.dev/linter/rules/no-self-import/), which forbids a module from importing itself. ```js // foo.js import foo from "./foo.js"; ``` - [#​12041](biomejs/biome#12041) [`5e14509`](biomejs/biome@5e14509) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed a stack overflow in type-aware lint rules, such as [`noMisusedPromises`](https://biomejs.dev/linter/rules/no-misused-promises/) and [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/), when generic types in files that import each other reference one another in their type parameters. ```ts // entity.ts import type { Repository } from "./repository"; export interface Entity<R extends Repository<any> = Repository<any>> {} // repository.ts import type { Entity } from "./entity"; export interface Repository<E extends Entity<any> = Entity<any>> {} ``` - [#​11838](biomejs/biome#11838) [`9bbff0c`](biomejs/biome@9bbff0c) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`usePromiseRejectErrors`](https://biomejs.dev/linter/rules/use-promise-reject-errors/), which requires Error objects as Promise rejection reasons. ```js Promise.reject("Request failed"); new Promise((resolve, reject) => reject(42)); ``` - [#​11917](biomejs/biome#11917) [`717db8c`](biomejs/biome@717db8c) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noMisplacedListElements`](https://biomejs.dev/linter/rules/no-misplaced-list-elements/) for HTML and JSX, which requires `<li>` elements with an HTML element parent to be children of `<ul>`, `<ol>`, or `<menu>`. For example, `<div><li>Item</li></div>` is invalid. - [#​11919](biomejs/biome#11919) [`8d0b990`](biomejs/biome@8d0b990) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11899](biomejs/biome#11899): disabling a domain no longer disables rules that also belong to another enabled domain. For example, with `"domains": { "react": "all", "next": "none" }`, [`useExhaustiveDependencies`](https://biomejs.dev/linter/rules/use-exhaustive-dependencies/) and [`useHookAtTopLevel`](https://biomejs.dev/linter/rules/use-hook-at-top-level/) are now enabled. Rules enabled explicitly in the configuration also stay enabled when one of their domains is set to `"none"`. - [#​11814](biomejs/biome#11814) [`23ba25f`](biomejs/biome@23ba25f) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed [#​11810](biomejs/biome#11810) and [#​11813](biomejs/biome#11813): type-aware rules such as [`noUnnecessaryConditions`](https://biomejs.dev/linter/rules/no-unnecessary-conditions/) and [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer take several seconds when a member is accessed on a recursive generic type alias, such as react-hook-form's `FieldPathValue` or zustand's `Mutate`. - [#​11983](biomejs/biome#11983) [`cc39794`](biomejs/biome@cc39794) Thanks [@​AlbinoGeek](https://github.com/AlbinoGeek)! - Fixed [#​11939](biomejs/biome#11939): the fix of [`useRegexLiterals`](https://biomejs.dev/linter/rules/use-regex-literals/) no longer escapes a slash that is already escaped. `new RegExp("\\/")` is now fixed to `/\//` instead of the invalid `/\\//`. - [#​11869](biomejs/biome#11869) [`3a21c80`](biomejs/biome@3a21c80) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [`#9105`](biomejs/biome#9105): `vcs.useIgnoreFile` now evaluates parent directory patterns when matching child paths, preserving re-included directories such as `!/src` while ignoring their excluded siblings. - [#​11875](biomejs/biome#11875) [`2cdd220`](biomejs/biome@2cdd220) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11867](biomejs/biome#11867): [`noUndeclaredVariables`](https://biomejs.dev/linter/rules/no-undeclared-variables/) incorrectly reported Vue slot props declared with `v-slot` or its `#` shorthand, including destructured props. - [#​12021](biomejs/biome#12021) [`59cc595`](biomejs/biome@59cc595) Thanks [@​dyc3](https://github.com/dyc3)! - Type inference accuracy has been improved significantly. More global types, like `Array`, `Map`, `Set`, etc., are now fully defined. This should decrease false positives on all typed rules, since less types will be unknown. - [#​11929](biomejs/biome#11929) [`aef690d`](biomejs/biome@aef690d) Thanks [@​Th3S4mur41](https://github.com/Th3S4mur41)! - Fixed [`noUnknownProperty`](https://biomejs.dev/linter/rules/no-unknown-property/) to recognize the `frame-sizing` CSS property. - [#​12022](biomejs/biome#12022) [`6233eb2`](biomejs/biome@6233eb2) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12020](biomejs/biome#12020): the HTML parser now reports an error for a mismatched closing tag like the `</span>` in `<p>two</span></p>`. Previously, it accepted `</span>` as the end of `<p>` because `span` contains the letter `p`, and the formatter deleted everything after it. HTML tag names are matched case-insensitively, so `<DIV></div>` is no longer reported as mismatched. A closing tag with no opening tag at the top level of a file, like the second `</p>` in `<p>a</p></p><p>b</p>`, is now also reported as an error, instead of the formatter deleting it and everything after it. - [#​12037](biomejs/biome#12037) [`48cdbb8`](biomejs/biome@48cdbb8) Thanks [@​ff1451](https://github.com/ff1451)! - Fixed [#​11898](biomejs/biome#11898): [`noUselessReturn`](https://biomejs.dev/linter/rules/no-useless-return/) no longer offers a safe fix for a `return;` that is the body of an unbraced `if`, `else`, or label, because removing it produced invalid code. The safe fix now also keeps comments placed before or after the removed `return;`. ```js function foo() { // Still reported, but the return is no longer removed if (aborted) return; } ``` - [#​12030](biomejs/biome#12030) [`4ff83dd`](biomejs/biome@4ff83dd) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​9155](biomejs/biome#9155): Biome no longer reports a parse error for typed slot props in Vue files, such as `v-slot="{ value }: { value: ValueType }"`. Types used in slot props annotations are now correctly detected as used by [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/). - [#​11955](biomejs/biome#11955) [`088164f`](biomejs/biome@088164f) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11946](biomejs/biome#11946): [`noUnreachable`](https://biomejs.dev/linter/rules/no-unreachable/) and [`useGetterReturn`](https://biomejs.dev/linter/rules/use-getter-return/) now recognize `while` and `do...while` loops with truthy literal conditions as infinite unless control flow exits the loop. - [#​11958](biomejs/biome#11958) [`6964bfc`](biomejs/biome@6964bfc) Thanks [@​erenbati](https://github.com/erenbati)! - Fixed [#​11924](biomejs/biome#11924): [`noFocusedTests`](https://biomejs.dev/linter/rules/no-focused-tests/) no longer reports chained method calls such as `builder.image(url).fit("max")` as focused tests. - [#​11908](biomejs/biome#11908) [`dd5a5ce`](biomejs/biome@dd5a5ce) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed parsing of left shifts between TypeScript instantiation expressions. Biome now parses `f<T> << f<T>` as a left shift of two instantiation expressions, matching TypeScript, instead of reporting a parse error. - [#​11877](biomejs/biome#11877) [`5a53b2c`](biomejs/biome@5a53b2c) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11278](biomejs/biome#11278): [`noUnnecessaryConditions`](https://biomejs.dev/linter/rules/no-unnecessary-conditions/) no longer incorrectly reports optional chaining on `RegExp.exec()` results, including patterns created with `new RegExp()`. Biome now infers the nullable `RegExpExecArray | null` return type, preserving necessary checks such as `new RegExp(pattern).exec(input)?.[1]`. - [#​11906](biomejs/biome#11906) [`b87822d`](biomejs/biome@b87822d) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11900](biomejs/biome#11900): [`useForOf`](https://biomejs.dev/linter/rules/use-for-of/) no longer reports loops that update their index inside the body, including `i += 1` and `argv[++i]`. - [#​11834](biomejs/biome#11834) [`f89dd4f`](biomejs/biome@f89dd4f) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed incorrect type inference when generic parameters are reused across inherited types or swapped in recursive types. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzQuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzNC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/25
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | [`2.5.14` → `2.5.15`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.14/2.5.15) |  |  | --- ### Release Notes <details> <summary>biomejs/biome (@​biomejs/biome)</summary> ### [`v2.5.15`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2515) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.14...@biomejs/biome@2.5.15) ##### Patch Changes - [#​10634](biomejs/biome#10634) [`b436ba0`](biomejs/biome@b436ba0) Thanks [@​subaru-hello](https://github.com/subaru-hello)! - Added the new nursery rule [`noReactObjectTypeAsDefaultProp`](https://biomejs.dev/linter/rules/no-react-object-type-as-default-prop/), which disallows array, object, and function values as default props in React components. For example, the following snippet triggers the rule. ```jsx function Component({ items = [] }) { return items; } ``` - [#​11956](biomejs/biome#11956) [`faa8b37`](biomejs/biome@faa8b37) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noSvelteExportLet`](https://biomejs.dev/linter/rules/no-svelte-export-let/), which disallows declaring Svelte component props with the legacy `export let` syntax. Use the `$props()` rune instead. ```svelte <script> export let name; </script> ``` - [#​10816](biomejs/biome#10816) [`1b9479e`](biomejs/biome@1b9479e) Thanks [@​Th3S4mur41](https://github.com/Th3S4mur41)! - Added a new nursery rule [`useLogicalProperties`](https://biomejs.dev/linter/rules/use-logical-properties) that enforces the use of logical properties in CSS, promoting better internationalization and accessibility practices. The rule supports a `direction` option with `"ltr"` as the default and `"rtl"` as the alternative. This is a first rule covering parts of [#​9034](biomejs/biome#9034) ```json { "linter": { "rules": { "nursery": { "useLogicalProperties": { "level": "warn", "options": { "direction": "rtl" } } } } } } ``` - [#​11960](biomejs/biome#11960) [`1fdb5c2`](biomejs/biome@1fdb5c2) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`useSvelteKitRuneImports`](https://biomejs.dev/linter/rules/use-svelte-kit-rune-imports/), which reports imports from the deprecated `$app/stores` module and suggests `$app/state` instead. ```js import { page } from "$app/stores"; ``` - [#​11723](biomejs/biome#11723) [`3b429d1`](biomejs/biome@3b429d1) Thanks [@​m1handr](https://github.com/m1handr)! - Fixed [#​11656](biomejs/biome#11656): [`noAstroSetHtmlDirective`](https://biomejs.dev/linter/rules/no-astro-set-html-directive/) now correctly reports `set:html` directives inside Astro template expressions. - [#​12023](biomejs/biome#12023) [`874d5ae`](biomejs/biome@874d5ae) Thanks [@​codspeed](https://github.com/apps/codspeed)! - Improved the performance of the HTML formatter up to 4x. - [#​11761](biomejs/biome#11761) [`a3462fe`](biomejs/biome@a3462fe) Thanks [@​saberoueslati](https://github.com/saberoueslati)! - Fixed [#​11351](biomejs/biome#11351): [`useSimplifiedLogicExpression`](https://biomejs.dev/linter/rules/use-simplified-logic-expression/) no longer reports boolean literals on the right side of `||` and `&&` outside boolean contexts, because removing them can change the result of the expression. For example, `y = x || false` is no longer reported, while `if (x || false)` still is. - [#​11732](biomejs/biome#11732) [`ff4c4dd`](biomejs/biome@ff4c4dd) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noMeaninglessVoidOperator`](https://biomejs.dev/linter/rules/no-meaningless-void-operator/), which reports unnecessary uses of `void`, such as `void log()` when `log` returns `void`. The rule allows discarded call results, thenables, `void 0`, and calls returning `never`. - [#​11975](biomejs/biome#11975) [`40dd3fb`](biomejs/biome@40dd3fb) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed the indentation of multiline Astro expressions, in templates and attribute values, when running `biome check --write`. Biome now formats Astro expressions with `biome format` too, and places them at the column of the surrounding markup. ```diff <div> {items.map((item) => ( - <span>{item}</span> -))} + <span>{item}</span> + ))} </div> ``` - [#​12016](biomejs/biome#12016) [`09d4000`](biomejs/biome@09d4000) Thanks [@​codspeed](https://github.com/apps/codspeed)! - Improved the performance of indexing and analysis of big files up to 2x. The improvements are mostly visible in projects that make use of project and types lint rules. - [#​11750](biomejs/biome#11750) [`089bde0`](biomejs/biome@089bde0) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`useStrictBooleanExpressions`](https://biomejs.dev/linter/rules/use-strict-boolean-expressions/), which reports ambiguous truthiness checks such as `if (value)` when `value` has type `number | undefined`. Non-nullable strings and numbers and nullable objects are allowed; the rule has no options. - [#​11494](biomejs/biome#11494) [`ad5b362`](biomejs/biome@ad5b362) Thanks [@​jp-knj](https://github.com/jp-knj)! - Added the nursery rule [`noAstroConflictingSetDirectives`](https://biomejs.dev/linter/rules/no-astro-conflicting-set-directives/), which reports Astro elements with multiple content sources, such as `set:html`, `set:text`, and child content. For example, `<div set:html={html}>content</div>` triggers the rule. - [#​11878](biomejs/biome#11878) [`84d1b3b`](biomejs/biome@84d1b3b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11748](biomejs/biome#11748): [`useExhaustiveSwitchCases`](https://biomejs.dev/linter/rules/use-exhaustive-switch-cases/) now reports missing cases for values created with the mapping overload of `Array.from`, including arrays imported from another module. - [#​11802](biomejs/biome#11802) [`7d1f37e`](biomejs/biome@7d1f37e) Thanks [@​dyc3](https://github.com/dyc3)! - Tailwind classes will now be detected in Svelte, Vue, and Astro class attribute expressions that don't use a class merging function. - [#​11910](biomejs/biome#11910) [`9e50ea2`](biomejs/biome@9e50ea2) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​11504](biomejs/biome#11504), a regression where Biome would silently ignore errors in the configuration file. Now errors are correctly retained and checked before executing any command. - [#​11921](biomejs/biome#11921) [`d568632`](biomejs/biome@d568632) Thanks [@​hirehamir](https://github.com/hirehamir)! - Fixed [#​10846](biomejs/biome#10846): when plugins fail to load, Biome now prints each failing plugin's path on its own line, instead of concatenating bare messages like `Cannot read file.Cannot read file.`. - [#​11930](biomejs/biome#11930) [`82ea5a6`](biomejs/biome@82ea5a6) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11927](biomejs/biome#11927): The HTML formatter no longer duplicates comments around Svelte blocks. This affected a comment after a block such as `{#if}` or `{#each}` at the end of an element, and a comment on the same line as the last element inside a block, before `{:else}`, `{/if}`, or a similar tag. - [#​11931](biomejs/biome#11931) [`0cc46d8`](biomejs/biome@0cc46d8) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed the indentation of comments at the end of a Svelte block's contents. A comment before `{:else}`, `{:then}`, `{/if}`, or a similar tag is now indented with the block's contents instead of with the tag. ```diff {#if condition} <span>Text</span> -<!-- comment --> + <!-- comment --> {/if} ``` - [#​12031](biomejs/biome#12031) [`ef0edd4`](biomejs/biome@ef0edd4) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12027](biomejs/biome#12027): Biome's test rules no longer mistake regular method calls named `test`, `it`, or `describe` for tests. For example, [`useValidTestTitle`](https://biomejs.dev/linter/rules/use-valid-test-title/) used to report the following regular expression check as a test with an invalid title: ```js const isComment = /^\s*#/.test(line); ``` - [#​11959](biomejs/biome#11959) [`8477e61`](biomejs/biome@8477e61) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11950](biomejs/biome#11950): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) now reports arrow functions with expression bodies that only reference themselves, such as `let h = () => h();`. - [#​11915](biomejs/biome#11915) [`3260602`](biomejs/biome@3260602) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​11841](biomejs/biome#11841), where suppression comments had no effect on some parts of HTML-ish files and on snippets embedded in JavaScript files. Now the following suppression works as expected: ```vue <!-- biome-ignore lint/correctness/noUndeclaredVariables: intentionally external --> <div :title="missingValue"></div> ``` - [#​11952](biomejs/biome#11952) [`b51040e`](biomejs/biome@b51040e) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11951](biomejs/biome#11951): the GritQL formatter no longer inserts a space after a `within` pattern without an `until` clause. ```diff -$arg <: within `bar($_)` , +$arg <: within `bar($_)`, ``` - [#​11794](biomejs/biome#11794) [`429cf95`](biomejs/biome@429cf95) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noTailwindRawColors`](https://biomejs.dev/linter/rules/no-tailwind-raw-colors/) for JavaScript and HTML. It disallows Tailwind palette colors such as `bg-pink-500` and `text-white`, encouraging design system color utilities such as `bg-primary`. - [#​11837](biomejs/biome#11837) [`f5e249b`](biomejs/biome@f5e249b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11836](biomejs/biome#11836): `biome check --write` no longer adds invalid parentheses around Svelte `{@const}` declarations when experimental HTML support and formatting are enabled. - [#​11978](biomejs/biome#11978) [`8be0b9e`](biomejs/biome@8be0b9e) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11817](biomejs/biome#11817): Biome no longer crashes when its output is piped to a program that exits early, such as `head`. Output to the closed pipe is now discarded and Biome exits normally. - [#​11868](biomejs/biome#11868) [`3841c26`](biomejs/biome@3841c26) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​8986](biomejs/biome#8986): Biome's language server now scopes all watched-file patterns to each workspace folder, falling back to the deprecated `rootUri` when no workspace folders are provided. Clients without relative-pattern support receive compatible absolute glob patterns. - [#​11928](biomejs/biome#11928) [`0015681`](biomejs/biome@0015681) Thanks [@​dyc3](https://github.com/dyc3)! - Restricted access to the Unix daemon socket to the user running Biome. The socket now lives in a `biome-daemon` directory inside Biome's cache directory that only this user can access, and the socket itself has mode `0600`. - [#​11835](biomejs/biome#11835) [`589ca1a`](biomejs/biome@589ca1a) Thanks [@​dyc3](https://github.com/dyc3)! - Updated [`useReactCompiler`](https://biomejs.dev/linter/rules/use-react-compiler/): Biome now reports React Compiler diagnostics regardless of the React version declared in `package.json`. - [#​11907](biomejs/biome#11907) [`b7d9037`](biomejs/biome@b7d9037) Thanks [@​posido](https://github.com/posido)! - Fixed [withastro/compiler-rs#194](withastro/compiler-rs#194): the HTML parser no longer treats a regex literal that starts with `>` as the end of a self-closing tag. Astro frontmatter such as `const escaped = s.replace(/>/g, ">");` no longer swallows the closing `---` fence, and the same regex inside a template expression no longer runs past its closing `}`. A regex literal after a keyword such as `return`, as in `return />'/.test(s)`, is now recognized too. - [#​12021](biomejs/biome#12021) [`59cc595`](biomejs/biome@59cc595) Thanks [@​dyc3](https://github.com/dyc3)! - Type inference performance has been significantly improved. Some popular libraries like Zod, Valibot, Arktype, Effect, Kysely, and Drizzle have gained a \~2-240x speedup in our benchmarks. This improvement affects all rules that use type information. - [#​12044](biomejs/biome#12044) [`c73fb91`](biomejs/biome@c73fb91) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12042](biomejs/biome#12042): the HTML formatter no longer removes the space between text and an inline element on the next line when it joins the lines. ```diff - <p>a <em>b</em> c<u>d</u></p> + <p>a <em>b</em> c <u>d</u></p> ``` - [#​11965](biomejs/biome#11965) [`f90bf38`](biomejs/biome@f90bf38) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed module resolution in long-running workspaces so imports reflect package manifest and TypeScript path-mapping changes without requiring the importing file to be edited. - [#​11860](biomejs/biome#11860) [`0884e29`](biomejs/biome@0884e29) Thanks [@​dyc3](https://github.com/dyc3)! - Removed the `attributes` and `functions` options from the nursery rule [`noTailwindArbitraryValue`](https://biomejs.dev/linter/rules/no-tailwind-arbitrary-value/). The rule now uses the same Tailwind detection as [`useTailwindShorthandClasses`](https://biomejs.dev/linter/rules/use-tailwind-shorthand-classes/). - [#​11969](biomejs/biome#11969) [`865cd30`](biomejs/biome@865cd30) Thanks [@​AlbinoGeek](https://github.com/AlbinoGeek)! - Fixed [#​11962](biomejs/biome#11962): [`noUnknownTypeSelector`](https://biomejs.dev/linter/rules/no-unknown-type-selector/) no longer reports view transition names inside view transition pseudo-elements, such as `page` in `::view-transition-group(page)`. - [#​11914](biomejs/biome#11914) [`06ff47b`](biomejs/biome@06ff47b) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11897](biomejs/biome#11897): the safe fix for [`noUselessStringConcat`](https://biomejs.dev/linter/rules/no-useless-string-concat/) now escapes embedded double quotes when combining literals, preserving valid JavaScript and existing escape sequences. - [#​11997](biomejs/biome#11997) [`af7825f`](biomejs/biome@af7825f) Thanks [@​github-actions](https://github.com/apps/github-actions)! - The [noRestrictedDependencies](https://biomejs.dev/linter/rules/no-restricted-dependencies/) rule has been updated with new module replacement data, it should now detect for more relevant replacements. - [#​11827](biomejs/biome#11827) [`31bb662`](biomejs/biome@31bb662) Thanks [@​dfedoryshchev](https://github.com/dfedoryshchev)! - Fixed [#​11566](biomejs/biome#11566): [`useNamingConvention`](https://biomejs.dev/linter/rules/use-naming-convention/) no longer reports a `namespace` declared inside `declare global` or inside an external module declaration. Both positions are documented as always ignored, and the rule offered a safe fix, so `biome check --write` renamed the declaration: ```ts export {} declare global { // no longer renamed to `Jsx` namespace JSX {} } ``` - [#​11814](biomejs/biome#11814) [`23ba25f`](biomejs/biome@23ba25f) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed type inference through generic type aliases that instantiate another generic type with a nested generic argument, such as `type Nested<T> = Box<Wrapper<T>>`. Type-aware rules now resolve members of such types: ```ts declare const nested: Nested<number>; // noUnnecessaryConditions now reports that `??` is unnecessary. const inner = nested.value.inner ?? 1; ``` - [#​11908](biomejs/biome#11908) [`dd5a5ce`](biomejs/biome@dd5a5ce) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed [#​11880](biomejs/biome#11880): Biome no longer misparses a `<<` expression followed by a later `>>>` as TypeScript type arguments. For example, `const mask = 1 << bits` followed by `const m = mask >>> 0` on the next line now parses correctly. - [#​11882](biomejs/biome#11882) [`28c817d`](biomejs/biome@28c817d) Thanks [@​mikehasa](https://github.com/mikehasa)! - Fixed a bug in [`noOctalEscape`](https://biomejs.dev/linter/rules/no-octal-escape/) where the safe fix could silently change a string's value. A legacy octal escape is at most two digits when the leading digit is `4`-`7`, so `"\751"` is `"\75"` + `"1"` (i.e. `"=1"`) but was rewritten to the single character `ǩ`; it is now rewritten to `"\x3d1"`. - [#​11861](biomejs/biome#11861) [`81b0adb`](biomejs/biome@81b0adb) Thanks [@​Netail](https://github.com/Netail)! - Added the new nursery rule [`noSelfImport`](https://biomejs.dev/linter/rules/no-self-import/), which forbids a module from importing itself. ```js // foo.js import foo from "./foo.js"; ``` - [#​12041](biomejs/biome#12041) [`5e14509`](biomejs/biome@5e14509) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed a stack overflow in type-aware lint rules, such as [`noMisusedPromises`](https://biomejs.dev/linter/rules/no-misused-promises/) and [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/), when generic types in files that import each other reference one another in their type parameters. ```ts // entity.ts import type { Repository } from "./repository"; export interface Entity<R extends Repository<any> = Repository<any>> {} // repository.ts import type { Entity } from "./entity"; export interface Repository<E extends Entity<any> = Entity<any>> {} ``` - [#​11838](biomejs/biome#11838) [`9bbff0c`](biomejs/biome@9bbff0c) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`usePromiseRejectErrors`](https://biomejs.dev/linter/rules/use-promise-reject-errors/), which requires Error objects as Promise rejection reasons. ```js Promise.reject("Request failed"); new Promise((resolve, reject) => reject(42)); ``` - [#​11917](biomejs/biome#11917) [`717db8c`](biomejs/biome@717db8c) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noMisplacedListElements`](https://biomejs.dev/linter/rules/no-misplaced-list-elements/) for HTML and JSX, which requires `<li>` elements with an HTML element parent to be children of `<ul>`, `<ol>`, or `<menu>`. For example, `<div><li>Item</li></div>` is invalid. - [#​11919](biomejs/biome#11919) [`8d0b990`](biomejs/biome@8d0b990) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11899](biomejs/biome#11899): disabling a domain no longer disables rules that also belong to another enabled domain. For example, with `"domains": { "react": "all", "next": "none" }`, [`useExhaustiveDependencies`](https://biomejs.dev/linter/rules/use-exhaustive-dependencies/) and [`useHookAtTopLevel`](https://biomejs.dev/linter/rules/use-hook-at-top-level/) are now enabled. Rules enabled explicitly in the configuration also stay enabled when one of their domains is set to `"none"`. - [#​11814](biomejs/biome#11814) [`23ba25f`](biomejs/biome@23ba25f) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed [#​11810](biomejs/biome#11810) and [#​11813](biomejs/biome#11813): type-aware rules such as [`noUnnecessaryConditions`](https://biomejs.dev/linter/rules/no-unnecessary-conditions/) and [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer take several seconds when a member is accessed on a recursive generic type alias, such as react-hook-form's `FieldPathValue` or zustand's `Mutate`. - [#​11983](biomejs/biome#11983) [`cc39794`](biomejs/biome@cc39794) Thanks [@​AlbinoGeek](https://github.com/AlbinoGeek)! - Fixed [#​11939](biomejs/biome#11939): the fix of [`useRegexLiterals`](https://biomejs.dev/linter/rules/use-regex-literals/) no longer escapes a slash that is already escaped. `new RegExp("\\/")` is now fixed to `/\//` instead of the invalid `/\\//`. - [#​11869](biomejs/biome#11869) [`3a21c80`](biomejs/biome@3a21c80) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [`#9105`](biomejs/biome#9105): `vcs.useIgnoreFile` now evaluates parent directory patterns when matching child paths, preserving re-included directories such as `!/src` while ignoring their excluded siblings. - [#​11875](biomejs/biome#11875) [`2cdd220`](biomejs/biome@2cdd220) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11867](biomejs/biome#11867): [`noUndeclaredVariables`](https://biomejs.dev/linter/rules/no-undeclared-variables/) incorrectly reported Vue slot props declared with `v-slot` or its `#` shorthand, including destructured props. - [#​12021](biomejs/biome#12021) [`59cc595`](biomejs/biome@59cc595) Thanks [@​dyc3](https://github.com/dyc3)! - Type inference accuracy has been improved significantly. More global types, like `Array`, `Map`, `Set`, etc., are now fully defined. This should decrease false positives on all typed rules, since less types will be unknown. - [#​11929](biomejs/biome#11929) [`aef690d`](biomejs/biome@aef690d) Thanks [@​Th3S4mur41](https://github.com/Th3S4mur41)! - Fixed [`noUnknownProperty`](https://biomejs.dev/linter/rules/no-unknown-property/) to recognize the `frame-sizing` CSS property. - [#​12022](biomejs/biome#12022) [`6233eb2`](biomejs/biome@6233eb2) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​12020](biomejs/biome#12020): the HTML parser now reports an error for a mismatched closing tag like the `</span>` in `<p>two</span></p>`. Previously, it accepted `</span>` as the end of `<p>` because `span` contains the letter `p`, and the formatter deleted everything after it. HTML tag names are matched case-insensitively, so `<DIV></div>` is no longer reported as mismatched. A closing tag with no opening tag at the top level of a file, like the second `</p>` in `<p>a</p></p><p>b</p>`, is now also reported as an error, instead of the formatter deleting it and everything after it. - [#​12037](biomejs/biome#12037) [`48cdbb8`](biomejs/biome@48cdbb8) Thanks [@​ff1451](https://github.com/ff1451)! - Fixed [#​11898](biomejs/biome#11898): [`noUselessReturn`](https://biomejs.dev/linter/rules/no-useless-return/) no longer offers a safe fix for a `return;` that is the body of an unbraced `if`, `else`, or label, because removing it produced invalid code. The safe fix now also keeps comments placed before or after the removed `return;`. ```js function foo() { // Still reported, but the return is no longer removed if (aborted) return; } ``` - [#​12030](biomejs/biome#12030) [`4ff83dd`](biomejs/biome@4ff83dd) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed [#​9155](biomejs/biome#9155): Biome no longer reports a parse error for typed slot props in Vue files, such as `v-slot="{ value }: { value: ValueType }"`. Types used in slot props annotations are now correctly detected as used by [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/). - [#​11955](biomejs/biome#11955) [`088164f`](biomejs/biome@088164f) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11946](biomejs/biome#11946): [`noUnreachable`](https://biomejs.dev/linter/rules/no-unreachable/) and [`useGetterReturn`](https://biomejs.dev/linter/rules/use-getter-return/) now recognize `while` and `do...while` loops with truthy literal conditions as infinite unless control flow exits the loop. - [#​11958](biomejs/biome#11958) [`6964bfc`](biomejs/biome@6964bfc) Thanks [@​erenbati](https://github.com/erenbati)! - Fixed [#​11924](biomejs/biome#11924): [`noFocusedTests`](https://biomejs.dev/linter/rules/no-focused-tests/) no longer reports chained method calls such as `builder.image(url).fit("max")` as focused tests. - [#​11908](biomejs/biome#11908) [`dd5a5ce`](biomejs/biome@dd5a5ce) Thanks [@​siketyan](https://github.com/siketyan)! - Fixed parsing of left shifts between TypeScript instantiation expressions. Biome now parses `f<T> << f<T>` as a left shift of two instantiation expressions, matching TypeScript, instead of reporting a parse error. - [#​11877](biomejs/biome#11877) [`5a53b2c`](biomejs/biome@5a53b2c) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11278](biomejs/biome#11278): [`noUnnecessaryConditions`](https://biomejs.dev/linter/rules/no-unnecessary-conditions/) no longer incorrectly reports optional chaining on `RegExp.exec()` results, including patterns created with `new RegExp()`. Biome now infers the nullable `RegExpExecArray | null` return type, preserving necessary checks such as `new RegExp(pattern).exec(input)?.[1]`. - [#​11906](biomejs/biome#11906) [`b87822d`](biomejs/biome@b87822d) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed [#​11900](biomejs/biome#11900): [`useForOf`](https://biomejs.dev/linter/rules/use-for-of/) no longer reports loops that update their index inside the body, including `i += 1` and `argv[++i]`. - [#​11834](biomejs/biome#11834) [`f89dd4f`](biomejs/biome@f89dd4f) Thanks [@​dyc3](https://github.com/dyc3)! - Fixed incorrect type inference when generic parameters are reused across inherited types or swapped in recursive types. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "before 9am on tuesday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzMuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjE2NS4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://code.futo.org/harbor/harbor/pulls/1775 Reviewed-by: Mark Harding <mark@futo.org>
Summary
Closes #11351
useSimplifiedLogicExpressionhad a safe fix that turnedy = x || falseintoy = x.||and&&return one of their operands, not a boolean, so whenxisundefinedthe original givesfalseand the fixed version givesundefined.The rule now only touches a right-side boolean literal when the expression is used for its truthiness:
if,while,do...whileandforconditions, the test of a ternary, and the operand of!, also when reached through parentheses or a nested&&/||. Even there it only handlesx || falseandx && true. I leftx || trueandx && falseout on purpose, since replacing them with the literal would stopxfrom being evaluated at all. Left-side literals and the De Morgan rewrite are unchanged.Test Plan
valid.tswith the snippet from the issue.invalid.jshas a case for each boolean context;valid.jshas assignments, call arguments, andeffect() || true/effect() && false.rules_checkpasses.Docs
The
boolExp || trueexample in the rule docs no longer triggers, so I replaced it. I also added an invalid example inside anifand a validvalue || falseexample.This PR was done with the help of Codex