Repository navigation
fix(css_parser): parse unary and identifier-led SCSS list expressions - #12096
Conversation
|
A maintainer will take a look as soon as they can. In the meantime, please make sure that:
|
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (6)
📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. WalkthroughThe parser now recognises unary and identifier-led SCSS expressions in bracketed values, while preserving CSS grid-line identifiers. New fixtures cover parsing, malformed-expression recovery, and formatting. Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to No concrete merge-blocking behavior is established by the supplied change context; the added fixtures cover the stated parsing and formatting cases. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
Summary
Fix parsing of unary and identifier-led binary expressions inside SCSS bracketed lists:
Test Plan
cargo test -p biome_css_parsercargo test -p biome_css_formatter