Skip to content

ci: breakdown conformance job in groups - #12099

Merged
ematipico merged 1 commit into
mainfrom
chore/breakdown-coverage
Oct 3, 2026
Merged

ematipico merged 1 commit into
mainfrom
chore/breakdown-coverage

Conversation

@ematipico

Copy link
Copy Markdown
Member

Summary

Used a coding agent

This PR changes the conformance workflow to run very much like our benchmarks: run the conformance of the parser that was modified

Test Plan

Green CI

Docs

@ematipico
ematipico force-pushed the chore/breakdown-coverage branch from b69e538 to ea386eb Compare October 3, 2026 08:53
@changeset-bot

changeset-bot Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ea386eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: biomejs/biome/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: fce01424-1f7b-49ac-b040-cc35bcc3d166
📥 Commits

Reviewing files that changed from the base of the PR and between eb403a5 and ea386eb.

📒 Files selected for processing (1)
  • .github/workflows/parser_conformance.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The workflow now triggers for changes to parser-related paths, including its own file and Cargo.lock. It maps JavaScript, SCSS, Markdown, and YAML changes to coverage suites, and selects all suites for merge-group runs. Coverage runs only when the selection is non-empty. Both branch runs receive the selected suites. The comparison heading and previous-comment search no longer include an OS suffix.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to ea386

This change adjusts CI conformance suite selection and shows no concrete merge-blocking risk.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the change to run conformance checks in groups.
Description check ✅ Passed The description explains that the workflow runs conformance tests for the modified parser.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ematipico ematipico changed the title chore: add sass spec to coverage ci: breakdown conformance job in groups Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Parser conformance results

js/262

Test result main count This PR count Difference
Total 49797 49797 0
Passed 48773 48773 0
Failed 1024 1024 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

markdown/commonmark

Test result main count This PR count Difference
Total 652 652 0
Passed 652 652 0
Failed 0 0 0
Panics 0 0 0
Coverage 100.00% 100.00% 0.00%

scss/sass-spec

Test result main count This PR count Difference
Total 11463 11463 0
Passed 11080 11080 0
Failed 383 383 0
Panics 0 0 0
Coverage 96.66% 96.66% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2147 2147 0
Failed 4175 4175 0
Panics 0 0 0
Coverage 33.96% 33.96% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13449 13449 0
Failed 4197 4197 0
Panics 0 0 0
Coverage 76.22% 76.22% 0.00%

yaml/yaml-test-suite

Test result main count This PR count Difference
Total 402 402 0
Passed 402 402 0
Failed 0 0 0
Panics 0 0 0
Coverage 100.00% 100.00% 0.00%

@ematipico
ematipico merged commit 08ca501 into main Oct 3, 2026
15 checks passed
@ematipico
ematipico deleted the chore/breakdown-coverage branch October 3, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant