Skip to content

chore: update rule metadata - #12102

Merged
dyc3 merged 1 commit into
mainfrom
dyc3/update-unsupported-rules-71-rules-thr_shj56izvw5
Oct 3, 2026
Merged

dyc3 merged 1 commit into
mainfrom
dyc3/update-unsupported-rules-71-rules-thr_shj56izvw5

Conversation

@dyc3

@dyc3 dyc3 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Summary

decisions made by me, but applied by the clanker

applied by 6.1 sol

Test Plan

green ci

Docs

@changeset-bot

changeset-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 37d064e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-HTML Language: HTML and super languages labels Oct 3, 2026
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: biomejs/biome/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: c0463fb7-e224-4ec3-9a86-4083e6a1f11c
📥 Commits

Reviewing files that changed from the base of the PR and between 2917939 and 37d064e.

⛔ Files ignored due to path filters (6)
  • crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs is excluded by !**/migrate/eslint_any_rule_to_biome.rs and included by **
  • crates/biome_cli/tests/snapshots/main_commands_migrate_eslint_scope/default.snap is excluded by !**/*.snap and included by **
  • crates/biome_cli/tests/snapshots/main_commands_migrate_eslint_scope/include_inspired.snap is excluded by !**/*.snap and included by **
  • crates/biome_cli/tests/snapshots/main_commands_migrate_eslint_scope/include_inspired_and_nursery.snap is excluded by !**/*.snap and included by **
  • crates/biome_cli/tests/snapshots/main_commands_migrate_eslint_scope/include_nursery.snap is excluded by !**/*.snap and included by **
  • crates/biome_cli/tests/specs/migrate_eslint/scopeDecisions/basic.jsonc.snap is excluded by !**/*.snap and included by **
📒 Files selected for processing (48)
  • crates/biome_analyze/src/unsupported_rules.rs
  • crates/biome_cli/src/execute/migrate/eslint_to_biome.rs
  • crates/biome_cli/tests/commands/migrate_eslint_scope.rs
  • crates/biome_cli/tests/specs/migrate_eslint/scopeDecisions/basic.jsonc
  • crates/biome_html_analyze/src/lint/nursery/no_inline_styles.rs
  • crates/biome_js_analyze/src/lint/a11y/no_access_key.rs
  • crates/biome_js_analyze/src/lint/a11y/no_ambiguous_anchor_text.rs
  • crates/biome_js_analyze/src/lint/a11y/no_aria_hidden_on_focusable.rs
  • crates/biome_js_analyze/src/lint/a11y/no_aria_unsupported_elements.rs
  • crates/biome_js_analyze/src/lint/a11y/no_autofocus.rs
  • crates/biome_js_analyze/src/lint/a11y/no_distracting_elements.rs
  • crates/biome_js_analyze/src/lint/a11y/no_header_scope.rs
  • crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs
  • crates/biome_js_analyze/src/lint/a11y/no_label_without_control.rs
  • crates/biome_js_analyze/src/lint/a11y/no_noninteractive_element_interactions.rs
  • crates/biome_js_analyze/src/lint/a11y/no_noninteractive_element_to_interactive_role.rs
  • crates/biome_js_analyze/src/lint/a11y/no_noninteractive_tabindex.rs
  • crates/biome_js_analyze/src/lint/a11y/no_positive_tabindex.rs
  • crates/biome_js_analyze/src/lint/a11y/no_redundant_alt.rs
  • crates/biome_js_analyze/src/lint/a11y/no_redundant_roles.rs
  • crates/biome_js_analyze/src/lint/a11y/no_static_element_interactions.rs
  • crates/biome_js_analyze/src/lint/a11y/use_alt_text.rs
  • crates/biome_js_analyze/src/lint/a11y/use_anchor_content.rs
  • crates/biome_js_analyze/src/lint/a11y/use_aria_activedescendant_with_tabindex.rs
  • crates/biome_js_analyze/src/lint/a11y/use_aria_props_for_role.rs
  • crates/biome_js_analyze/src/lint/a11y/use_aria_props_supported_by_role.rs
  • crates/biome_js_analyze/src/lint/a11y/use_focusable_interactive.rs
  • crates/biome_js_analyze/src/lint/a11y/use_heading_content.rs
  • crates/biome_js_analyze/src/lint/a11y/use_html_lang.rs
  • crates/biome_js_analyze/src/lint/a11y/use_iframe_title.rs
  • crates/biome_js_analyze/src/lint/a11y/use_key_with_click_events.rs
  • crates/biome_js_analyze/src/lint/a11y/use_key_with_mouse_events.rs
  • crates/biome_js_analyze/src/lint/a11y/use_media_caption.rs
  • crates/biome_js_analyze/src/lint/a11y/use_semantic_elements.rs
  • crates/biome_js_analyze/src/lint/a11y/use_valid_anchor.rs
  • crates/biome_js_analyze/src/lint/a11y/use_valid_aria_props.rs
  • crates/biome_js_analyze/src/lint/a11y/use_valid_aria_role.rs
  • crates/biome_js_analyze/src/lint/a11y/use_valid_aria_values.rs
  • crates/biome_js_analyze/src/lint/a11y/use_valid_autocomplete.rs
  • crates/biome_js_analyze/src/lint/a11y/use_valid_lang.rs
  • crates/biome_js_analyze/src/lint/correctness/no_precision_loss.rs
  • crates/biome_js_analyze/src/lint/nursery/no_inline_styles.rs
  • crates/biome_js_analyze/src/lint/nursery/use_control_label.rs
  • crates/biome_js_analyze/src/lint/nursery/use_iframe_sandbox.rs
  • crates/biome_js_analyze/src/lint/style/no_vue_options_api.rs
  • crates/biome_js_analyze/src/lint/style/use_consistent_curly_braces.rs
  • crates/biome_js_analyze/src/lint/style/use_for_of.rs
  • crates/biome_js_analyze/src/lint/style/use_nodejs_import_protocol.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The change adds upstream ESLint rule-source mappings across accessibility and other lint rules. It adds unsupported-rule classifications and plugin-name recognition for Astro and Markdown. Migration tests and fixtures cover additional rules and scope options.

Suggested reviewers: ematipico

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 37d06

The Shadcn rule migrates when nursery migration is enabled. No actionable merge-blocking issue remains after normal checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the rule metadata updates, though it does not specify the ESLint scope decisions.
Description check ✅ Passed The description refers to the scope decisions and reports that CI is green. It is brief but related to the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 7.66%

❌ 1 regressed benchmark
✅ 266 untouched benchmarks
⏩ 137 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ synthetic/svelte-directives.svelte[uncached] 2.2 ms 2.4 ms -7.66%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dyc3/update-unsupported-rules-71-rules-thr_shj56izvw5 (37d064e) with main (dd96b11)

Open in CodSpeed

Footnotes

  1. 137 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@dyc3 dyc3 changed the title fix(cli): apply upstream lint rule scope decisions chore: update rule metadata Oct 3, 2026
@dyc3
dyc3 merged commit a308196 into main Oct 3, 2026
43 checks passed
@dyc3
dyc3 deleted the dyc3/update-unsupported-rules-71-rules-thr_shj56izvw5 branch October 3, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Linter Area: linter L-HTML Language: HTML and super languages L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant