Skip to content

Fixing high-dimensional resampling - #90

Merged
bmcfee merged 5 commits into
mainfrom
axis-above-1
Jun 17, 2022
Merged

bmcfee merged 5 commits into
mainfrom
axis-above-1

Conversation

@bmcfee

@bmcfee bmcfee commented Jun 17, 2022 •

Copy link
Copy Markdown
Owner

This PR should resolve #73 , and provides a few other simplifications and cleanups within the code algorithm.

It bumps the minimal numpy to 1.17 (for improved zeros_like behavior) and numba to 0.41 (mainly due to availability on conda-forge).

It also adds a minimal CI environment for our oldest dependency versions. In setting this up, I realized that we don't really need scipy at runtime, so I've made it a test-only dependency. This isn't a huge change (default filter is now Hann instead of Blackman-Harris; the default is not used by the user-facing API though), and I expect that anyone using resampy will have scipy anyway. The reason to drop it as a dependency is that it simplifies our minimal version spec.

@codecov-commenter

codecov-commenter commented Jun 17, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #90 (a339164) into main (0a44472) will decrease coverage by 0.88%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   83.49%   82.60%   -0.89%     
==========================================
  Files           4        4              
  Lines         103       92      -11     
==========================================
- Hits           86       76      -10     
+ Misses         17       16       -1     
Flag Coverage Δ
unittests 82.60% <80.00%> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
resampy/filters.py 78.37% <0.00%> (-0.57%) ⬇️
resampy/core.py 83.33% <100.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a44472...a339164. Read the comment docs.

@bmcfee
bmcfee merged commit be533f7 into main Jun 17, 2022
@bmcfee
bmcfee deleted the axis-above-1 branch June 17, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resample fails on axis >1

2 participants