Skip to content

chore: more comments about reverse_proxy buffering and add new tests - #6778

Merged
mholt merged 2 commits into
masterfrom
rp-buffer-test
Mar 7, 2025
Merged

mholt merged 2 commits into
masterfrom
rp-buffer-test

Conversation

@WeidiDeng

Copy link
Copy Markdown
Member

While fixing 6757, it's found that this pr set the wrong Content-Length when buffering. Add new tests to prevent this type of issue when refactoring buffering later.

@mholt mholt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements to the comments, I think this is important, so I appreciate it!

@mholt
mholt merged commit 220cd1c into master Mar 7, 2025
@mholt
mholt deleted the rp-buffer-test branch March 7, 2025 18:22
@mholt mholt added this to the v2.10.0-beta.2 milestone Mar 7, 2025
mohammed90 pushed a commit to cedricziel/caddy that referenced this pull request Aug 29, 2025
…erver#6778)

Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants