Repository navigation
Add error handling for unrecognized subdirective/options - #6884
Merged
mohammed90 merged 2 commits intoMar 8, 2025
Merged
Conversation
mohammed90
approved these changes
Mar 8, 2025
mohammed90
left a comment
Member
There was a problem hiding this comment.
Thank you! I played with the exhaustive linter config in golangci-lint, and it apparently cannot catch these cases. It can only identify them when the switch is over enums. Sigh.
Thanks for helping with this!
Member
|
Yep this is good, thank you! |
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6863