feat(mcp): Allow toggle MCPs on/off by BrunoKrugel · Pull Request #3725 · charmbracelet/crush

BrunoKrugel · 2026-09-05T14:00:20Z

This PRs adds a new menu option that allows the user to enable and disable MCPs on demand (saved per repository, not globally).

When we disable/enable any MCP we also have a toast with status:

Closes #3234

I have read CONTRIBUTING.md.
I have created a discussion that was approved by a maintainer (for new features).

andrinoff · 2026-09-05T15:32:04Z

Hm.. I'm thinking maybe there would be a switch, like in model picker to choose between disabling/enabling globally and locally?

How do you like that idea? (Anyone can discuss this)

BrunoKrugel · 2026-09-07T16:09:53Z

Hm.. I'm thinking maybe there would be a switch, like in model picker to choose between disabling/enabling globally and locally?

How do you like that idea? (Anyone can discuss this)

This switch? I like the idea

andrinoff · 2026-09-09T07:02:53Z

yes!

BrunoKrugel · 2026-09-11T08:59:39Z

yes!

still wip, but already working

BrunoKrugel · 2026-09-14T14:21:52Z

@andrinoff can you review this when you have time?

andrinoff

Also, disabling a MCP that requires auth results in MCP asking to auth. It should only disable it

andrinoff

For UI review: @meowgorithm

meowgorithm · 2026-09-22T21:47:32Z

You rock, Bruno. And really solid suggestions, Drew.

Small UX requests

Let's use the same status dots here we see in the UI:
When MCPs are in a starting state drop the periods of ellipsis: "starting…" should be just "starting". The text is less jumpy between transitions that way.

And after this this we should also do this for skills and tools too.

BrunoKrugel · 2026-09-22T22:03:30Z

And after this this we should also do this for skills and tools too.

Yep, its on my TODO list

BrunoKrugel · 2026-09-22T22:26:29Z

Small UX requests

Let's use the same status dots here we see in the UI:

When MCPs are in a starting state drop the periods of ellipsis: "starting…" should be just "starting". The text is less jumpy between transitions that way.

Done, updated the first post with the updated image.

BrunoKrugel · 2026-09-25T16:19:38Z

@meowgorithm we good with the UX or do we need more adjustments?

meowgorithm · 2026-09-27T23:44:50Z

We're good to go! @andrinoff, if this looks good to you let’s merge it!

/cc @gurnben

@KevinFumbles

* ui: add mouse support to the quit dialogue * ui: keep quit dialog buttons visible in small terminals * ui: align quit dialog button hit regions with centered row * ui: report all mouse motion while hoverable dialogs are open * ui: cover quit dialog mouse buttons and hover reporting in tests * chore(legal): @KevinFumbles has signed the CLA * chore(legal): @djbclark has signed the CLA * chore(legal): @wcqqq1214 has signed the CLA * chore(legal): @Souptik96 has signed the CLA * chore(legal): @alyraffauf has signed the CLA * test(server): stop a timing race from failing a fire-and-forget test (charmbracelet#3967) * chore(legal): @valdepeace has signed the CLA * chore(legal): @vitolee-1018 has signed the CLA * feat(mcp): Allow toggle MCPs on/off (charmbracelet#3725) * chore: auto-update files * fix: reorder migrations * feat(tui): display git branch (charmbracelet#2437) Co-authored-by: Kieran Klukas <kieran@dunkirk.sh> Co-authored-by: drew <me@andrinoff.com> Signed-off-by: drew <me@andrinoff.com> * v0.97.0 Signed-off-by: drew <me@andrinoff.com> * fix: remove the powerline symbol Signed-off-by: drew <me@andrinoff.com> * v0.97.1 Signed-off-by: drew <me@andrinoff.com> * chore(legal): @Shub3am has signed the CLA * chore(legal): @raytorresch has signed the CLA * server: add support for git branches * refactor(ui): poll the git branch off the render path Reading the branch was wired into the three places that render it, so a redraw could kick off a network request as a side effect and the value had to be guarded by its own mutex, in-flight flag, and expiry. The TUI already has a pattern for header data that has to be fetched: a ticker sends a poll message, a command does the work with its own timeout, and the result lands in model state that views read plainly. The Hyper credits balance is fetched this way and is passed into the header alongside what this now passes. Moving the branch onto that path drops the second cache entirely. With no caller left asking once per frame, the cache inside the git helper had nothing to protect either, and removing it also removes the stale window where a client could show a branch two expiries out of date. Asking for the branch now names its cost: it takes a context and can fail, which is honest for something that crosses the network in client/server mode. * perf(prompt): read the current git branch without spawning a shell * test: remove signing off of the branch test (charmbracelet#3999) Signed-off-by: drew <me@andrinoff.com> * chore(legal): @0-wiz-0 has signed the CLA * fix(ui): stop the attachment row from claiming files that are visible On a narrow editor the row budgeted every attachment chip at the widest filename it allows rather than the width it actually needs, so a single short-named file was counted as overflowing its own row and got an unstyled "1 more…" tacked on beside it, promising a file already on screen. Chips are now measured as they are laid out, the hint counts only what was left out, and it is drawn with a theme style. When the row has space for just one chip, that chip now gives up filename width so the hint can stay, rather than dropping the count and leaving several attached files looking like one. The name is trimmed down to a floor; past it the name would be mostly ellipsis and identify nothing, so the hint gives way instead. The renderer's style constructor also took seven positional arguments of the same type, so adding the hint's style meant editing eight files and the compiler could not have caught a transposition. Those styles now travel as one named value. --------- Signed-off-by: drew <me@andrinoff.com> Co-authored-by: Christian Rocha <christian@rocha.is> Co-authored-by: Charm <124303983+charmcli@users.noreply.github.com> Co-authored-by: Kieran Klukas <kieran@dunkirk.sh> Co-authored-by: Bruno Krugel <brunokrugel@gmail.com> Co-authored-by: Gustave <2909789120@qq.com> Co-authored-by: drew <me@andrinoff.com> Co-authored-by: Drew Smirnoff <drew@charm.land>

@KevinFumbles

* ui: add mouse support to the quit dialogue * ui: keep quit dialog buttons visible in small terminals * ui: align quit dialog button hit regions with centered row * ui: report all mouse motion while hoverable dialogs are open * ui: cover quit dialog mouse buttons and hover reporting in tests * chore(legal): @KevinFumbles has signed the CLA * chore(legal): @djbclark has signed the CLA * chore(legal): @wcqqq1214 has signed the CLA * chore(legal): @Souptik96 has signed the CLA * chore(legal): @alyraffauf has signed the CLA * test(server): stop a timing race from failing a fire-and-forget test (charmbracelet#3967) * chore(legal): @valdepeace has signed the CLA * chore(legal): @vitolee-1018 has signed the CLA * feat(mcp): Allow toggle MCPs on/off (charmbracelet#3725) * chore: auto-update files * fix: reorder migrations * feat(tui): display git branch (charmbracelet#2437) Co-authored-by: Kieran Klukas <kieran@dunkirk.sh> Co-authored-by: drew <me@andrinoff.com> Signed-off-by: drew <me@andrinoff.com> * v0.97.0 Signed-off-by: drew <me@andrinoff.com> * fix: remove the powerline symbol Signed-off-by: drew <me@andrinoff.com> * v0.97.1 Signed-off-by: drew <me@andrinoff.com> * chore(legal): @Shub3am has signed the CLA * chore(legal): @raytorresch has signed the CLA * server: add support for git branches * refactor(ui): poll the git branch off the render path Reading the branch was wired into the three places that render it, so a redraw could kick off a network request as a side effect and the value had to be guarded by its own mutex, in-flight flag, and expiry. The TUI already has a pattern for header data that has to be fetched: a ticker sends a poll message, a command does the work with its own timeout, and the result lands in model state that views read plainly. The Hyper credits balance is fetched this way and is passed into the header alongside what this now passes. Moving the branch onto that path drops the second cache entirely. With no caller left asking once per frame, the cache inside the git helper had nothing to protect either, and removing it also removes the stale window where a client could show a branch two expiries out of date. Asking for the branch now names its cost: it takes a context and can fail, which is honest for something that crosses the network in client/server mode. * perf(prompt): read the current git branch without spawning a shell * test: remove signing off of the branch test (charmbracelet#3999) Signed-off-by: drew <me@andrinoff.com> * chore(legal): @0-wiz-0 has signed the CLA * fix(ui): stop the attachment row from claiming files that are visible On a narrow editor the row budgeted every attachment chip at the widest filename it allows rather than the width it actually needs, so a single short-named file was counted as overflowing its own row and got an unstyled "1 more…" tacked on beside it, promising a file already on screen. Chips are now measured as they are laid out, the hint counts only what was left out, and it is drawn with a theme style. When the row has space for just one chip, that chip now gives up filename width so the hint can stay, rather than dropping the count and leaving several attached files looking like one. The name is trimmed down to a floor; past it the name would be mostly ellipsis and identify nothing, so the hint gives way instead. The renderer's style constructor also took seven positional arguments of the same type, so adding the hint's style meant editing eight files and the compiler could not have caught a transposition. Those styles now travel as one named value. --------- Signed-off-by: drew <me@andrinoff.com> Co-authored-by: Christian Rocha <christian@rocha.is> Co-authored-by: Charm <124303983+charmcli@users.noreply.github.com> Co-authored-by: Kieran Klukas <kieran@dunkirk.sh> Co-authored-by: Bruno Krugel <brunokrugel@gmail.com> Co-authored-by: Gustave <2909789120@qq.com> Co-authored-by: drew <me@andrinoff.com> Co-authored-by: Drew Smirnoff <drew@charm.land>

共 4 个上游提交： - a9a257c feat(mcp): Allow toggle MCPs on/off (charmbracelet#3725) - 1f3827b fix: reorder migrations - 06e50a3 chore: auto-update files - 056387b chore(legal): CLA 迁移文件与本地允许乱序迁移的补丁并存，无重名冲突。

github-actions Bot added the area: mcp label Sep 5, 2026

andrinoff self-assigned this Sep 9, 2026

BrunoKrugel force-pushed the feat/toggleMcp branch from 4024362 to 50ff82f Compare September 14, 2026 14:08

andrinoff requested changes Sep 14, 2026

View reviewed changes

Comment thread internal/db/connect.go Outdated

Comment thread internal/config/docker_mcp.go Outdated

Comment thread internal/config/docker_mcp.go Outdated

BrunoKrugel requested a review from andrinoff September 14, 2026 19:40

andrinoff approved these changes Sep 15, 2026

View reviewed changes

BrunoKrugel force-pushed the feat/toggleMcp branch 2 times, most recently from 27b8314 to 8d54273 Compare September 21, 2026 09:23

BrunoKrugel force-pushed the feat/toggleMcp branch from 6f84064 to 21e323b Compare September 22, 2026 23:02

BrunoKrugel added 6 commits September 25, 2026 10:48

toggle mcp feature

475401e

global and local scopes

77d67e6

fix comments

e67b700

skip oauth servers

a54a634

fix

642f97e

Update mcp_toggles.go

c598c32

BrunoKrugel force-pushed the feat/toggleMcp branch from 21e323b to c598c32 Compare September 25, 2026 14:02

andrinoff merged commit a9a257c into charmbracelet:main Sep 28, 2026
15 checks passed

BrunoKrugel deleted the feat/toggleMcp branch September 28, 2026 11:03

gurnben mentioned this pull request Sep 28, 2026

fix(db): apply out-of-order migrations instead of refusing to start #3984

Closed

andikapradanaarif mentioned this pull request Oct 1, 2026

merge: upstream/main v0.97.1 into fork andikapradanaarif/crush#202

Merged

2 of 3 tasks

joestump mentioned this pull request Oct 9, 2026

chore: sync fork with charmbracelet/crush upstream (171 commits) joestump-agent/crush#574

Merged

dyoshikawa mentioned this pull request Oct 18, 2026

Follow up Crush upstream updates: MCP channel keys (channel_enabled / channel_reply) dropped on generate dyoshikawa/rulesync#3523

Closed

andrinoff mentioned this pull request Oct 26, 2026

MCP Management in TUI #3791

Closed

Conversation

BrunoKrugel commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrinoff commented Sep 5, 2026

Uh oh!

BrunoKrugel commented Sep 7, 2026

Uh oh!

andrinoff commented Sep 9, 2026

Uh oh!

BrunoKrugel commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BrunoKrugel commented Sep 14, 2026

Uh oh!

andrinoff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrinoff left a comment

Choose a reason for hiding this comment

Uh oh!

meowgorithm commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BrunoKrugel commented Sep 22, 2026

Uh oh!

BrunoKrugel commented Sep 22, 2026

Uh oh!

BrunoKrugel commented Sep 25, 2026

Uh oh!

meowgorithm commented Sep 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BrunoKrugel commented Sep 5, 2026 •

edited

Loading

BrunoKrugel commented Sep 11, 2026 •

edited

Loading

meowgorithm commented Sep 22, 2026 •

edited

Loading