Repository navigation
Enhance nodegroup config Pin icon control logic - #304
Merged
Merged
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors the NodeGroup “pin” (region marker) logic by removing the per-action marker mutation codepaths and replacing them with a single renderMapFromConfig() function that rebuilds marker state from the current NodeGroup configuration.
Changes:
- Replaced incremental marker updates (
addRegionMarker,cspPointsCircle.pop/splice,geoCspPointsCirclemutations) with a centralizedrenderMapFromConfig()refresh. - Triggered map re-rendering after key NodeGroup lifecycle events (clear, add/edit, cancel/fail, remove, alternative config, copy config).
- Extended
copyInfraConfig()’srecommendedSpecListentries to include region latitude/longitude fields for map rendering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine separated Pin location controls into one.