Repository navigation
Support both NVIDIA and AMD for GPU driver install - #311
Merged
Merged
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Updates the MapUI predefined remote commands and UI labels so the “Install GPU Driver” flow supports both NVIDIA and AMD GPUs by relying on an auto-detecting install script and by expanding the driver status check logic.
Changes:
- Update the “Nvidia” install command messaging to reflect NVIDIA/AMD auto-detection and add AMD verification guidance.
- Extend “Nvidia-Status” to attempt AMD tooling (ROCm) when NVIDIA tooling isn’t present, and add AMD monitoring support.
- Update predefined script labels across LLM and Kubernetes categories to reflect NVIDIA/AMD support.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Check GPU driver status — tries NVIDIA first, then AMD ROCm | ||
| // rocm-smi exits with code 1 on some ROCm versions due to a Python 'violation' attribute bug | ||
| // even when GPU info is shown correctly — suppress with || true | ||
| defaultRemoteCommand[0] = "if command -v nvidia-smi &>/dev/null; then nvidia-smi; elif command -v rocm-smi &>/dev/null; then rocm-smi || true; else echo '[WARN] No GPU CLI tool found (nvidia-smi / rocm-smi). Is the driver installed and system rebooted?'; sudo lspci | grep -i -E 'vga|3d|display' || true; fi"; |
| // even when GPU info is shown correctly — suppress with || true | ||
| defaultRemoteCommand[0] = "if command -v nvidia-smi &>/dev/null; then nvidia-smi; elif command -v rocm-smi &>/dev/null; then rocm-smi || true; else echo '[WARN] No GPU CLI tool found (nvidia-smi / rocm-smi). Is the driver installed and system rebooted?'; sudo lspci | grep -i -E 'vga|3d|display' || true; fi"; | ||
| // NVIDIA: show Fabric Manager on multi-GPU NVSwitch systems; AMD: show amd-smi monitor | ||
| defaultRemoteCommand[1] = "if command -v nvidia-smi &>/dev/null; then GPU_COUNT=$(nvidia-smi -L 2>/dev/null | grep -c '^GPU') || GPU_COUNT=0; if [ \"$GPU_COUNT\" -ge 4 ]; then echo '=== Fabric Manager (required for NVSwitch multi-GPU) ==='; systemctl is-active nvidia-fabricmanager 2>/dev/null && echo 'Status: RUNNING' || echo 'Status: NOT RUNNING (multi-GPU may not work!)'; echo '=== nvidia-persistenced ==='; systemctl is-active nvidia-persistenced 2>/dev/null && echo 'Status: RUNNING' || echo 'Status: not running'; fi; elif command -v amd-smi &>/dev/null; then amd-smi monitor || true; fi"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.