Skip to content

Group some string vars into string array #705

Closed

Description

@jihoon-seo

What would you like to be enhanced
:
Group some string vars into string array.

Why is this needed
:

Proposed solution
:

[As-is]
src/core/mcis/control.go

const sshDefaultUserName01 string = "cb-user"
const sshDefaultUserName02 string = "ubuntu"
const sshDefaultUserName03 string = "root"
const sshDefaultUserName04 string = "ec2-user"

...

	userNames := []string{
		userName,
		givenUserName,
		sshDefaultUserName01,
		sshDefaultUserName02,
		sshDefaultUserName03,
		sshDefaultUserName04,
	}

[To-be]

var sshDefaultUsername = []string{"cb-user", "ubuntu", "root", "ec2-user"}

...

	userNames := []string{
		userName,
		givenUserName,
		sshDefaultUsername[0],
		sshDefaultUsername[1],
		sshDefaultUsername[2],
		sshDefaultUsername[3],
	}

Activity

  1. HassanAlsamahi commented on Sep 10, 2021

    @HassanAlsamahi
    Contributor

    Can I be assigned to this ?

  2. seokho-son commented on Sep 10, 2021

    @seokho-son
    Member

    Sure ! @HassanAlsamahi :)

  3. seokho-son commented on Sep 10, 2021

    @seokho-son
    Member
  4. added a commit that references this issue on Sep 11, 2021
  5. seokho-son commented on Sep 13, 2021

    @seokho-son
    Member

    /close

  6. linked a pull request that will close this issueGroup strings #705 #725on Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions