Skip to content

Remove duplicated script create-single-vm-mcis.sh - #1058

Merged
jihoon-seo merged 1 commit into
cloud-barista:mainfrom
seokho-son:main
Apr 8, 2022
Merged

jihoon-seo merged 1 commit into
cloud-barista:mainfrom
seokho-son:main

Conversation

@seokho-son

Copy link
Copy Markdown
Member

fix #1037

@seokho-son
seokho-son requested a review from jihoon-seo as a code owner April 7, 2022 05:44
@seokho-son

Copy link
Copy Markdown
Member Author

@jihoon-seo 참고,

CB-TB 에는 https://github.com/cloud-barista/cb-tumblebug/blob/main/CODEOWNERS 를 사용하고 있고,

prow-for-cloud-barista 은 OWNERS 를 확인하려고 하네요.

https://github.com/cloud-barista/cb-tumblebug/blob/main/OWNERS
이거 아마도 자체 스타일의 코드오너 파일을 사용하는 거라, github-native한 CODEOWNERS 랑 조금 다르게 생겼을거예요.
https://github.com/kubernetes/website/blob/main/OWNERS

@jihoon-seo jihoon-seo added lgtm This PR is acceptable by at least one reviewer approved This PR is approved and will be merged soon. labels Apr 8, 2022
@prow-for-cloud-barista

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@prow-for-cloud-barista

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jihoon-seo
jihoon-seo merged commit 034a5b0 into cloud-barista:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This PR is approved and will be merged soon. lgtm This PR is acceptable by at least one reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete dup test script: create-single-vm-mcis.sh

2 participants