Repository navigation
Tidy TbNLBReq fields - #1197
Merged
seokho-son merged 1 commit intoOct 13, 2022
Merged
Tidy TbNLBReq fields#1197
TbNLBReq fields#1197Conversation
|
This pull request introduces 1 alert when merging dd8be67 into abe3d71 - view on LGTM.com new alerts:
|
jihoon-seo
force-pushed
the
221013_Tidy_TbNLBReq_fields
branch
from
October 13, 2022 04:03
dd8be67 to
ba2289b
Compare
Member
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was
linked to
issues
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listener,HealthChecker,VMGroup/TargetGroup) 을공유하여 활용하던 부분이 있었는데
이를 SP ↔ TB // Req ↔ Info 간 대부분 분리했습니다.
src/testclient/scripts/10.nlb/create-NLB.sh의 diff 참조)name:targetGroup.vmGroupId필드의 값을 그대로 활용합니다.connectionName: 사용자가 명시한 TB VMGroup에 속한 VM에 기재되어 있는 값을 활용합니다.vNetId: 사용자가 명시한 TB VMGroup에 속한 VM에 기재되어 있는 값을 활용합니다.listener.DNSName은 불필요한 필드였습니다. 따라서 테스트 스크립트에서 삭제했습니다.HealthChecker의Protocol&Port는 논리상targetGroup의 그것들과 동일해야 하므로,Req 의
HealthChecker에서는 해당 필드를 삭제하고targetGroup의Protocol&Port필드의 값을 그대로 활용하도록 변경했습니다.