Repository navigation
Add omitted error handling - #828
Merged
seokho-son merged 2 commits intoOct 10, 2021
Merged
Conversation
computerphilosopher
requested review from
jihoon-seo and
seokho-son
as code owners
October 4, 2021 10:04
Member
|
PTAL @jihoon-seo :) |
jihoon-seo
reviewed
Oct 5, 2021
jihoon-seo
left a comment
jihoon-seo
left a comment
Member
There was a problem hiding this comment.
@computerphilosopher 문제점 발견 및 PR 감사합니다. 😊
comment 를 작성해 보았습니다.
확인 부탁드립니다. 😊
Member
|
/lgtm |
seokho-son
approved these changes
Oct 10, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이전 코드에서는 원하는 리소스가 없는 경우와, 찾는 과정에서 에러가 생긴 경우가 구분이 되지 않습니다.
따라서 에러 핸들링을 추가하였습니다.