Skip to content

Delete gen-sshKey-withGivenMcisName.sh replaced by gen-sshKey.sh - #870

Merged
seokho-son merged 1 commit into
cloud-barista:mainfrom
leedohun:remove-gen-sshKey-with-GivenMcisName
Oct 14, 2021
Merged

seokho-son merged 1 commit into
cloud-barista:mainfrom
leedohun:remove-gen-sshKey-with-GivenMcisName

Conversation

@leedohun

Copy link
Copy Markdown
Contributor

#842 good first issue
remove-gen-sshKey-with-GivenMcisName.sh 파일을 gen-sshKey.sh로 대체하여 사용하기 때문에 더이상 사용하지 않는 remove-gen-sshKey-with-GivenMcisName.sh 파일을 삭제

@seokho-son

Copy link
Copy Markdown
Member

Delete gen-sshKey-withGivenMcisName.sh replaced by gen-sshKey.sh

unknown committed 21 minutes ago

@leedohun 커밋 저자가 unknown 이라고 되어 있는데 ~
이건.. git 에서 username 이랑 email 설정이 안되어 있어서 그래요 ^^
혹시 수정해보시려나요? ^^

  • git 에서 사용자명 설정하시고~~
  • git commit --amend --author="John Doe john@doe.org"

이런식으로 하시면 될거예용 ^^

commit 히스토리가 변경되면~ origin에 push 했을 때, 거부 당하므로, 그떄는 -f 옵션으로 강제 푸시하시면 되구요~~

@seokho-son

Copy link
Copy Markdown
Member

일단 내용 자체는 LGTM입니다~!

@leedohun
leedohun force-pushed the remove-gen-sshKey-with-GivenMcisName branch from 385209a to e948179 Compare October 14, 2021 13:54
@leedohun

Copy link
Copy Markdown
Contributor Author

git 세팅을 다시하고 push를 보냈습니다. 한번 확인 해 주실 수 있으신가요??

@seokho-son

Copy link
Copy Markdown
Member

Delete gen-sshKey-withGivenMcisName.sh replaced by gen-sshKey.sh e948179

@leedohun leedohun committed 2 hours ago

잘 정리되었네요!! 감사합니다~~! :)

@seokho-son

Copy link
Copy Markdown
Member

/lgtm

@github-actions github-actions Bot added the lgtm This PR is acceptable by at least one reviewer label Oct 14, 2021
@seokho-son
seokho-son merged commit 4eccafa into cloud-barista:main Oct 14, 2021
@seokho-son seokho-son added the hacktoberfest-accepted hacktoberfest-accepted label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted hacktoberfest-accepted lgtm This PR is acceptable by at least one reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants