Repository navigation
Prevent deletion of obj in use - #946
Merged
seokho-son merged 1 commit intoNov 9, 2021
Merged
seokho-son merged 1 commit into
seokho-son merged 1 commit into
Conversation
Member
|
@jihoon-seo 감사합니다~~ deleteAll 에서 해당 delete 함수의 기능을 가져와서 사용하도록 하는게 맞겠네요.. ^^ |
seokho-son
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DelResource()too #945이 PR로 인해,
DelAllResources호출 시 다음과 같이 동작합니다.resourceType(예: vNet) 에 대해resourceIdList추출resourceIdList의 각v(예:vnet-01) 에 대해,GetAssociatedObjectList조회하고,DelResource호출DelResource함수 안에서GetAssociatedObjectList조회즉,
DelAllResources함수에서3. GetAssociatedObjectList 조회하고,와a. DelResource 함수 안에서 GetAssociatedObjectList 조회가 중복입니다.Optional:
DelAllResources함수에서3. GetAssociatedObjectList 조회하고,를 삭제할 수도 있겠습니다. 😊