Skip to content

fix identity transform stream resolve/state change order - #7297

Merged
mikea merged 1 commit into
mainfrom
maizatskyi/2026-09-09-identity-transformer-stream
Sep 10, 2026
Merged

mikea merged 1 commit into
mainfrom
maizatskyi/2026-09-09-identity-transformer-stream

Conversation

@mikea

@mikea mikea commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Resolving before changing state makes wrong state obsservable.

@mikea
mikea requested review from a team as code owners September 9, 2026 18:41
@ask-bonk

ask-bonk Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@mikea Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@mikea
mikea requested a review from jasnell September 9, 2026 19:18

@jasnell jasnell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please make sure there are no conflicts with #7183 ... I'm hoping to get that landed shortly

@ask-bonk

ask-bonk Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@mikea

mikea commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

LGTM but please make sure there are no conflicts with #7183 ... I'm hoping to get that landed shortly

as far as I can tell we don't touch same files?

@mikea
mikea force-pushed the maizatskyi/2026-09-09-identity-transformer-stream branch from 00e7470 to d6c6416 Compare September 10, 2026 15:03
@mikea
mikea enabled auto-merge September 10, 2026 15:03
@mikea
mikea merged commit 5f2bdd8 into main Sep 10, 2026
22 checks passed
@mikea
mikea deleted the maizatskyi/2026-09-09-identity-transformer-stream branch September 10, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants