build: finish narrowing kj-async deps to the layer each target uses - #7379
Merged
Merged
Conversation
git-bruh
approved these changes
Sep 15, 2026
Follow-up to ef476ab, which left four edges on the @capnp-cpp//src/kj:kj-async umbrella that do not need it: //src/workerd/server's alarm-scheduler-test, the bench-try-sync benchmark, //src/rust/worker's test and //src/rust/cxx-integration-test only use kj promises and the abstract stream interfaces, so they now depend on kj-async-core and kj-async-io. The umbrella additionally carries kj-async-os (the UnixEventPort / OS socket layer); the remaining umbrella users are the callers of kj::setupAsyncIo() or includers of kj/async-unix.h (the workerd binary, :server, :fallback-service and its test, json-logger-test, test-fixture, incoming-request-test), which genuinely need it. No source changes; the linked binaries are unchanged. Split out of the Rust I/O backend wiring (#7328), where that change only has to touch the setupAsyncIo() seam. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
danlapid
force-pushed
the
dlapid/kj-async-deps
branch
from
September 15, 2026 20:11
0dcb0cd to
3770deb
Compare
danlapid
enabled auto-merge (rebase)
September 15, 2026 20:12
Contributor
|
@danlapid Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to ef476ab, which left four edges on the @capnp-cpp//src/kj:kj-async
umbrella that do not need it: //src/workerd/server's alarm-scheduler-test, the
bench-try-sync benchmark, //src/rust/worker's test and
//src/rust/cxx-integration-test only use kj promises and the abstract stream
interfaces, so they now depend on kj-async-core and kj-async-io. The umbrella
additionally carries kj-async-os (the UnixEventPort / OS socket layer); the
remaining umbrella users are the callers of kj::setupAsyncIo() or includers of
kj/async-unix.h (the workerd binary, :server, :fallback-service and its test,
json-logger-test, test-fixture, incoming-request-test), which genuinely need it.
No source changes; the linked binaries are unchanged. Split out of the Rust I/O
backend wiring (#7328), where that change only has to touch the setupAsyncIo()
seam.
🤖 Generated with Claude Code