Skip to content

fix compile_flags.txt - #7415

Merged
mikea merged 2 commits into
mainfrom
maizatskyi/2026-09-17-clangd
Sep 17, 2026
Merged

mikea merged 2 commits into
mainfrom
maizatskyi/2026-09-17-clangd

Conversation

@mikea

@mikea mikea commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mikea
mikea requested review from a team as code owners September 17, 2026 16:43

@npaun npaun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like the little test script.

@danlapid danlapid left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for messing it up

Comment thread justfile Outdated
@ask-bonk

ask-bonk Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Adds missing clangd include paths and a compile-flags validation recipe.

  1. Medium: justfile:52 hard-codes unavailable clangd-22, preventing the new check from running in supported setups. Posted one inline suggestion.

github run

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
@mikea
mikea enabled auto-merge September 17, 2026 16:48
@mikea
mikea merged commit 92b0c1d into main Sep 17, 2026
23 checks passed
@mikea
mikea deleted the maizatskyi/2026-09-17-clangd branch September 17, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants