Skip to content

[feature] Another change to CMakePresets naming #11705

Closed

Description

@mpusz

Right now the CMake Preset configuration is named with a small first letter (i.e. release, debug, ...). However, conan install requires the first letter to be uppercase for build_type. This makes build scripting a lot harder.

Example:

conan install . -s build_type=Release
cmake --preset release
cmake --build --preset release

The above is inconsistent and cannot easily work with variables provided by the CI services. It would be much better if for i.e. GitHub actions we could do something like that:

conan install . -s build_type=${{ matrix.build_type }}
cmake --preset ${{ matrix.build_type }}
cmake --build --preset ${{ matrix.build_type }}

Activity

  1. lasote commented on Jul 27, 2022

    @lasote
    Contributor

    I think it is better to keep the names lowercase, when the name is composed with other settings/options (e.g apple-clang-shared_true) the name is very weird and easy to mistype otherwise.
    I would say any CI scripting should have a lowercase() function available, otherwise an issue should be open on it.

  2. mpusz commented on Jul 27, 2022

    @mpusz
    Author

    I can live with that 😉 Just wanted to ensure it was discussed.

  3. mpusz commented on Jul 27, 2022

    @mpusz
    Author

    Actually it seems it is not that easy on GitHub actions: community/community#10553 😢

  4. lasote commented on Jul 28, 2022

    @lasote
    Contributor

    Yeah, upvoted. 👍🏼

  5. lasote commented on Jul 28, 2022

    @lasote
    Contributor

    I'm closing this for now, thanks for your help trying the presets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions