Skip to content

fix required kunalkushwaha error - #2004

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
wswsmao:fixci
Mar 7, 2025
Merged

AkihiroSuda merged 1 commit into
containerd:mainfrom
wswsmao:fixci

Conversation

@wswsmao

@wswsmao wswsmao commented Mar 5, 2025 •

Copy link
Copy Markdown
Contributor

update project-checks to v1.2.2 to fix this error in CI, It seems to be the same issue as containerd/nerdctl#3976,
cc @AkihiroSuda

  • before updating to v1.2.2
  github.com/hashicorp/go-version
  github.com/sirupsen/logrus
  github.com/vbatts/git-validation/git
  github.com/vbatts/git-validation/validate
  github.com/vbatts/git-validation/rules/danglingwhitespace
  github.com/vbatts/git-validation/rules/dco
  github.com/vbatts/git-validation/rules/shortsubject
  github.com/vbatts/git-validation/rules/messageregexp
  github.com/vbatts/git-validation
  go: downloading github.com/kunalkushwaha/ltag v0.3.0
  go: github.com/kunalkushwaha/ltag@latest: version constraints conflict:
  	github.com/kunalkushwaha/ltag@v0.3.0: parsing go.mod:
  	module declares its path as: github.com/containerd/ltag
  	        but was required as: github.com/kunalkushwaha/ltag
  Error: Process completed with exit code 1.
  • after updating to v1.2.2 and not go-licenses-ignore
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/errorutil
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/externaltoc
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/zstdchunked
Not allowed license MPL-2.0 found for library github.com/hashicorp/go-cleanhttp
Not allowed license MPL-2.0 found for library github.com/hashicorp/go-retryablehttp

- uses: containerd/project-checks@v1.2.2
with:
working-directory: src/github.com/containerd/stargz-snapshotter
go-licenses-ignore: |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after updating to v1.2.2 and not go-licenses-ignore will report error :

Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/errorutil
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/externaltoc
Not allowed license  found for library github.com/containerd/stargz-snapshotter/estargz/zstdchunked
Not allowed license MPL-2.0 found for library github.com/hashicorp/go-cleanhttp
Not allowed license MPL-2.0 found for library github.com/hashicorp/go-retryablehttp

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this
#2001

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add reasons why these errors can be safely ignored

@wswsmao wswsmao Mar 6, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two packages listed below are licensed under MPL-2.0, which is not included in the allowed-third-party-license-policy.md. Shall we directly use go-licenses-ignore to suppress the related license warnings?

github.com/hashicorp/go-cleanhttp
github.com/hashicorp/go-retryablehttp

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link https://github.com/cncf/foundation/blob/main/license-exceptions/CNCF-licensing-exceptions.csv in the YAML to clarify that these packages are exceptionally allowed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: abushwang <abushwangs@gmail.com>
@wswsmao

wswsmao commented Mar 6, 2025

Copy link
Copy Markdown
Contributor Author

re-push to refresh CI

@wswsmao wswsmao closed this Mar 6, 2025
@wswsmao wswsmao reopened this Mar 6, 2025
@wswsmao

wswsmao commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

all done @AkihiroSuda

@AkihiroSuda AkihiroSuda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
AkihiroSuda merged commit 930e944 into containerd:main Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants