Repository navigation
estargz: Build: replace golang.org/x/sync with WaitGroup.Go (go1.25) - #2249
Merged
Merged
Conversation
each goroutine writes to a distinct index, so it looks like there's no need to use a mutex here. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It was only using minimal functionality of the errgroup (and didn't use, e.g. `errgroup.WithContext`). Rewrite it with a sync.WaitGroup from stdlib. Also update to go1.25 and use WaitGroup.Go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Thx! Rebased 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
estargz: Build: remove redundant mutex
each goroutine writes to a distinct index, so it looks like there's
no need to use a mutex here.
estargz: Build: replace golang.org/x/sync with WaitGroup.Go (go1.25)
It was only using minimal functionality of the errgroup (and didn't
use, e.g.
errgroup.WithContext). Rewrite it with a sync.WaitGroupfrom stdlib.
Also update to go1.25 and use WaitGroup.Go