You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Missing input validation on path and argument inputs #37
While reviewing this action, I identified several input validation gaps that could pose security risks:
toolpath: Used directly without path validation or scope checking. Also uses string concatenation instead of path.join() on line 166, which can break on Windows.
customSettings: Split and pushed into the args array without any format validation, allowing arbitrary argument injection.
Path inputs (targetdir, historydir, sourcedirs, reports): Not validated to stay within the workspace. Absolute paths bypass workingdir entirely, and relative paths with .. can escape the repository root.
plugins: File paths passed directly to -plugins: without validation, which could allow loading untrusted .NET assemblies.
I'd be happy to submit a PR to address these. Would you be open to contributions here?
Hi @danielpalme. If you'd like, I can refactor those sanitization functions out to a sanitize.ts import instead?
We'd like to continue to use your gh action in our project but need some of these areas of concern locked down. So if I can help with a clean refactor, let me know.
Activity
Add input validation and path scope enforcement
danielpalme commentedon Apr 14, 2026
Thanks for your PR. I will have a look at it as soon as possible!
ismits commentedon Apr 15, 2026
Hi @danielpalme. If you'd like, I can refactor those sanitization functions out to a sanitize.ts import instead?
We'd like to continue to use your gh action in our project but need some of these areas of concern locked down. So if I can help with a clean refactor, let me know.
danielpalme commentedon Apr 15, 2026
That would be great! Once this is done, I can publish a new release.
ismits commentedon Apr 15, 2026
Updated. I think this is cleaner and dryer. I didn't update the version stamp since I'm not familiar with your workflow.
Happy to correct anything you don't like.
danielpalme commentedon Apr 15, 2026
Thanks, I will merge and update the version within the next days!
ismits commentedon Apr 15, 2026
Excellent! Really appreciate your responsiveness.
#37 Added input validation and path scope enforcement (contributed by @…
danielpalme commentedon Apr 15, 2026
Release 5.5.5 is now available!
chore(deps): update dependency reportgenerator to 5.5.5 (#582)
chore(deps): update dependency reportgenerator to 5.5.5 (#306)
chore(deps): update dependency dotnet-reportgenerator-globaltool to v…
chore(deps): update dependency reportgenerator to 5.5.5 (#1135)
ismits commentedon Apr 17, 2026
Closing as resolved.
Update dependency dotnet-reportgenerator-globaltool to v5.5.5 (#94)
Bump the packages group with 2 updates (#221)
Bump dotnet-reportgenerator-globaltool from 5.5.4 to 5.5.5 (#1025)
Update dependency dotnet-reportgenerator-globaltool to v5.5.6 (#64)
Bump dotnet-reportgenerator-globaltool from 5.4.4 to 5.5.10 (#109)
[nuget][Find]- Bump Azure.Identity and 26 others (#705)
Bump dotnet-reportgenerator-globaltool from 5.5.1 to 5.5.10 (#70)
Bump dotnet-reportgenerator-globaltool from 5.4.17 to 5.5.11 (#44)
Update dependency dotnet-reportgenerator-globaltool to v5.5.11 (#59)
Update dependency ReportGenerator to 5.5.11 (#60)
Update dependency dotnet-reportgenerator-globaltool to v5.5.11 (#44)
Update dependency ReportGenerator to 5.5.11 (#47)
fix: Bump Azure.Messaging.ServiceBus and 12 others (#256)
build(deps): atualize dependências compatíveis com .NET 8 (#258)