Repository navigation
fix: send long Windows Claude prompts via stdin - #125
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows-specific Claude CLI invocation path to avoid command-line length limits by sending long prompts via stdin, while keeping the existing non-Windows behavior unchanged.
Changes:
- Introduce a
with_prompt_transporthelper to choose between argv vs stdin prompt transport (Windows uses stdin). - Update Claude process spawning to optionally pipe stdin and write the prompt payload to the child process.
- Add frontend + Rust tests covering context label behavior (whole-file vs selection) and the prompt-transport helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/desktop/src/tests/stores/claude-chat-send-prompt.test.ts | Adds Vitest coverage for context label + selected-text assembly in sendPrompt for whole-file vs selection cases. |
| apps/desktop/src-tauri/src/claude.rs | Sends prompts via stdin on Windows to avoid OS error 206; adds helper + unit test and updates process spawn logic accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-pfor Claude CLI, but send the prompt through stdin on Windows instead of placing it on the command lineWhy
On some Windows machines, mentioning a whole file can make the spawned Claude command exceed the command-line length limit and fail with
os error 206. Sending the prompt through stdin avoids that Windows-specific limit without changing the higher-level prompt assembly.Validation
pnpm --filter @claude-prism/desktop test -- claude-chat-send-promptset VCPKGRS_TRIPLET=x64-windows-static-releaseset CXXFLAGS=/std:c++17cargo test with_prompt_transport@filementions no longer fail withos error 206