Skip to content

kubernetes driver: add support for proxy-url - #1780

Merged
crazy-max merged 1 commit into
docker:masterfrom
techvelocity-old:elranshefer/add-support-for-proxy-url
May 11, 2023
Merged

crazy-max merged 1 commit into
docker:masterfrom
techvelocity-old:elranshefer/add-support-for-proxy-url

Conversation

@IamShobe

@IamShobe IamShobe commented May 9, 2023 •

Copy link
Copy Markdown

Hi there :),
Sorry about the previous PR, I opened it prematurely before finalizing all tests, and preparing a proper PR 🙏.
Hopefully, I'm properly following your contribution guidelines, and if I need to change anything please LMK.

This PR attempts to add support in kuberenetes driver for proxy-url config in the KUBECONFIG file -
official docs here.

The PR initializes the k8s client config created in KubernetesConfig receiver method with the right proxy-url parameter.

As a workaround, we were using HTTPS_PROXY env var, but that forces every request that buildx sends to use the same proxy as well.
This feature, allows only the traffic that goes to the k8s cluster (kubeapi) - to be routed via the proxy.

Signed-off-by: Elran Shefer elran.shefer@velocity.tech

@tonistiigi
tonistiigi requested a review from AkihiroSuda May 9, 2023 17:27
@AkihiroSuda

Copy link
Copy Markdown
Collaborator

Looks good, but please squash commits

Signed-off-by: Elran Shefer <elran.shefer@velocity.tech>
@IamShobe

IamShobe commented May 10, 2023 •

Copy link
Copy Markdown
Author

Done :)

@crazy-max
crazy-max merged commit 167340d into docker:master May 11, 2023
@crazy-max crazy-max added this to the v0.11.0 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants